From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA64EC433DB for ; Tue, 30 Mar 2021 10:53:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF1A161490 for ; Tue, 30 Mar 2021 10:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF1A161490 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zU+NpIiLj/hNn2p02MF5Ho5k3QZdHPUqdRCb0AUSibE=; b=OzSLMIbfRc8sDS1ecHygLOoaZ 6MvyoNdjloulDYKNdNVQwnQGlcfsCdzBmmMfEnjcBSKLZ8Kx4tBAhMd/gwl/dA80lJXeiEkNBASSU hKx99B0Aa3vOdo7gcCouq8Ad4jXEdFqrsICFD+xpHqXIvWVX+kDFkTc6eTZEOB0G68xmWlMDTfhNB CdWUmM5DZ1enFT0kIKLc3R4s5rP2Wxsj5Gb4hgaO+XhPruokn5dU/vsT1scDH4Ml73UsJMgAU1S3B HXrqSqQUJJZYz5JAvluUSE9A5KID5MWPbdUwa+DT5FIIbtvBpiv+SYZnBYSdxzXPMc5YyI6iLKo8v zxmMXBVyg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRByU-003T8s-Bf; Tue, 30 Mar 2021 10:51:55 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRBvZ-003SWn-NY for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 10:49:02 +0000 Received: by mail-io1-xd33.google.com with SMTP id z3so15905475ioc.8 for ; Tue, 30 Mar 2021 03:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rP4kknX4xAvleYYg0u92Em0z72hot5F8BzD9RddRRUk=; b=EbUxrwGTbHNhFj3dhzWvOVejXKYejKx9ObBGEO2MgczgMKQnT+vXFQRfGg8vrNb/79 KL/A0537a2GEjEYCAl7GY3oVE68vAS1j+oDWC6SotMtY9X5GCV/J4ATA4Uek1T+EnTTF /S+nYVBYnx+p8PzqDMOT6+sZ1DJeuObbYabHA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rP4kknX4xAvleYYg0u92Em0z72hot5F8BzD9RddRRUk=; b=q4/cQYCsdc4t6u0pBbaWEChfqJT+pCdPFT0apZM4dZEcLueyMOdkZJ7PXJP9DvccGE dUk+yiBFgraEUFsqwywr4+f7fP5AUx7EXtP8CIYO6kSy9p0VuF5sP+R/HzK1NvktROD2 UtdVAkBa2VYZORIFR2Q9SvrY0M1FCWkgVRCnKOvXHnv+hNV0/Knk2Zl3BKZdf8dik9dP LYd+BQ0+jQeM1DEi5cDWaQ9E9ofR5gDZQoyf2vLsAgKKAnWZ3x7yI2elockEOD0ql9/G SgEl9YCmI0tGP1K5E8FBpVwKEr0jODJhn6vfgHTVWZOTNCyK+R2zGfPUUpGQEJh6pqCF ZVPw== X-Gm-Message-State: AOAM5324kOkieRQaAYy7qgJivTLmt+2/eDMxXXe2RkyZPtQU8NjL/X1m QTq+z52RIsc1wgyYgwUg+lTjk/5J//0epnLNug4xyQ== X-Google-Smtp-Source: ABdhPJw/U5SlztC8bxQ7GW+0c8uKyz5qnR7FWLJK/549d5I/fXM+w1ZQvMlnX4P6c7fKXRSF8zGbDwvXCWFsbPHN0hA= X-Received: by 2002:a05:6638:2bb:: with SMTP id d27mr28069519jaq.98.1617101330606; Tue, 30 Mar 2021 03:48:50 -0700 (PDT) MIME-Version: 1.0 References: <20210203110717.686204-1-enric.balletbo@collabora.com> <8c8309fb-babe-3ed4-d2a1-111fbab91e9f@collabora.com> In-Reply-To: <8c8309fb-babe-3ed4-d2a1-111fbab91e9f@collabora.com> From: Hsin-Yi Wang Date: Tue, 30 Mar 2021 18:48:24 +0800 Message-ID: Subject: Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE() To: Enric Balletbo i Serra Cc: lkml , Matthias Brugger , Nicolas Boichat , Collabora Kernel ML , Boris Brezillon , Chun-Kuang Hu , Daniel Vetter , David Airlie , Philipp Zabel , dri-devel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_114854_147369_428FB74F X-CRM114-Status: GOOD ( 24.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 30, 2021 at 5:43 PM Enric Balletbo i Serra wrote: > > Hi, > > On 3/2/21 12:07, Enric Balletbo i Serra wrote: > > From: Boris Brezillon > > > > This patch adds the missing MODULE_DEVICE_TABLE definitions on different > > Mediatek drivers which generates correct modalias for automatic loading > > when these drivers are compiled as an external module. > > > > Signed-off-by: Boris Brezillon > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Hsin-Yi Wang > > A gentle ping for someone to review this patchset :-) > > Thanks, > Enric > > > --- > > > > drivers/gpu/drm/mediatek/mtk_cec.c | 2 ++ > > drivers/gpu/drm/mediatek/mtk_dpi.c | 1 + > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + > > drivers/gpu/drm/mediatek/mtk_dsi.c | 1 + > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 1 + > > drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 + > > 6 files changed, 7 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c > > index cb29b649fcdb..3b86e626e459 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_cec.c > > +++ b/drivers/gpu/drm/mediatek/mtk_cec.c > > @@ -7,6 +7,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -247,6 +248,7 @@ static const struct of_device_id mtk_cec_of_ids[] = { > > { .compatible = "mediatek,mt8173-cec", }, > > {} > > }; > > +MODULE_DEVICE_TABLE(of, mtk_cec_of_ids); > > > > struct platform_driver mtk_cec_driver = { > > .probe = mtk_cec_probe, > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > > index 52f11a63a330..2680370652fd 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > @@ -822,6 +822,7 @@ static const struct of_device_id mtk_dpi_of_ids[] = { > > }, > > { }, > > }; > > +MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids); > > > > struct platform_driver mtk_dpi_driver = { > > .probe = mtk_dpi_probe, > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index 5f49a809689b..e4645c8ae1c0 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -470,6 +470,7 @@ static const struct of_device_id mtk_drm_of_ids[] = { > > .data = &mt8183_mmsys_driver_data}, > > { } > > }; > > +MODULE_DEVICE_TABLE(of, mtk_drm_of_ids); > > > > static int mtk_drm_probe(struct platform_device *pdev) > > { > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 0527480c07be..c71ce62d1bec 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -1193,6 +1193,7 @@ static const struct of_device_id mtk_dsi_of_match[] = { > > .data = &mt8183_dsi_driver_data }, > > { }, > > }; > > +MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); > > > > struct platform_driver mtk_dsi_driver = { > > .probe = mtk_dsi_probe, > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > index 8ee55f9e2954..b4696a9d73f7 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > @@ -1818,6 +1818,7 @@ static const struct of_device_id mtk_drm_hdmi_of_ids[] = { > > }, > > {} > > }; > > +MODULE_DEVICE_TABLE(of, mtk_drm_hdmi_of_ids); > > > > static struct platform_driver mtk_hdmi_driver = { > > .probe = mtk_drm_hdmi_probe, > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c > > index 62dbad5675bb..6207eac88550 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c > > @@ -335,6 +335,7 @@ static const struct of_device_id mtk_hdmi_ddc_match[] = { > > { .compatible = "mediatek,mt8173-hdmi-ddc", }, > > {}, > > }; > > +MODULE_DEVICE_TABLE(of, mtk_hdmi_ddc_match); > > > > struct platform_driver mtk_hdmi_ddc_driver = { > > .probe = mtk_hdmi_ddc_probe, > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel