From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F242DC28CC0 for ; Wed, 29 May 2019 04:19:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0E532075C for ; Wed, 29 May 2019 04:19:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c/k7Kgl5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hYOi8BkF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0E532075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KAR/oIWleZMwVFWwl3NBKBEKylmy2mIYrPB6GbsRZVc=; b=c/k7Kgl5E92tR7 aweSMe6jOlYbKuDwXgFMQgB/MmQAI2miaUlN7Mcp4R+QVcFSuNteDJa+915rt9q72K5xm/Zhd/t/Z 6NL1hA65+Cza0XJk05IzKZgZdCuCifNfWf7o71QhAoJfJJrzFsmmt1wcsuwPeh/5A//DSSFeziaKg PnmTH7atPgp6mG2e/p+Tgrn8CY6x8c1gr/BTxtn7Wolh0Qd/a7U92Jo4sCFH4MP88dKGeJL7Cfpqk A29dBibt2w0pHgKwkjADVyZJvUx643KgtU4LWt0WgjMncWKVdGpOJlg07Wo18k8o7oxhcPVHFvSkD zb9WqAk/R+qT4PjyBzkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVq40-0001wx-9n; Wed, 29 May 2019 04:19:44 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVq3w-0001vE-Db for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2019 04:19:41 +0000 Received: by mail-qt1-x82e.google.com with SMTP id m2so937402qtp.11 for ; Tue, 28 May 2019 21:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FnqQyLt42DZ9noxJLCU2V14s5enRSAf3rpEHwRX9Kzo=; b=hYOi8BkFEY0SXxqQqLEZF9NnP9Pbvi1wS7yC9BK9JmRFXUan60kY7zFDXyLITqTDUS 7ll6TdMYTzb7zrvvduAaFLWu3eONcUAliDarfOiByT5Tx+eF5Mcj8TPYuztHIg075hAh AaICUAmx02EeefvpAqjSqQcUnil3D9/4DGJhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FnqQyLt42DZ9noxJLCU2V14s5enRSAf3rpEHwRX9Kzo=; b=cgfMF+ft05VnNfS/+/xV5Fc6F/x4cjtnJ2kbPsjFJvquduL+X0RQ0Oa8TEylmWEnPw QjB8EsZUPgvQoEOSLQfdS/iR+EdlkS2BLAY1A4P+wOuoFRg739e7YZQmphA4t5hbOLDd dh4gBkJYgA/6nDAYEu16zogrB08YBJKcxy4SVpcHPV4UYxORftH5mOoldRB5ZCKQ3/Cf +FaFnistkgygfuP9Hnsc+Ma8XNFZVQ0yr0E5f08+feBBY9HfRq7DwoDOsfThfrLzqfBl i3kZ0ugLBnqh82Z/BU0guttkWr7zUZZLgmD+8GdddtCjhS3gkkRConP4v8C6/FQS+moI +NHw== X-Gm-Message-State: APjAAAVY40Dfb7h7FHh6CZt8iC1Rpm2NhvCWydldFA+jooDoLYrj8cVz rDIefgyH8TWfLOVaO3oZ9cvXVaSfTMBRTcVNRsbUOw== X-Google-Smtp-Source: APXvYqxQjVrzoCeL6L4KHpLXuAIIoAai4JlsMWOYefX4hqGGu7mkiavfm3JE86Sp3YUok2L/Ps2IUpK+ghjSMUbbU7I= X-Received: by 2002:a0c:b66f:: with SMTP id q47mr23601745qvf.102.1559103577129; Tue, 28 May 2019 21:19:37 -0700 (PDT) MIME-Version: 1.0 References: <20190519092537.69053-1-jitao.shi@mediatek.com> <20190519092537.69053-2-jitao.shi@mediatek.com> In-Reply-To: <20190519092537.69053-2-jitao.shi@mediatek.com> From: Hsin-Yi Wang Date: Wed, 29 May 2019 12:19:11 +0800 Message-ID: Subject: Re: [v3 1/7] drm/mediatek: move mipi_dsi_host_register to probe To: Jitao Shi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_211940_455038_C7D984D8 X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , stonea168@163.com, dri-devel@lists.freedesktop.org, Ajay Kumar , Vincent Palatin , cawa.cheng@mediatek.com, bibby.hsieh@mediatek.com, CK Hu , Russell King , Thierry Reding , Sean Paul , linux-pwm@vger.kernel.org, Sascha Hauer , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com, Matthias Brugger , eddie.huang@mediatek.com, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Rahul Sharma , srv_heupstream@mediatek.com, lkml , Philipp Zabel , Kumar Gala , Andy Yan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 19, 2019 at 9:25 AM Jitao Shi wrote: > @@ -1045,12 +1045,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > return ret; > } > > - ret = mipi_dsi_host_register(&dsi->host); > - if (ret < 0) { > - dev_err(dev, "failed to register DSI host: %d\n", ret); > - goto err_ddp_comp_unregister; > - } > - > ret = mtk_dsi_create_conn_enc(drm, dsi); > if (ret) { > DRM_ERROR("Encoder create failed with %d\n", ret); > @@ -1060,8 +1054,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > return 0; > > err_unregister: > - mipi_dsi_host_unregister(&dsi->host); > -err_ddp_comp_unregister: > mtk_ddp_comp_unregister(drm, &dsi->ddp_comp); > return ret; > } > @@ -1097,31 +1089,37 @@ static int mtk_dsi_probe(struct platform_device *pdev) > > dsi->host.ops = &mtk_dsi_ops; > dsi->host.dev = dev; > + dsi->dev = dev; > + ret = mipi_dsi_host_register(&dsi->host); > + if (ret < 0) { > + dev_err(dev, "failed to register DSI host: %d\n", ret); > + return ret; > + } > Since mipi_dsi_host_register() is moved from .bind to .probe, mipi_dsi_host_unregister() should also be moved from .unbind to .remove? Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel