From: ta.omasab@gmail.com (Thomas Abraham)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: exynos: Fix driver compilation with ARCH_MULTIPLATFORM
Date: Wed, 21 May 2014 18:02:06 +0530 [thread overview]
Message-ID: <CAJuA9ajHAyB6eLe0nQiNcCAS1ojG7W+FTJ1EH62H3Ch-DP2bcw@mail.gmail.com> (raw)
In-Reply-To: <537C9B81.5040301@samsung.com>
On Wed, May 21, 2014 at 5:56 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> On 21.05.2014 14:21, Arnd Bergmann wrote:
>> On Wednesday 21 May 2014 13:12:32 Tomasz Figa wrote:
>>> Currently Exynos cpufreq drivers rely on globally mapped clock
>>> controller registers to configure frequency of CPU cores. This is
>>> obviously wrong and will be removed in near future, but to enable
>>> support for multi-platform builds without introducing a regression it
>>> needs to be worked around.
>>>
>>> This patch hacks the code to look for clock controller node in device
>>> tree and map its registers using of_iomap(), instead of relying on
>>> global mapping, so dependencies on platform headers are removed and the
>>> driver can compile again with multiplatform support.
>>>
>>> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
>>> ---
>>> drivers/cpufreq/Kconfig.arm | 6 +++---
>>> drivers/cpufreq/exynos-cpufreq.c | 2 --
>>> drivers/cpufreq/exynos-cpufreq.h | 30 ++++++++++++++----------------
>>> drivers/cpufreq/exynos4210-cpufreq.c | 31 +++++++++++++++++++++++++------
>>> drivers/cpufreq/exynos4x12-cpufreq.c | 32 ++++++++++++++++++++++++++------
>>> drivers/cpufreq/exynos5250-cpufreq.c | 35 +++++++++++++++++++++++++++--------
>>> 6 files changed, 95 insertions(+), 41 deletions(-)
>>
>> Isn't this completely obsoleted by Thomas Abraham's work on cpufreq-cpu0
>> support in Exynos? I thought that was going to make it for 3.16.
>
> That would be the best solution, but we need at least one more version
> of that series and I'm not sure if it isn't already too late to merge it
> for 3.16.
I have addressed most the comments on the v4 patches. I will post v5
of the cpufreq consolidation patches a little later or early tomorrow.
Thanks,
Thomas.
>
> Best regards,
> Tomasz
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-05-21 12:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 6:52 [PATCH 0/3] Exynos multi-platform support Sachin Kamat
2014-05-21 6:52 ` [PATCH 1/3] ARM: EXYNOS: Consolidate Kconfig entries Sachin Kamat
2014-05-21 6:52 ` [PATCH 2/3] ARM: EXYNOS: Enable multi-platform build support Sachin Kamat
2014-05-21 8:16 ` Arnd Bergmann
2014-05-21 8:20 ` Sachin Kamat
2014-05-21 10:36 ` Bartlomiej Zolnierkiewicz
2014-05-21 11:14 ` Sachin Kamat
2014-05-21 13:40 ` Kukjin Kim
2014-05-21 14:02 ` Bartlomiej Zolnierkiewicz
2014-05-21 6:52 ` [PATCH 3/3] ARM: multi_v7_defconfig: Enable Exynos platform Sachin Kamat
2014-05-21 8:26 ` [PATCH 0/3] Exynos multi-platform support Tomasz Figa
2014-05-21 11:12 ` [PATCH] cpufreq: exynos: Fix driver compilation with ARCH_MULTIPLATFORM Tomasz Figa
2014-05-21 11:17 ` Tomasz Figa
2014-05-21 11:22 ` Viresh Kumar
2014-05-21 12:11 ` Tomasz Figa
2014-05-21 12:21 ` Arnd Bergmann
2014-05-21 12:26 ` Tomasz Figa
2014-05-21 12:32 ` Thomas Abraham [this message]
2014-05-21 13:31 ` Kukjin Kim
2014-05-21 14:05 ` Viresh Kumar
2014-05-23 14:52 ` Tomasz Figa
2014-05-23 15:22 ` [PATCH v2] " Tomasz Figa
2014-05-25 21:41 ` Kukjin Kim
2014-05-26 5:40 ` Viresh Kumar
2014-05-26 22:06 ` Kukjin Kim
2014-05-26 5:40 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJuA9ajHAyB6eLe0nQiNcCAS1ojG7W+FTJ1EH62H3Ch-DP2bcw@mail.gmail.com \
--to=ta.omasab@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).