From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC453C3DA7F for ; Wed, 7 Aug 2024 15:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NlnZYQxOZR6uyHBd01U2SFCiDgzZOOt4cRJmmfiCr2o=; b=D6tVcjBe6g+f2nlJ9bDwt4gL5r m1Ygyq89u3t2Bejv6OOp9nltKnhC237HYd6nEzTmOIEigEEb6X/vETGJdlaSnWIi+N9eB/4OWo9mq 63LSxo/5vZagu+18ePbtW1JfMCV2nIXUO48/V5vfq0TqeTTGKeMP4ybBNeFs+RuayYP7QVpFVZcUd DG2eZUVtHcsWyQGeFFn0m76oDGiQzWhYaMTzxz5MN+B/2gHlr/9cU2FNA6N2drZFeyMIW2Z2J4p45 40luo6gEXgD+LKbTdiU/my15tkbFar5iMk+SZwFzF3/x/QnP94qyCPIsQTM4oqHhMq7WmcS/3Opc/ QDlEqj2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbihr-00000005XUc-0bOx; Wed, 07 Aug 2024 15:36:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbih7-00000005XKu-17EJ for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 15:35:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2D946611E0 for ; Wed, 7 Aug 2024 15:35:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0593EC4AF15 for ; Wed, 7 Aug 2024 15:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723044919; bh=wm+VWb1rIQaode09oZdE3sEothizpQCW8kQNxXyWPUY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ATifhC0Xqq0fEe+6e3QBEUliaGC/RbH+BLtwnYSFm80CEEuXHBNyAhkdxqzD7/He2 PwBneWqEUKypiverT0BJeASdXPA4xWYAl2Fkgm10SugKbi+AvScSanh1joAX8Lfmdz KNRPzst2mgF9+1hD/hVdNmv6TzqF0PgyyUodxI6txDAuQNXQBWeHjjnRiNj0hi9VFR 4s6ZMFW5SFkhmRGf+WuQyky1G/K5ad5iSm4yfiVc+3668PKhJ6odz+5QYopqnVL/FP XR95KBjUkyyEZlo8paXYX4cQdTts2wfmd+JcEtHB6KS9KmZ7swK2irnC/LQ+FHdEOK ieljN71TadH9g== Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2eeb1ba0481so27358551fa.2 for ; Wed, 07 Aug 2024 08:35:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXSMKhq+02ILFaZwW3Y74y7UWMu47Zqyx7Y+KBRPBSAVzBdTqTNFYgb0jWJsYIMwP1O5scjU6Am7Uu/OxrymUAMfHSTJQdaaiPvrRrnIwC9cC0DSbE= X-Gm-Message-State: AOJu0Yxh7P2mddzM0CJLqqRZwdEIeVmiJdw6OGj7IQXUKoDgRCAVo8LN D+DQYF4AQJA965lgrK4hv0b3BiWV6CEj6PDgZEnsYCF1jhUReowpNcTnCcYV0aTbhZTW5T7Ob1a 1bOzb1b6sT7bECJGrsUI9d3jusSQ= X-Google-Smtp-Source: AGHT+IE/eDS6clCryBkFSzKDJUwO/cLwR+b8LrrNB5prXOgRnnwpkLjNgCVKxPqUzynolVNIM+yIL57HzFJ8CFIwBnI= X-Received: by 2002:a05:6512:3e1e:b0:52c:df51:20bc with SMTP id 2adb3069b0e04-530bb3b1531mr13674055e87.16.1723044917569; Wed, 07 Aug 2024 08:35:17 -0700 (PDT) MIME-Version: 1.0 References: <20240807-macos-build-support-v1-0-4cd1ded85694@samsung.com> <20240807-macos-build-support-v1-5-4cd1ded85694@samsung.com> In-Reply-To: <20240807-macos-build-support-v1-5-4cd1ded85694@samsung.com> From: Masahiro Yamada Date: Thu, 8 Aug 2024 00:34:41 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/12] accessiblity/speakup: genmap and makemapdata require linux/version.h To: da.gomez@samsung.com Cc: Nathan Chancellor , Nicolas Schier , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Greg Kroah-Hartman , Jiri Slaby , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, speakup@linux-speakup.org, selinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-serial@vger.kernel.org, llvm@lists.linux.dev, Finn Behrens , "Daniel Gomez (Samsung)" , gost.dev@samsung.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_083521_449894_5B1DA46A X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org genmap and makemapdata DO NOT require linux/version.h Removing bogus "#include " is the right fix. On Wed, Aug 7, 2024 at 8:10=E2=80=AFAM Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > Both genmap and makemapdata require the linux/version.h header. To > ensure successful builds on macOS hosts, make sure usr/include is > included in the HOSTCFLAGS. > > Fixes errors: > drivers/accessibility/speakup/genmap.c:13:10: fatal error: 'linux/version= .h' file not found > 13 | #include > | ^~~~~~~~~~~~~~~~~ > 1 error generated. > > drivers/accessibility/speakup/makemapdata.c:13:10: fatal error: 'linux/ve= rsion.h' file not found > 13 | #include > | ^~~~~~~~~~~~~~~~~ > 1 error generated. > > Signed-off-by: Daniel Gomez > --- > drivers/accessibility/speakup/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/accessibility/speakup/Makefile b/drivers/accessibili= ty/speakup/Makefile > index 6f6a83565c0d..74ee0c31370f 100644 > --- a/drivers/accessibility/speakup/Makefile > +++ b/drivers/accessibility/speakup/Makefile > @@ -38,6 +38,7 @@ clean-files :=3D mapdata.h speakupmap.h > # Generate mapdata.h from headers > hostprogs +=3D makemapdata > makemapdata-objs :=3D makemapdata.o > +HOSTCFLAGS_makemapdata.o +=3D -I$(srctree)/usr/include > > quiet_cmd_mkmap =3D MKMAP $@ > cmd_mkmap =3D TOPDIR=3D$(srctree) \ > @@ -51,6 +52,7 @@ $(obj)/mapdata.h: $(obj)/makemapdata > # Generate speakupmap.h from mapdata.h > hostprogs +=3D genmap > genmap-objs :=3D genmap.o > +HOSTCFLAGS_genmap.o +=3D -I$(srctree)/usr/include > $(obj)/genmap.o: $(obj)/mapdata.h > > quiet_cmd_genmap =3D GENMAP $@ > > -- > Git-146) > > -- Best Regards Masahiro Yamada