From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition
Date: Fri, 23 Sep 2016 22:33:47 +0900 [thread overview]
Message-ID: <CAK7LNAT_Kqm3t_pXuqKxG_p=N504NRKWKoVAFRiv0Fq1LHJQBQ@mail.gmail.com> (raw)
In-Reply-To: <20160923121245.GA1580@katana>
Hi Wolfram,
2016-09-23 21:12 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>:
> On Fri, Sep 23, 2016 at 09:04:01PM +0900, Masahiro Yamada wrote:
>> Currently, the status register FI2C_SR is checked immediately after
>> a STOP condition is issued in case of the deferred STOP condition.
>> It takes typically 5-10 usec until the corresponding bits in the
>> register are set, so the error check for "stop condition was not
>> completed" is very likely to be false positive.
>>
>> Add wait code to relax the status register check.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Use readl_poll_timeout?
>
Yes, thanks for your advice!
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2016-09-23 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 12:04 [PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition Masahiro Yamada
2016-09-23 12:12 ` Wolfram Sang
2016-09-23 13:33 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAT_Kqm3t_pXuqKxG_p=N504NRKWKoVAFRiv0Fq1LHJQBQ@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).