From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87C7FC433F5 for ; Tue, 19 Apr 2022 15:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N2qUva9rBbOgth7e1eQ9FD/d4qHyFmg+P1qvqC3uVGs=; b=0dQaZTanW61Jzn Bj92/VjVgEjEc5JZi1AXGvj1YN4E26FgBlj9XuAXYwgpkU3SWxYwKk3HzLkVGF2UbPLhl83S1VrWF ezpBjw2X9KhsEU/F9RjJWPRClAuOvfj9T53bZweGv6MbYd7VRyB5TS5NyXdBdwKtjXHzyMQXWxBZA W5SvdyCmwjquDWfs1uhvBO/PHLu/MiwzV78q3j85UBJpOc/ivqvomJC+MOwNIY/oXagWAF01tbral leK83t4/Fq6/74GSbmdsASsGFScvhzseECSRt0P4Tam0vFQCzKg+PxGM3KF4XU3mchWfInihI8zKz mc2SWpWmAg3ZYl5xQ1pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngq1Z-004lm8-1w; Tue, 19 Apr 2022 15:44:18 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpy6-004k4Y-DQ for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 15:40:44 +0000 Received: from mail-wr1-f42.google.com ([209.85.221.42]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M5fQq-1nZg1n3wU6-007APL for ; Tue, 19 Apr 2022 17:40:37 +0200 Received: by mail-wr1-f42.google.com with SMTP id u3so23012782wrg.3 for ; Tue, 19 Apr 2022 08:40:37 -0700 (PDT) X-Gm-Message-State: AOAM5336wlzkCc1VmwY7WaFykhMwti5jggiP2137lAOOmwyNejOxxW12 82DV0JmBd+YgaSigPMzLJ12N8c1auc8P8QYPojs= X-Google-Smtp-Source: ABdhPJx2j14opnoXVu+zRZ4O7R0W4B6Te+BYkmuTotpIld2KFF5dVZxiMPz0Ry5HHgFRVQndxUG068ioQAMMaGHobtE= X-Received: by 2002:a5d:6983:0:b0:207:a226:df4b with SMTP id g3-20020a5d6983000000b00207a226df4bmr12156987wru.192.1650382837528; Tue, 19 Apr 2022 08:40:37 -0700 (PDT) MIME-Version: 1.0 References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-21-arnd@arndb.de> <87o8y0lgs1.fsf@belgarion.home> In-Reply-To: <87o8y0lgs1.fsf@belgarion.home> From: Arnd Bergmann Date: Tue, 19 Apr 2022 17:40:21 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 21/46] ARM: pxa: spitz: use gpio descriptors for audio To: Robert Jarzmik Cc: Arnd Bergmann , Daniel Mack , Haojian Zhuang , Linux ARM , Linux Kernel Mailing List , Linus Walleij , Mark Brown , ALSA Development Mailing List X-Provags-ID: V03:K1:aHJO/rmvJu4r1ehdoD0CHt03PphbYieonpFi3fC16Xd37C1HJVO 4Vi9B2ceS/5anRfvtNElqDCQY7Hpobp8NVaUbwwNU+FRwEZUuBTw9ggPXHA9ihBd0pqupKL n+IqtqTGphXX/IepTqZ/Ao/mc6Xz9i0St3TZNzAdAuIoSqDSCTPx6AnGLz8WRqk+vbEFgxH O4Fd/oPJmwSHqY7ca/hlA== X-UI-Out-Filterresults: notjunk:1;V03:K0:VPBr2dEDkGI=:b5Vhgy6iFuaW5yxBp4C89Z swO9NjiRdw8aQWjAZXKymgFyRqrMO+mLBUJ7QUSpnlvP53hmvPRuXbAq9b5kTu9JYak9zp44M 2ccM/NlxcwW6SBHljF5BTm+hTccNSOSm799NHxhnth2Lti8zOFYQerxum7+pAOCcHx/IflotX e8gnSetOIIuGd3FE/8M/5YFenzI8bU9qYTlc0O0y85fcJY2GfyDRX8c7+r+jKpbr0clWPbNTG 0I83g2biCdH+BtubJv6a/IQP8/WXiLH7QaxJ2prKGP7GKuhkvii/+zIdCs1FSRj3sII3Ulk/l VWyddNOsg0Sd0cOPmmEs3EU2rgQ2qetuBkzvWV98zahqywcOKGG3hiplWEfgMnAClqsNURpBZ j2uMlpvIvdpqpPVyy36D/P/FeEFR+y7BCEsHn5LddUz4zbHBMVdtdpvxyATIoBQJgCHvfdS5m VPTDZJQsb8YZRYiqcoHzydewgYMYRos39W7alRIPsldZKQbaGZhK21MCeK1gHdTpXXUj7UKwA RLbdZidMlfkQalGW8OdMV/dTL5535bAGNLa7jUb2amvYGOKgde4rQN6PY0UZtpNEZVB83R3C0 5FNExMDn5Z/lZ5yd3pMFRnFSdqk4ASKWpNfwzgfAtioJyROfQRzTWWUwOwdsSGaCGhYnTdgwD 3ybdRQz6CB+b+RwjvsAMgG5FhwGIBKHqlNVG8M+tsRSQs8wXiq8p5r8kaxprEY26wBV0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_084042_786536_95C2794E X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 28, 2019 at 10:08 PM Robert Jarzmik wrote: > > +static struct gpiod_lookup_table akita_audio_gpio_table = { > > + .dev_id = "spitz-audio", > > + .table = { > > + GPIO_LOOKUP("sharp-scoop.0", SPITZ_GPIO_MUTE_L - SPITZ_SCP_GPIO_BASE, > > + "mute-l", GPIO_ACTIVE_HIGH), > > + GPIO_LOOKUP("sharp-scoop.0", SPITZ_GPIO_MUTE_R - SPITZ_SCP_GPIO_BASE, > > + "mute-r", GPIO_ACTIVE_HIGH), > > + GPIO_LOOKUP("gpio-pxa", AKITA_GPIO_MIC_BIAS - AKITA_IOEXP_GPIO_BASE, > > + "mic", GPIO_ACTIVE_HIGH), > This last one looks a bit dubious, as it looks like a gpio on a gpio expander, > could you cross-check that "gpio-pxa" shouldn't be an I2C expander gpio please ? I'm revisiting this older patch series now, this was clearly a mistake in my original version, changed it now to @@ -982,7 +982,7 @@ static struct gpiod_lookup_table akita_audio_gpio_table = { "mute-l", GPIO_ACTIVE_HIGH), GPIO_LOOKUP("sharp-scoop.0", SPITZ_GPIO_MUTE_R - SPITZ_SCP_GPIO_BASE, "mute-r", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("gpio-pxa", AKITA_GPIO_MIC_BIAS - AKITA_IOEXP_GPIO_BASE, + GPIO_LOOKUP("i2c-max7310", AKITA_GPIO_MIC_BIAS - AKITA_IOEXP_GPIO_BASE, "mic", GPIO_ACTIVE_HIGH), { }, }, I'm not 100% sure this is the correct name, as I don't fully understand how i2c device names are constructed. I see that Linus added a device name in commit 32d1544880aa ("ARM: pxa: Add gpio descriptor lookup tables for MMC CD/WP"), and I guess I could do the same here, but I think that was only needed to disambiguate two instances of the same device in zylonite, which is not needed for spitz. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel