From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD62CC433F5 for ; Thu, 31 Mar 2022 11:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B3mjG2dXrSmW8ezxS7P1XdPezObeGPRoTZMVHXHcOhg=; b=CbPh7OI8nI9yKG GR+VMKP9TtIBv4/5dmqU929sXcyjtNM9tqesU1bItwc7gsR7YgAvfO5jRU428RSZZPgTYFRBqANMg 3GiWUjgO8mtwcZo3Ls8ne1kku1C0J2HhTiz4njVlNNfVa4D4gq+O7cu8f25qn7W4YxsVZSIW/41O8 e9XqY+aSeFgp9G1Q9BVJwbX8wpzv71Mg1sIruodGzX1vJR0Cb8by1UysxDoy2MNscqknVMT47k87L ldGFRXG9xe5eOqLRkZWOdEnyKztQ/MA0fkYc/QEAaQJewI9jfgWjzQeRYOmNnB6l3YFwCuvcBQsXM SX1/c8Cf2uZ+KxkBTorA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZsci-001xYx-Ho; Thu, 31 Mar 2022 11:05:52 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZscd-001xWv-Dq for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 11:05:50 +0000 Received: from mail-ej1-f46.google.com ([209.85.218.46]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MMXcP-1nHWgx1Mzn-00JanE for ; Thu, 31 Mar 2022 13:05:44 +0200 Received: by mail-ej1-f46.google.com with SMTP id p15so47280186ejc.7 for ; Thu, 31 Mar 2022 04:05:44 -0700 (PDT) X-Gm-Message-State: AOAM533kYxlJyJ5l2RrJZVTm7aBgKbwRtn5zmQaniW4YppcphwJhTx1T vMwSxx3ZHOIxaj1O1MRts/Wkqtyqen4Zs7uh2Mo= X-Google-Smtp-Source: ABdhPJxblHzN8A8TvuiEkXNzMUEBbbuh2/h0a120rBFukLWeh1t2dCBmStJdCyrkTUm6pSHNZoOJL8soa/bMgZk8Rj4= X-Received: by 2002:a5d:6505:0:b0:205:9a98:e184 with SMTP id x5-20020a5d6505000000b002059a98e184mr3195582wru.317.1648718240005; Thu, 31 Mar 2022 02:17:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 31 Mar 2022 11:17:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver To: Qin Jian Cc: Krzysztof Kozlowski , Rob Herring , Michael Turquette , Stephen Boyd , Thomas Gleixner , Marc Zyngier , Philipp Zabel , Russell King - ARM Linux , Arnd Bergmann , Linux ARM , DTML , Linux Kernel Mailing List , linux-clk X-Provags-ID: V03:K1:2WkduLbVqStuAmeS30ol0nRpmfJFCcDoKMDhpEA3s204UoqfMX9 rJUfLAaL4r94uxXjHUSzcVVLV5kGDA0JFlrTbYqY0ho/MsJsZB9t9QwLbno6ukB6rt28ls+ s/XewN70doMTZeaeWDv3982sK8AQTltURd+itIGHuua63pzaSWsYnLG0eESChd19N0YHzJ5 cDPvOCxgdkzFai8NhcuGw== X-UI-Out-Filterresults: notjunk:1;V03:K0:D0rDWt024DM=:6eOwMPhOl8JLhVGgWkgWRb xbNfP2sfVYoP4aRzRpe/K6YvioZr4jRV6fOEgrj9Oln2oWw9McX5J4dyLs8J6eShynfxjCmST scwycjHJzbWk3M8Z8urDbJxyr5jDgc7r04zj+NnlLOUHpJ+PM37Z+cdTtJTOTxi5K6plwFZKN +YYpiaBkwvLZDTbX5C4YxNp9UMleose6TYpEvl5gxe2kq8lwxvALfC3rQhF3VId+L2dLhAcG7 p90ZXXflljeys6tcKVO/XzBxffC84VXoqnmdaJ7V7YhvdMC4231yqFuEgbmCwFbRrLOXYB7O5 LE8e/AqO0A8URDGn/qG97VqM8JYfipPvsSCcelGgtQiEfkz/e5rFCDbL77K0xfPBmmKfNcwr4 /v2ZIJOeTDfDiJIHl38KtG7q4OAn6LGwWoVB3ICfEx7VrBFOI5HSTJdPyxNw9MWV5wLDdX5JD SwKbiCZCo48EXNbNlGBPNdrO2cWPyoN1fVYohNOvetLnnKjtO1LDVTTTmLCxexM1gfrM5uTrj FkkavFHal9XehyW+dotw/p4bzHuNdNUPNawAHEndGAhG3KSg5P1Mejhy4SmsVtxDJyFXTaAA3 dOn1ONxk+1XSICxjXWym3SgyF0qTubPxIHivdR751gHwYon1DY2tzE4Jq7CV7Na/pUPWhrarS mvZdRAfz/3hRlRVgHevBQgQYrVOZz3m6cw+rVNv0sBc3QzU7iI/wx03PRcN7SF4xhlFOZ09RL iSRaKCFL8ejlpkNsKL+f1lg8AVOfTejnCHWxRZHM/AGZz9wTW8kzMaevVByRwEIdjYlSW5nJP QQ3dR8g1Fm31DTaQ+nYraxxCyLELjbrBYwQ1RLpPFXow+e2k7w= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_040547_800726_A905F404 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 10:29 AM Qin Jian wrote: > +#ifdef CONFIG_SMP > +static int sp_intc_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force) > +{ > + return -EINVAL; > +} > +#endif > + > +static struct irq_chip sp_intc_chip = { > + .name = "sp_intc", > + .irq_ack = sp_intc_ack_irq, > + .irq_mask = sp_intc_mask_irq, > + .irq_unmask = sp_intc_unmask_irq, > + .irq_set_type = sp_intc_set_type, > +#ifdef CONFIG_SMP > + .irq_set_affinity = sp_intc_set_affinity, > +#endif > +}; I don't think you need to define an irq_set_affinity() callback at all if you just return -EINVAL, all the callers should have a check already. Even if you do need the function, I think you can remove the #ifdef, as long as the function itself can be built that way. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel