From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22611C4338F for ; Fri, 23 Jul 2021 13:48:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E893260EBD for ; Fri, 23 Jul 2021 13:48:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E893260EBD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qqWh3s/zaM0EtnR0e2mjYMgO1hBVQ1cFRb5Y7JpCqc8=; b=XTYpWX/YFgLCmq YAJcdRQCNmNy5WmQ79EbaQi+sVETV0SARKtVY0vQV/h3VdHnoxAPWVDm0bWYpmGgBU9RUpSKUHySR nwQEwV4OWh7mv345aFQxdY7wHPj/ZoHYihFwfxmNtYHEduV4pmh1Xyj6sWHm/bln96Q/CxTVniA/k qLKMnJXqikhGJgCv1dR5ykwvwbWL9jFGlynVGp4AYfZRN1ZvCJ89O24jU+QwFEmafdHVSi0UP76Pf HL4evxYpHfzuSWUhH+5/Df9njJBOxqCFkNAcnOZstFd5arqxSh0Pv5k3uafwqM7mUhsX22y2fDcqI rb2X0NGlGwSoi6NHj5lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6vVk-004uBA-K3; Fri, 23 Jul 2021 13:46:44 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6vVZ-004u7h-Eq for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 13:46:35 +0000 Received: from mail-wm1-f51.google.com ([209.85.128.51]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MRBWU-1llys63Waq-00N7vs for ; Fri, 23 Jul 2021 15:46:30 +0200 Received: by mail-wm1-f51.google.com with SMTP id h24-20020a1ccc180000b029022e0571d1a0so1633019wmb.5 for ; Fri, 23 Jul 2021 06:46:30 -0700 (PDT) X-Gm-Message-State: AOAM530qXm4NglczehBGycSN+RxRT0pQ7St2ZDKj79hOv6noTSW88uu3 QyKV0IZuME+/XhfHJPJUk1ftSn8MDoaQMI2oc+Y= X-Google-Smtp-Source: ABdhPJyfbJ/TTAuOw7j89Wul0Xg+2CYe0Hm+3Y35Empz4DlbpbFzr1NRRDGERsVfUMwmu0uZ4yYDMTYgM127TEzwEVk= X-Received: by 2002:a7b:c2fa:: with SMTP id e26mr14345036wmk.84.1627047990248; Fri, 23 Jul 2021 06:46:30 -0700 (PDT) MIME-Version: 1.0 References: <20210723132810.25728-1-alexandre.torgue@foss.st.com> In-Reply-To: <20210723132810.25728-1-alexandre.torgue@foss.st.com> From: Arnd Bergmann Date: Fri, 23 Jul 2021 15:46:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] Add STM32MP13 SoCs and discovery board support To: Alexandre Torgue Cc: Linus Walleij , Arnd Bergmann , Olof Johansson , Rob Herring , Russell King , Jonathan Corbet , "open list:GPIO SUBSYSTEM" , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , DTML , "open list:DOCUMENTATION" , Maxime Coquelin X-Provags-ID: V03:K1:clzDB/WV9fqqBTmWDI8NDaJRZzmZld6l6FpThGee5qxg0p06Tum aI9ErOtiOObV4zgIeNZiFOnKodKoU4RISBRdoG7oCoIVu1JaxlMh+VF5VAFsU15akAJN0Io 2AYRtd1ajJnkeI17wJNXt43Fvcc9AFp1uTkEoou7x5lMGWIDpEqyQ+vqvSTXaLhFvMEQJXW AcA+hC1KVzyh3esuNn+LA== X-UI-Out-Filterresults: notjunk:1;V03:K0:zZXVEENWn7c=:PmFl/pNJbQpj8jfm8a1NtB m3IY/60vLOe/1PkEtLCX32qn7MX7MIs2a9afarnRWQjcP/CFo7N/AYB8w2eUovTKWRVeTtAcC JO60JmpbCp/GwltZfYgDbv2RzpXlaQh7CK6LfnZZUsMrmnOWcvU/WnWsrNgcl0CG//Ur07+QV 8Ht9Wk4tCKwhu+WfFbTdwAnqH3bei+C78w0hXVHhNTb3xwFazRQY0Ujka32IJxgfxpeyeCAdo XdoONgLoYtl4gDDW3tHY3COmbGW6NDPrFEjKCQd8BwV+mMiM31sl4Vav9Ll2ViZOoB8iynHI2 tzc9g7k6UNLg9MDLa5ud6WiRYagE1nwVIJGK2Si2pOsRcbqmpY4ASJVvNCJHli3/ydgfzu13p ChIYZcsJumtuqxUCI3E7XcxfCdRizfoBVm8Um0Shmx+JL35tG9hsau/bb8GaoYGjW5IljWCnL +n+0N8X3/hOknP4Lk0w2ItGFlrshU04afHBscmN5XxNxLbs9b2nJvcHWflKA2xbO6t72zrokn u/T3QePbja8YPNTn8rRZzGeHFIBSH3MtHOelDANpAnvAL4CRv+L9BvbCoRuOkGMtqxDnxiss2 APNd62FW9eNqa/2M5CFjy41QT2/q2NGySsZOKsF9Y0gwAdchk+fivqtD38g88Ob5KEqbLqd4H 7CKg9C36hjFj6kiLxtuOkOS2MRQM0U/MnOzH2ikzIM9TyeyoCGGAQDuT6O7zNo7As/kw+wzAL g+GoWFooZNEiU97SFZvxOs0WM6p8yeOlqJbQyrQob+sDGenKrUDsmXrpu5iNZUroh4yWswQq4 QVc/q5L/shtFIRUMhswEriu0AWhs4aatohg8weoRZ3bwa297UPTtaP9LTtosC776msr1trt X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_064633_856528_5C7D0617 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 23, 2021 at 3:28 PM Alexandre Torgue wrote: > > This series enhance the STM32 MPU family by adding STM32MP13 SoCs support. > It adds machine support and device tree diversity to support the whole > stm32mp13 family (STM32MP131/STM32MP133/STM32MP135, plus security feature > diversity). > > Basically STM32MP13 SoCs embeds one Cortex A7, storage (SD/MMC/SDIO, QSPI FMC), > network (ETH, CAN), display (DCMIPP, LTDC, ...), audio(SAI, DFSDM, SPDIFRX), > com (USB EHCI/OHCI, USB OTG, I2C, SPI/I2S, U(S)ART). > > This series also adds STM32MP135F Discovery board support (stm32mp135f-dk). It > embeds a STM32MP135f SOC with 512 MB of DDR3. Several connections are available > on this board: > - 4*USB2.0, 1*USB2.0 typeC DRD, SDcard, 2*RJ45, HDMI, Combo Wifi/BT, ... > > Only SD card, uart4 (console) and watchdog IPs are enabled in this commit. > > Note that file stm32mp135.dtsi doesn't define nodes but I add it now to ease adding > of new nodes in a (close) future. I had a brief look and it seems all fine to me, nice work! The only (very minor) thing I noticed is that the crypto engine device node has an unusual name 'cryp@' instead of the usual 'crypto@', but this is already the case on stm32mp157. With this changed, Acked-by: Arnd Bergmann