From: Arnd Bergmann <arnd@arndb.de>
To: Sylvain Lemieux <slemieux.tyco@gmail.com>
Cc: Sylvain Lemieux <slemieux@tycoint.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Vladimir Zapolskiy <vz@mleia.com>
Subject: Re: [PATCH] ARM: defconfig: lpc32xx: enable lpc32xx GPIO driver
Date: Fri, 9 Aug 2019 16:22:26 +0200 [thread overview]
Message-ID: <CAK8P3a2U5LepCk14j2vp+K7caed0zfrKF-k-KOrECMv1SgDJpQ@mail.gmail.com> (raw)
In-Reply-To: <6913a446-9500-c1cd-a8d6-70eb143fdda0@gmail.com>
On Thu, Aug 8, 2019 at 6:19 PM Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
> On 8/8/19 11:06 AM, Arnd Bergmann wrote:
> > On Wed, Aug 7, 2019 at 4:06 PM Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
> >>
> >> From: Sylvain Lemieux <slemieux@tycoint.com>
> >>
> >> The change that allow the multiplatform build for the lpc32xx
> >> platform add a new kernel config for the LPC32XX GPIO driver.
> >>
> >> Cc: Arnd Bergmann <arnd@arndb.de>
> >> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> >> ---
> >> Note:
> >> * This patch depend on the following patchset:
> >> ARM: move lpc32xx and dove to multiplatform
> >> https://www.spinics.net/lists/linux-usb/msg183095.html
> >
> > I did not think this was needed, as I added
> >
> > config GPIO_LPC32XX
> > tristate "NXP LPC32XX GPIO support"
> > default ARCH_LPC32XX
> > depends on OF_GPIO && (ARCH_LPC32XX || COMPILE_TEST)
> >
> > so when running 'make lpc32xx_defconfig', I expected the
> > driver to already be enabled. Did I miss something?
> >
> The GPIO driver is enable. This change is optional.
>
> I added this new config to the default LPC32xx defconfig
> to keep in sync with what is done for the other LPC32xx drivers.
>
> All the LPC32xx drivers config option are listed in the defconfig.
Ok, I just removed the 'default ARCH_LPC32XX' now, and added your
line to the gpio driver patch. That way it behaves like all other
lpc32xx drivers and the defconfig line won't disappear after one
runs 'make savedefconfig'.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-09 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 14:04 [PATCH] ARM: defconfig: lpc32xx: enable lpc32xx GPIO driver Sylvain Lemieux
2019-08-08 15:06 ` Arnd Bergmann
2019-08-08 16:19 ` Sylvain Lemieux
2019-08-09 14:22 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2U5LepCk14j2vp+K7caed0zfrKF-k-KOrECMv1SgDJpQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=slemieux.tyco@gmail.com \
--cc=slemieux@tycoint.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).