[PATCH] ARM: defconfig: lpc32xx: enable lpc32xx GPIO driver

[PATCH] ARM: defconfig: lpc32xx: enable lpc32xx GPIO driver

[Sylvain Lemieux]

From: Sylvain Lemieux <slemieux@tycoint.com>

The change that allow the multiplatform build for the lpc32xx
platform add a new kernel config for the LPC32XX GPIO driver.

Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
---
Note:
* This patch depend on the following patchset:
  ARM: move lpc32xx and dove to multiplatform
  https://www.spinics.net/lists/linux-usb/msg183095.html

 arch/arm/configs/lpc32xx_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/lpc32xx_defconfig b/arch/arm/configs/lpc32xx_defconfig
index 2d75bd8..09deb57 100644
--- a/arch/arm/configs/lpc32xx_defconfig
+++ b/arch/arm/configs/lpc32xx_defconfig
@@ -94,6 +94,7 @@ CONFIG_SERIAL_HS_LPC32XX_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
 CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_PNX=y
+CONFIG_GPIO_LPC32XX=y
 CONFIG_SPI=y
 CONFIG_SPI_PL022=y
 CONFIG_GPIO_SYSFS=y
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: defconfig: lpc32xx: enable lpc32xx GPIO driver

[Arnd Bergmann]

On Wed, Aug 7, 2019 at 4:06 PM Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
>
> From: Sylvain Lemieux <slemieux@tycoint.com>
>
> The change that allow the multiplatform build for the lpc32xx
> platform add a new kernel config for the LPC32XX GPIO driver.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---
> Note:
> * This patch depend on the following patchset:
>   ARM: move lpc32xx and dove to multiplatform
>   https://www.spinics.net/lists/linux-usb/msg183095.html

I did not think this was needed, as I added

config GPIO_LPC32XX
        tristate "NXP LPC32XX GPIO support"
        default ARCH_LPC32XX
        depends on OF_GPIO && (ARCH_LPC32XX || COMPILE_TEST)

so when running 'make lpc32xx_defconfig', I expected the
driver to already be enabled. Did I miss something?

         Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: defconfig: lpc32xx: enable lpc32xx GPIO driver

[Sylvain Lemieux]

On 8/8/19 11:06 AM, Arnd Bergmann wrote:
> On Wed, Aug 7, 2019 at 4:06 PM Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
>>
>> From: Sylvain Lemieux <slemieux@tycoint.com>
>>
>> The change that allow the multiplatform build for the lpc32xx
>> platform add a new kernel config for the LPC32XX GPIO driver.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
>> ---
>> Note:
>> * This patch depend on the following patchset:
>>    ARM: move lpc32xx and dove to multiplatform
>>    https://www.spinics.net/lists/linux-usb/msg183095.html
> 
> I did not think this was needed, as I added
> 
> config GPIO_LPC32XX
>          tristate "NXP LPC32XX GPIO support"
>          default ARCH_LPC32XX
>          depends on OF_GPIO && (ARCH_LPC32XX || COMPILE_TEST)
> 
> so when running 'make lpc32xx_defconfig', I expected the
> driver to already be enabled. Did I miss something?
> 
The GPIO driver is enable. This change is optional.

I added this new config to the default LPC32xx defconfig
to keep in sync with what is done for the other LPC32xx drivers.

All the LPC32xx drivers config option are listed in the defconfig.

>           Arnd
> 

Sylvain

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: defconfig: lpc32xx: enable lpc32xx GPIO driver

[Arnd Bergmann]

On Thu, Aug 8, 2019 at 6:19 PM Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
> On 8/8/19 11:06 AM, Arnd Bergmann wrote:
> > On Wed, Aug 7, 2019 at 4:06 PM Sylvain Lemieux <slemieux.tyco@gmail.com> wrote:
> >>
> >> From: Sylvain Lemieux <slemieux@tycoint.com>
> >>
> >> The change that allow the multiplatform build for the lpc32xx
> >> platform add a new kernel config for the LPC32XX GPIO driver.
> >>
> >> Cc: Arnd Bergmann <arnd@arndb.de>
> >> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> >> ---
> >> Note:
> >> * This patch depend on the following patchset:
> >>    ARM: move lpc32xx and dove to multiplatform
> >>    https://www.spinics.net/lists/linux-usb/msg183095.html
> >
> > I did not think this was needed, as I added
> >
> > config GPIO_LPC32XX
> >          tristate "NXP LPC32XX GPIO support"
> >          default ARCH_LPC32XX
> >          depends on OF_GPIO && (ARCH_LPC32XX || COMPILE_TEST)
> >
> > so when running 'make lpc32xx_defconfig', I expected the
> > driver to already be enabled. Did I miss something?
> >
> The GPIO driver is enable. This change is optional.
>
> I added this new config to the default LPC32xx defconfig
> to keep in sync with what is done for the other LPC32xx drivers.
>
> All the LPC32xx drivers config option are listed in the defconfig.

Ok, I just removed the 'default ARCH_LPC32XX' now, and added your
line to the gpio driver patch. That way it behaves like all other
lpc32xx drivers and the defconfig line won't disappear after one
runs 'make savedefconfig'.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel