linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error
Date: Fri, 9 Jun 2017 20:55:26 +0200	[thread overview]
Message-ID: <CAK8P3a2dp-phi1vZQhq_97vP7-on=mF6i7wdL3H5kf82aoR4VQ@mail.gmail.com> (raw)
In-Reply-To: <20170609114416.6ru5emtqmbubgmzd@piout.net>

On Fri, Jun 9, 2017 at 1:44 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Hi,
>
> On 09/06/2017 at 12:18:02 +0200, Arnd Bergmann wrote:
>> When CONFIG_ARCH_AT91 is enabled, but none of the specific SoC support
>> is in use, some at91 specific drivers fail to link:
>>
>> drivers/tty/serial/atmel_serial.o: In function `atmel_serial_suspend':
>> atmel_serial.c:(.text.atmel_serial_suspend+0x1e): undefined reference to `at91_suspend_entering_slow_clock'
>> drivers/usb/host/ohci-at91.o: In function `ohci_hcd_at91_drv_suspend':
>> ohci-at91.c:(.text.ohci_hcd_at91_drv_suspend+0x12): undefined reference to `at91_suspend_entering_slow_clock'
>> drivers/usb/gadget/udc/at91_udc.o: In function `at91udc_suspend':
>> at91_udc.c:(.text.at91udc_suspend+0x26): undefined reference to `at91_suspend_entering_slow_clock'
>>
>
> How you present it makes me think, that this was present for a while,
> even before samv7 support was added. Am I wrong?

I only ran into the problem after samv7 support was added. Before that,
pm.o was always built-in when CONFIG_AT91 was set, even when none
of the specific platforms got enabled.

       Arnd

  reply	other threads:[~2017-06-09 18:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 10:18 [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error Arnd Bergmann
2017-06-09 11:44 ` Alexandre Belloni
2017-06-09 18:55   ` Arnd Bergmann [this message]
2017-06-13  9:52 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a2dp-phi1vZQhq_97vP7-on=mF6i7wdL3H5kf82aoR4VQ@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).