From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E48B2C04AB6 for ; Fri, 31 May 2019 21:12:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B890D26F2F for ; Fri, 31 May 2019 21:12:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SZDjbVwF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B890D26F2F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KPzIlZ/LwpZHNoxqRsqIYkIc/InOxgAu/vR8OfKozE8=; b=SZDjbVwF0He4HC CRi0q8f+vUeWSk9bpBA2ybiCdZSVw+fY7ex+F0LTAXJAowScoJ0y6pEFz5Wjmj7axBUealVONUvvu KB8YV/EgvQotPOlLo27smvAw2EHnIYg/maJ57IASrkVabJLpLJYI/pFjMHJxIHMFIPezv8gDQ5KLh 1QNi6ldVFO9AUOPc9HvmI6c4SU4HKchoXKd6C+Odjl9DOCm//er1OjZtMReosanC1BDVHp3tVperG aDc3ojh+k6prQPvqFoVfx7NJXcBuf+nK5gKLMtTG2o7Kg0YJd2arDt64b07HdDtOVH73jjbwrVtHs dJsdNjW/MDBCviXr2++Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWopN-0005D0-Qi; Fri, 31 May 2019 21:12:41 +0000 Received: from mail-qt1-f196.google.com ([209.85.160.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWopK-0005Cc-7Y for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 21:12:39 +0000 Received: by mail-qt1-f196.google.com with SMTP id t1so2593217qtc.12 for ; Fri, 31 May 2019 14:12:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AZptDCZbtMb0PQHhtVnS/aF9UysKMAzgtneB0+7FC+I=; b=hQne2Cr1l6J+pxat17eiicF7kmwor1mcX+M8FTuUy6k0Ii0NJmB1olDGH94UKOb/4Z YLVujdlcb089fDRuh97rANwR97W1BTNdEuBtO7LjWbjmKbR0BSH1csZQEIXAyuEqC6Ej YDPdRWOYWq/OTcVfh39tfS5iAYrOFiVKkp2Ry4UGkrGv2N6kyl4xBb5fmf5CeNwbMu6W FGmeGJKfZn4DuoGIJpXppZ0pv120Q4vbGR8WVieBPmKUBxEyWKDQ03Yzx5iST19hMLQZ zM3NiXgyvUxyexeb4l3cpFHjjG/EeTJ5xG/8CFEUbPUTHRCyqNmCJ+TC9yGbpH81muRl kx4Q== X-Gm-Message-State: APjAAAUuwHLBGxeTlnJykKzEb9ghcBlfJZ7vpNVZu3+c5n4pn313P1CK J00CzVwIFEsYDsBEsbEpYd5DxLv6wOxMsk+WVg4= X-Google-Smtp-Source: APXvYqzHvUnfa6x/YLh/Fjn3Tw3E+yBquiW3NroCyGZFdVC85oGAnHKEDZucf7nAm9xpQNUD3gkU2OGRWDNqkRg6xhY= X-Received: by 2002:aed:3e7c:: with SMTP id m57mr6159988qtf.204.1559337157081; Fri, 31 May 2019 14:12:37 -0700 (PDT) MIME-Version: 1.0 References: <20190531035348.7194-1-elder@linaro.org> <065c95a8-7b17-495d-f225-36c46faccdd7@linaro.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 31 May 2019 23:12:20 +0200 Message-ID: Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver To: Alex Elder X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_141238_273418_89CD93BF X-CRM114-Status: GOOD ( 27.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , syadagir@codeaurora.org, Eric Caruso , Dan Williams , Networking , Ilias Apalodimas , Linux Kernel Mailing List , evgreen@chromium.org, Bjorn Andersson , abhishek.esse@gmail.com, Linux ARM , linux-arm-msm@vger.kernel.org, Subash Abhinov Kasiviswanathan , linux-soc@vger.kernel.org, David Miller , cpratapa@codeaurora.org, Ben Chan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 10:47 PM Alex Elder wrote: > On 5/31/19 2:19 PM, Arnd Bergmann wrote: > > On Fri, May 31, 2019 at 6:36 PM Alex Elder wrote: > >> On 5/31/19 9:58 AM, Dan Williams wrote: > >>> On Thu, 2019-05-30 at 22:53 -0500, Alex Elder wrote: > > > > Does this mean that IPA can only be used to back rmnet, and rmnet > > can only be used on top of IPA, or can or both of them be combined > > with another driver to talk to instead? > > No it does not mean that. > > As I understand it, one reason for the rmnet layer was to abstract > the back end, which would allow using a modem, or using something > else (a LAN?), without exposing certain details of the hardware. > (Perhaps to support multiplexing, etc. without duplicating that > logic in two "back-end" drivers?) > > To be perfectly honest, at first I thought having IPA use rmnet > was a cargo cult thing like Dan suggested, because I didn't see > the benefit. I now see why one would use that pass-through layer > to handle the QMAP features. > > But back to your question. The other thing is that I see no > reason the IPA couldn't present a "normal" (non QMAP) interface > for a modem. It's something I'd really like to be able to do, > but I can't do it without having the modem firmware change its > configuration for these endpoints. My access to the people who > implement the modem firmware has been very limited (something > I hope to improve), and unless and until I can get corresponding > changes on the modem side to implement connections that don't > use QMAP, I can't implement such a thing. Why would that require firmware changes? What I was thinking here is to turn the bits of the rmnet driver that actually do anything interesting on the headers into a library module (or a header file with inline functions) that can be called directly by the ipa driver, keeping the protocol unchanged. > > Always passing data from one netdev to another both ways > > sounds like it introduces both direct CPU overhead, and > > problems with flow control when data gets buffered inbetween. > > My impression is the rmnet driver is a pretty thin layer, > so the CPU overhead is probably not that great (though > deaggregating a message is expensive). I agree with you > on the flow control. The CPU overhead I mean is not from executing code in the rmnet driver, but from passing packets through the network stack between the two drivers, i.e. adding each frame to a queue and taking it back out. I'm not sure how this ends up working in reality but from a first look it seems like we might bounce in an out of the softirq handler inbetween. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel