From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24869C10F11 for ; Wed, 24 Apr 2019 07:29:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8A142089F for ; Wed, 24 Apr 2019 07:29:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OTb7REZv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8A142089F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ohRqZvMOXSvhE9SOzLrktWta8blhOA0347StgB02waw=; b=OTb7REZv8+lTqz VEa+pu95E1F7KsQHNKg1nLupcU6cPIUAUCZA5aA55WHFQSyYtemLGq9a4dQaa0D+dxzNL3P8ZMGb0 qvd87lVKuL90lqu4JtIIuVAKffRuYsSW8uuIsCHFVBK2UMm+hAcTvdk3Xcg+G3j2oIyI4gux8GbsW wiS05G8b//obX6ZbO7Jp/QM/6HgH5PgrLyn/L/7g/huEuKYE9u/FMKk+zVDlWgL5G7vIxB9h27oLi CnQhVC8E88u9Gve6m4VEMBQh1hQG1YEsnTjmm7Qr5UN2K5B3BgGcvTFL7vWHd0AQIQC5vF4ZbSkcu kNGYR/BmErXsj9hFcDRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJCLf-0002sn-Nk; Wed, 24 Apr 2019 07:29:43 +0000 Received: from mail-qk1-f194.google.com ([209.85.222.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJCLc-0002sR-LE for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2019 07:29:42 +0000 Received: by mail-qk1-f194.google.com with SMTP id w20so10234187qka.7 for ; Wed, 24 Apr 2019 00:29:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XapeRkWY7o+spNjWmUQhyJBsoa0At4KGBTfzOOUiPIM=; b=QcShdFPpfSid37nMm4YsBeBNWjt/vXKvVqwHzujCEf9KHP/8Z0g7qzM9IvQzhK3RvL CR6Md1/5Rjw2F7jlngtcrrCIIleqHVNdHYWbmcv96zIdW8ej4T3nZkGF734oqxir32nd AzeEBQGyAMxQUeoVGbDDyXdzznwbOa/0Hz5XHupElmTypBG4jA9tD3wK9t4rG2UzyBmM SgIpCpj74frim5Po54y5qbEjy9EybQ7SkCBW8k6eYuOtgPeM8ujrhCAnyKDPOBpfoghX VIWBdkVT3vvxXua61s0YuGzohMKq7L/2Ba7q7cMWbMWPJlJ3ZIXgFOsEPCyJcQR1cyXg uc3A== X-Gm-Message-State: APjAAAUoZyJpwBLHLp6kxuGPS7RktqGFoo0ggvz/Jx0M4I5vboCNxxxF orUQLh+6RIA8LWH2J+SQ9m6ynqh7nrMIBPjzBB0= X-Google-Smtp-Source: APXvYqxPbcbpVM+mifN64GX7ZgCSQPjx3aIInu6c5ALadps2VDQnd6V3ly/9e8mSBxY1VO0pxRUkQSBFCUxgq3Gy2qw= X-Received: by 2002:a37:49ce:: with SMTP id w197mr15032839qka.330.1556090979380; Wed, 24 Apr 2019 00:29:39 -0700 (PDT) MIME-Version: 1.0 References: <20181210223133.22667-1-ndesaulniers@google.com> In-Reply-To: <20181210223133.22667-1-ndesaulniers@google.com> From: Arnd Bergmann Date: Wed, 24 Apr 2019 09:29:23 +0200 Message-ID: Subject: Re: [PATCH] ARM: VDSO: Drop implicit common-page-size linker flag To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_002940_698283_17CFA248 X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nathan Lynch , Russell King - ARM Linux , Linux Kernel Mailing List , Dmitry Vyukov , Andrew Morton , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 10, 2018 at 11:32 PM wrote: > > GNU linker's -z common-page-size's default value is based on the target > architecture. arch/arm/vdso/Makefile sets it to the architecture > default, which is implicit and redundant. Drop it. > > Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com > Signed-off-by: Nick Desaulniers > --- The patch looks good to me, Acked-by: Arnd Bergmann Adding Nathan Lynch to Cc though for further comments, he originally added the Makefile flags here and might still remember why he did it. Unless Nathan objects, please add the patch to Russell's patch tracker. > diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile > index f4efff9d3afb..8f2fac5acbc8 100644 > --- a/arch/arm/vdso/Makefile > +++ b/arch/arm/vdso/Makefile > @@ -11,7 +11,7 @@ ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector > ccflags-y += -DDISABLE_BRANCH_PROFILING > > VDSO_LDFLAGS := -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 > -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > +VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 > VDSO_LDFLAGS += -nostdlib -shared > VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id) > -- > 2.20.0.rc2.403.gdbc3b29805-goog > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel