From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4B6C433ED for ; Sat, 8 May 2021 11:40:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3785061264 for ; Sat, 8 May 2021 11:40:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3785061264 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1qsL5KIm5d/cc78/HHxGyaFF6X1mcv674AOt+4yvFg8=; b=pAPwMTCFAJA+V/iW38UQ/oJQy nlGzPG7XVQM0CKbmQXhZB3q48aUxm0lSlEZyfomhp6kR+JhuDOfQhJq7QQLHUn/yqnzUKr7qznMQn pU2AbgoxT7PhrZMedMT2NqBHTz59jfkamLLgGOHWVWuwBEA7mIB0uYtOb/GEtzuYGK7peoY18h4Bn CQMztccB18eBSRqxGyIIIQ665L/DN+wL+cjPaz+eT0aUgUsW/iUkGkeFzH6QFB29jRxgNaINTwkQT wTtOZRRjkj54Qap/OPZtDtvh+GD0DCBuyYl6SkSqQgyr3fU2581uCkZqx48r7+EzPswPrLIyU8vfI EXI6bom0g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfLIU-009R3Y-0J; Sat, 08 May 2021 11:39:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfLIQ-009R3J-7n for linux-arm-kernel@desiato.infradead.org; Sat, 08 May 2021 11:38:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VXt42xA4oM7UzwpzoNFnlTBRJUFyLtiOAGJAJ71QwPU=; b=4aZgk47N2dKqK+HgdYNHfmH5q/ dghVb4Q+oV9fWs8F1NTtiEdwNc8JLDfkJ5KkzJPqGcjdSMsVTdWictHFX2cjxO0/9YHqhm52Ud1Ho fZlZTWqSLzmIiGR2cOwkomIgsgppENKerFVUdztlx/yPL1I/eCqku1kaigp2FwHR+6zBSY4ALuPdJ UERyxVXQ9unDGKtjncSG3lkc2g86PCLEWEDUzkb9ET7B1Djd4oIDUvpLOuGlU3LpEHsADah24j85A FCVP8IvAc4IcZKiJojPJ/kiEnKYOBeZkcELlPqpYJ2AtYER9K+E/askdiLuVm3Gs4BA0QZxCmdhdj Nf6QtmFg==; Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfLIN-007Vib-AZ for linux-arm-kernel@lists.infradead.org; Sat, 08 May 2021 11:38:57 +0000 Received: from mail-wr1-f42.google.com ([209.85.221.42]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M2wXK-1lgRDq3JSG-003LLg for ; Sat, 08 May 2021 13:38:50 +0200 Received: by mail-wr1-f42.google.com with SMTP id d11so11788949wrw.8 for ; Sat, 08 May 2021 04:38:50 -0700 (PDT) X-Gm-Message-State: AOAM531qKKtyGwqV+ft+1YH9cYDa7QY6RRzEo+/DNK5KIUU6prmkHuio 1oji13c3dvmvexQTJJD2ajg6BcX3X1dR9YdsD6c= X-Google-Smtp-Source: ABdhPJz9Ugr0PcKykwE/hh6B427vWc6utZRdX8QIU/0Cr6kUxmxhdoRfUEI4Usf4M2X1Uz94Uu4T5nd0trDb5rVyhQE= X-Received: by 2002:a5d:4452:: with SMTP id x18mr19275744wrr.286.1620473930435; Sat, 08 May 2021 04:38:50 -0700 (PDT) MIME-Version: 1.0 References: <20210507220813.365382-1-arnd@kernel.org> <20210507220813.365382-7-arnd@kernel.org> In-Reply-To: <20210507220813.365382-7-arnd@kernel.org> From: Arnd Bergmann Date: Sat, 8 May 2021 13:38:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 06/12] asm-generic: unaligned: remove byteshift helpers To: linux-arch Cc: Linus Torvalds , Vineet Gupta , Russell King , Nathan Chancellor , Nick Desaulniers , Linux ARM , Linux Kernel Mailing List , clang-built-linux X-Provags-ID: V03:K1:iYEyRTnIOTXAGlhanxUBVzdYdkHsu0TrWY4eZXzmuNGQ4Vn02Zl l05dy+0pk+X8kQDlb0XgfNMute07xoaB1AGiPJtfxSwRT35ZoY5HrvmeSfYL+csjEHnF6eO TOCyz9mV+vI8Vi52HXdOjProJ3B4zZNumgxF4PZ/TQ2FUCMqZBLgycz4yzdoOdPa6X1vPZu Q0TCxF/72ciSpiwXFdkrg== X-UI-Out-Filterresults: notjunk:1;V03:K0:6UMQwtvrbSU=:/PSsKoVKhjIU1GX11qNzaf 3U1+F6XYS/aULC+SkS/dhwzT+CsHA0EjdDpij4WOtT+1HTeZojlUrh3NieCa1N87Omb4K8EcU mhj0+/PUnkJKW0ItPcEKgA33jwYEqaYtcPTA1LvXco3HKCTa3is0/gKoLaKxQFyGKzntUGaND PoSlkXyAz2aIbcnP12HdI1OMTb/LwwrDYTS+PbSg+HOsaOuJjWZVgU/0oKgGwuRNI7BJTBG/j cIA3tl+rudW6qziNaGgd5upDR6DpVDfjTKAiOzDB9j7jWA60lWitQjfGD8XgBQygfcRTr2IIY A7mlAT0QI6sJcQZH++pjMe7+IqQ9OLKNFG4JeiB/WS+TKqaMs//lSbI/K8M+t0B3rNWc4LK47 0uL8ae5bWl8p1h7eAXva19ZYhBxhPoSk6u1Gc3MzJLy8gxxDQxOOajTTK+aSPmWMJx6hPU6ww oV0P2+I6ogfQpCbDxiaimfzcsN2ocV5e2HkFdrd/YyoMx56fEKHqCX/iDGs6igdMg+x3I/g1k uDc/qLoGlN4yPM9sGXV3H3ZaOV16U3gSKhUQT3LePITlT7e8e7IWLF6+ev1hV6uw5DHrEMF+x PdGumzdPe2uOM4JidRZ/qf/ihUODfzNgSkpeo9wrT46QkP/8OEqL9OpKa5DNQPdzgXFJ5WN39 w0GE= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210508_043855_675424_F24EC98D X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 8, 2021 at 12:11 AM Arnd Bergmann wrote: > > Suggested-by: Linus Torvalds > Signed-off-by: Arnd Bergmann > --- > I've included this patch in the series because Linus asked about > removing the byteshift version, but after trying it out, I'd > prefer to drop this and use the byteshift version for the > generic code as well. Update: I've tried to create a small test case that illustrates the problem with using the swab() based version, however all cases combinations I tried showed either both producing identical output, or the shift version being worse, see https://godbolt.org/z/bTdsjnjfT I'll rewrite the patch description accordingly and leave this in place. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel