linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sachin.kamat@linaro.org (Sachin Kamat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: fix to support for missing cpu specific map_io
Date: Tue, 30 Jul 2013 10:08:26 +0530	[thread overview]
Message-ID: <CAK9yfHwMANp2TfQWHQVXGZ2C-t-KrwGHJOpFT+hedDFYTDng6Q@mail.gmail.com> (raw)
In-Reply-To: <190501ce8cdd$2abd6780$80383680$%kim@samsung.com>

On 30 July 2013 09:57, Kukjin Kim <kgene.kim@samsung.com> wrote:
>
> Since commit 7ed76e08 (ARM: EXYNOS: Fix low level debug support)
> map_io() is not needed for exynos5440 so need to fix to lookup
> cpu which using map_io(). Without this, kernel boot log complains
> 'CPU EXYNOS5440 support not enabled' on exynos5440 and panic().
>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
>  arch/arm/plat-samsung/init.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/init.c b/arch/arm/plat-samsung/init.c
> index 3e5c461..50a3ea0 100644
> --- a/arch/arm/plat-samsung/init.c
> +++ b/arch/arm/plat-samsung/init.c
> @@ -55,12 +55,13 @@ void __init s3c_init_cpu(unsigned long idcode,
>
>         printk("CPU %s (id 0x%08lx)\n", cpu->name, idcode);
>
> -       if (cpu->map_io == NULL || cpu->init == NULL) {
> +       if (cpu->init == NULL) {
>                 printk(KERN_ERR "CPU %s support not enabled\n", cpu->name);
>                 panic("Unsupported Samsung CPU");

While at it you could probably remove the printk and have that message
printed by panic instead?

-- 
With warm regards,
Sachin

  reply	other threads:[~2013-07-30  4:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30  4:27 [PATCH] ARM: SAMSUNG: fix to support for missing cpu specific map_io Kukjin Kim
2013-07-30  4:38 ` Sachin Kamat [this message]
2013-07-31  5:44   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK9yfHwMANp2TfQWHQVXGZ2C-t-KrwGHJOpFT+hedDFYTDng6Q@mail.gmail.com \
    --to=sachin.kamat@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).