* [PATCH] ARM: SAMSUNG: fix to support for missing cpu specific map_io
@ 2013-07-30 4:27 Kukjin Kim
2013-07-30 4:38 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2013-07-30 4:27 UTC (permalink / raw)
To: linux-arm-kernel
Since commit 7ed76e08 (ARM: EXYNOS: Fix low level debug support)
map_io() is not needed for exynos5440 so need to fix to lookup
cpu which using map_io(). Without this, kernel boot log complains
'CPU EXYNOS5440 support not enabled' on exynos5440 and panic().
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
arch/arm/plat-samsung/init.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-samsung/init.c b/arch/arm/plat-samsung/init.c
index 3e5c461..50a3ea0 100644
--- a/arch/arm/plat-samsung/init.c
+++ b/arch/arm/plat-samsung/init.c
@@ -55,12 +55,13 @@ void __init s3c_init_cpu(unsigned long idcode,
printk("CPU %s (id 0x%08lx)\n", cpu->name, idcode);
- if (cpu->map_io == NULL || cpu->init == NULL) {
+ if (cpu->init == NULL) {
printk(KERN_ERR "CPU %s support not enabled\n", cpu->name);
panic("Unsupported Samsung CPU");
}
- cpu->map_io();
+ if (cpu->map_io)
+ cpu->map_io();
}
/* s3c24xx_init_clocks
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: SAMSUNG: fix to support for missing cpu specific map_io
2013-07-30 4:27 [PATCH] ARM: SAMSUNG: fix to support for missing cpu specific map_io Kukjin Kim
@ 2013-07-30 4:38 ` Sachin Kamat
2013-07-31 5:44 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-07-30 4:38 UTC (permalink / raw)
To: linux-arm-kernel
On 30 July 2013 09:57, Kukjin Kim <kgene.kim@samsung.com> wrote:
>
> Since commit 7ed76e08 (ARM: EXYNOS: Fix low level debug support)
> map_io() is not needed for exynos5440 so need to fix to lookup
> cpu which using map_io(). Without this, kernel boot log complains
> 'CPU EXYNOS5440 support not enabled' on exynos5440 and panic().
>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/plat-samsung/init.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/init.c b/arch/arm/plat-samsung/init.c
> index 3e5c461..50a3ea0 100644
> --- a/arch/arm/plat-samsung/init.c
> +++ b/arch/arm/plat-samsung/init.c
> @@ -55,12 +55,13 @@ void __init s3c_init_cpu(unsigned long idcode,
>
> printk("CPU %s (id 0x%08lx)\n", cpu->name, idcode);
>
> - if (cpu->map_io == NULL || cpu->init == NULL) {
> + if (cpu->init == NULL) {
> printk(KERN_ERR "CPU %s support not enabled\n", cpu->name);
> panic("Unsupported Samsung CPU");
While at it you could probably remove the printk and have that message
printed by panic instead?
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: SAMSUNG: fix to support for missing cpu specific map_io
2013-07-30 4:38 ` Sachin Kamat
@ 2013-07-31 5:44 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2013-07-31 5:44 UTC (permalink / raw)
To: linux-arm-kernel
Sachin Kamat wrote:
>
> On 30 July 2013 09:57, Kukjin Kim <kgene.kim@samsung.com> wrote:
> >
> > Since commit 7ed76e08 (ARM: EXYNOS: Fix low level debug support)
> > map_io() is not needed for exynos5440 so need to fix to lookup
> > cpu which using map_io(). Without this, kernel boot log complains
> > 'CPU EXYNOS5440 support not enabled' on exynos5440 and panic().
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > arch/arm/plat-samsung/init.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/plat-samsung/init.c b/arch/arm/plat-samsung/init.c
> > index 3e5c461..50a3ea0 100644
> > --- a/arch/arm/plat-samsung/init.c
> > +++ b/arch/arm/plat-samsung/init.c
> > @@ -55,12 +55,13 @@ void __init s3c_init_cpu(unsigned long idcode,
> >
> > printk("CPU %s (id 0x%08lx)\n", cpu->name, idcode);
> >
> > - if (cpu->map_io == NULL || cpu->init == NULL) {
> > + if (cpu->init == NULL) {
> > printk(KERN_ERR "CPU %s support not enabled\n",
cpu->name);
> > panic("Unsupported Samsung CPU");
>
> While at it you could probably remove the printk and have that message
> printed by panic instead?
>
If required, it should be handled separately, and it is not critical.
- Kukjin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-31 5:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-30 4:27 [PATCH] ARM: SAMSUNG: fix to support for missing cpu specific map_io Kukjin Kim
2013-07-30 4:38 ` Sachin Kamat
2013-07-31 5:44 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).