From: sachin.kamat@linaro.org (Sachin Kamat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/12] ARM: EXYNOS: Make exynos machine_ops as static
Date: Wed, 30 Apr 2014 11:30:59 +0530 [thread overview]
Message-ID: <CAK9yfHxfkegFzzJCz4nAkxrHT6FGT0OQ-5RkCdTA3ruo2kU8CA@mail.gmail.com> (raw)
In-Reply-To: <1398835057-3860-2-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
On 30 April 2014 10:47, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> As machine function ops are used only in this file let's make
> them static.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/exynos.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index 3d69e8d..06dcce5 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -198,7 +198,7 @@ static struct map_desc exynos5_iodesc[] __initdata = {
> },
> };
>
> -void exynos_restart(enum reboot_mode mode, const char *cmd)
> +static void exynos_restart(enum reboot_mode mode, const char *cmd)
> {
> struct device_node *np;
> u32 val = 0x1;
> @@ -239,7 +239,7 @@ void __init exynos_cpufreq_init(void)
> platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
> }
>
> -void __init exynos_init_late(void)
> +static void __init exynos_init_late(void)
> {
> if (of_machine_is_compatible("samsung,exynos5440"))
> /* to be supported later */
> @@ -300,7 +300,7 @@ static void __init exynos_map_io(void)
> iotable_init(exynos5250_iodesc, ARRAY_SIZE(exynos5250_iodesc));
> }
>
> -void __init exynos_init_io(void)
> +static void __init exynos_init_io(void)
> {
> debug_ll_io_init();
The declarations from common.h should also be removed in this patch to
avoid the below
build errors:
arch/arm/mach-exynos/exynos.c:198:13: error: static declaration of
?exynos_restart? follows non-static declaration
static void exynos_restart(enum reboot_mode mode, const char *cmd)
^
In file included from arch/arm/mach-exynos/exynos.c:31:0:
arch/arm/mach-exynos/common.h:22:6: note: previous declaration of
?exynos_restart? was here
void exynos_restart(enum reboot_mode mode, const char *cmd);
^
arch/arm/mach-exynos/exynos.c:235:20: error: static declaration of
?exynos_init_late? follows non-static declaration
static void __init exynos_init_late(void)
^
In file included from arch/arm/mach-exynos/exynos.c:31:0:
arch/arm/mach-exynos/common.h:25:6: note: previous declaration of
?exynos_init_late? was here
void exynos_init_late(void);
^
arch/arm/mach-exynos/exynos.c:296:20: error: static declaration of
?exynos_init_io? follows non-static declaration
static void __init exynos_init_io(void)
^
In file included from arch/arm/mach-exynos/exynos.c:31:0:
arch/arm/mach-exynos/common.h:21:6: note: previous declaration of
?exynos_init_io? was here
void exynos_init_io(void);
--
With warm regards,
Sachin
next prev parent reply other threads:[~2014-04-30 6:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 5:17 [PATCH v3 00/12] ARM: Exynos: PMU cleanup and refactoring for using DT Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 01/12] ARM: EXYNOS: Make exynos machine_ops as static Pankaj Dubey
2014-04-30 6:00 ` Sachin Kamat [this message]
2014-04-30 7:35 ` Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 02/12] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 03/12] ARM: EXYNOS: Cleanup "mach-exynos/common.h" file Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 04/12] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 05/12] ARM: EXYNOS: Remove file path from comment section Pankaj Dubey
2014-04-30 8:41 ` Sachin Kamat
2014-04-30 5:17 ` [PATCH v3 06/12] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 07/12] ARM: EXYNOS: Add support for mapping PMU base address via DT Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 08/12] ARM: EXYNOS: Remove "linux/bug.h" from pmu.c Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 09/12] ARM: EXYNOS: Refactored code for using PMU address via DT Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 10/12] ARM: EXYNOS: Move "mach/map.h" inclusion from regs-pmu.h to platsmp.c Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 11/12] ARM: EXYNOS: Add platform driver support for Exynos PMU Pankaj Dubey
2014-04-30 6:05 ` Vikas Sajjan
2014-05-01 3:58 ` Pankaj Dubey
2014-04-30 5:17 ` [PATCH v3 12/12] ARM: EXYNOS: Move PMU specific definitions from common.h Pankaj Dubey
2014-05-03 1:52 ` [PATCH v3 00/12] ARM: Exynos: PMU cleanup and refactoring for using DT Pankaj Dubey
2014-05-03 2:14 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK9yfHxfkegFzzJCz4nAkxrHT6FGT0OQ-5RkCdTA3ruo2kU8CA@mail.gmail.com \
--to=sachin.kamat@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).