linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matt@genesi-usa.com (Matt Sealey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] efikamx: reintroduce Genesi Efika MX Smarttop via device tree
Date: Mon, 13 Aug 2012 10:42:58 -0500	[thread overview]
Message-ID: <CAKGA1bkwMvDW7nMWxUbNm3_0ZTR2+uKs8UL_HuisJe7cd8POBA@mail.gmail.com> (raw)
In-Reply-To: <20120809101947.GA8474@sirena.org.uk>

On Thu, Aug 9, 2012 at 5:19 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Aug 07, 2012 at 04:46:18PM -0500, Matt Sealey wrote:
>
> Yay for indentation!  It'd be good to rewrite your DT so you could cut
> down on that, at the minute it's not good for legibility.
>
>> +                                                     sw1_reg: sw1 {
>> +                                                             regulator-min-microvolt = <600000>;
>> +                                                             regulator-max-microvolt = <1375000>;
>> +                                                             regulator-boot-on;
>> +                                                             regulator-always-on;
>> +                                                     };
>
> This and many of your other regulators have voltage ranges specified but
> no consumers which doesn't make sense.  It looks awfully like you've
> just typed in the maximum range supported by the regulator which is most
> likely broken.

Okay I have a question about this; some of the regulators (SW1
especially) are obviously consumed by the CPU core complex so that
when DVFS gives us a hint we can clock down and reduce voltage. How on
earth do we implement that?

We can drop the maximum range to be better for the CPU (1.3V is too
high, I think this is legacy from when we may have had a sorted 1GHz
MX51 coming out) but I can't find any source for where this is hooked
in.

-- 
Matt Sealey <matt@genesi-usa.com>
Product Development Analyst, Genesi USA, Inc.

  parent reply	other threads:[~2012-08-13 15:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 21:46 [PATCH] efikamx: reintroduce Genesi Efika MX Smarttop via device tree Matt Sealey
2012-08-08 15:15 ` Shawn Guo
2012-08-08 16:55   ` Matt Sealey
2012-08-08 17:19     ` Fabio Estevam
2012-08-09 14:29       ` Matt Sealey
2012-08-10  1:41         ` Shawn Guo
2012-08-10 13:36           ` Matt Sealey
2012-08-10 14:04             ` Shawn Guo
2012-08-10 14:26               ` Matt Sealey
2012-08-10 14:40                 ` Shawn Guo
2012-08-10 14:42                 ` Matt Sealey
2012-08-09 10:19 ` Mark Brown
2012-08-09 13:40   ` Matt Sealey
2012-08-09 14:17     ` Mark Brown
2012-08-13 15:42   ` Matt Sealey [this message]
2012-08-13 17:38     ` Mark Brown
2012-08-13 22:05       ` Matt Sealey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKGA1bkwMvDW7nMWxUbNm3_0ZTR2+uKs8UL_HuisJe7cd8POBA@mail.gmail.com \
    --to=matt@genesi-usa.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).