From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57A49C2BB3F for ; Wed, 15 Nov 2023 15:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8kh3rb+V6DZPtoPEe5wpNii/odgMWPcC1bg4lSCSjW0=; b=VQKOLL3JYhthmB fAFNZPbVV3T/Yi4e2kgnbkCGeHiaRiZctFwNc4XT0QajrT0rCaodaVXi+nMMpTHkAkJwUDhWChNwf 0XElgct46y9De4tFG9GHgLUf4IT17ypPQTBZPX5k9+aHCY2aTcDkzDGNkkuKuMfmAvjSyKAENifiZ B775luKQy2kzccKIFD+zSNYfS8JunhBL2ObU1hz1GXS7INa4WQJ8FeG/njdms7SShx6xbLzdQnJWj iVtN/oiJvtOWeT9AbqA1MqeffqyrUJWOQAxrpFfYa0b4g5j2eTProQZ7q1BxbDrQoSWMc9Nk8krJY fJwaWzZ6thWgBf5nkuwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3Hcd-0019VD-1u; Wed, 15 Nov 2023 15:16:07 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3HcZ-0019TF-2S for linux-arm-kernel@lists.infradead.org; Wed, 15 Nov 2023 15:16:05 +0000 Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-41cb7720579so285451cf.1 for ; Wed, 15 Nov 2023 07:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700061362; x=1700666162; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j/NfrA/AhI3IBeh3+JaRNZ83ErlUjI5ivLDH7Qt1YZA=; b=yNQb4PjU+se4PYfstwflD7g/cbv+bUB9SrJY7sX1eduSTu8G9b3n7qB9ZS32ZBvLbN 4pBtJ8Pu/W720ciZuHQoJZLa1Unco4b0I/5v3tO3Yo30kyNO8x89PKelmaHKdgEfOilw twBT5S6v+rshVEunlJz/r/BKqhJQsmJBWVKo8zp5e3j3/a4JV6iut5xOzDxgQFST4ojJ KQdV/Jpq2W88m9gPDybgDQh4y3WHMOvXIfa2Qo0cEpScTlIA6bgqvXA3x9P49+692koC nP/4qaocprTHKgCodUCNdEm/zARTQVs3e4akK+41+wrOtxtXvPmZ0kzN49ix9MGbhs0E VEig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700061362; x=1700666162; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j/NfrA/AhI3IBeh3+JaRNZ83ErlUjI5ivLDH7Qt1YZA=; b=XeZCDYlqNVWY1FEz8pFco4iTLU9Xr9NSzBxKLVPpe79BRlZcIBlbpZaKQ9JvemC0A3 +cD65LjsI18FKC00T9HHX5CSd3HQot3oeJDOkwxyTzSnn/6qFG5ECJTScb5m4iBn+KKq FEZAUVzju+vltv8oOjOIgk6ZMDwUAzMnPyHlGw+PUq9g3SBmAMWUb9eA3X61Aav5WiR9 syP4BAjUzOFl3WUZK7cRxBcVykROIixma0BYR9Xq7wWhxHdc1fsqWDu5ENp9FEbuszR5 EHusm7IUXmYBBQFe5DAsa4/M3+T9PcABe2/qMyXm2C15GKy+BqCsgloU8peRpPZiONfY wUVg== X-Gm-Message-State: AOJu0YzQi6NSRFt5LJvUIkJ71X6PHn0XW6JCO+KduYDCh0W1dZuPfHWT x7wUN1hCIi1CyxOtEWXc8V0GBNL8bImOlGYzy8o2zw== X-Google-Smtp-Source: AGHT+IHsLkfd1mxk7ecbuNweGdtB1UIAK1+qdYZ92dNVDoJ/1Sup4inheYKgSuDVVFZQROqhBwKMmpHYkE8Z3XuTeTY= X-Received: by 2002:ac8:520b:0:b0:41e:3c2f:13cb with SMTP id r11-20020ac8520b000000b0041e3c2f13cbmr205910qtn.19.1700061361403; Wed, 15 Nov 2023 07:16:01 -0800 (PST) MIME-Version: 1.0 References: <0-v2-de8b10590bf5+400-smmuv3_newapi_p1_jgg@nvidia.com> <11-v2-de8b10590bf5+400-smmuv3_newapi_p1_jgg@nvidia.com> In-Reply-To: <11-v2-de8b10590bf5+400-smmuv3_newapi_p1_jgg@nvidia.com> From: Michael Shavit Date: Wed, 15 Nov 2023 23:15:23 +0800 Message-ID: Subject: Re: [PATCH v2 11/19] iommu/arm-smmu-v3: Do not change the STE twice during arm_smmu_attach_dev() To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Nicolin Chen , Shameerali Kolothum Thodi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231115_071603_798707_313B471C X-CRM114-Status: GOOD ( 32.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMTQsIDIwMjMgYXQgMTo1M+KAr0FNIEphc29uIEd1bnRob3JwZSA8amdnQG52 aWRpYS5jb20+IHdyb3RlOgo+Cj4gVGhpcyB3YXMgbmVlZGVkIGJlY2F1c2UgdGhlIFNURSBjb2Rl IHJlcXVpcmVkIHRoZSBTVEUgdG8gYmUgaW4KPiBBQk9SVC9CWVBBU1MgaW5vcmRlciB0byBwcm9n cmFtIGEgY2R0YWJsZSBvciBTMiBTVEUuIE5vdyB0aGF0IHRoZSBTVEUgY29kZQo+IGNhbiBhdXRv bWF0aWNhbGx5IGhhbmRsZSBhbGwgdHJhbnNpdGlvbnMgd2UgY2FuIHJlbW92ZSB0aGlzIHN0ZXAK PiBmcm9tIHRoZSBhdHRhY2hfZGV2IGZsb3cuCj4KPiBBIGZldyBzbWFsbCBidWdzIGV4aXN0IGJl Y2F1c2Ugb2YgdGhpczoKPgo+IDEpIElmIHRoZSBjb3JlIGNvZGUgZG9lcyBCTE9DS0VEIC0+IFVO TUFOQUdFRCB3aXRoIGRpc2FibGVfYnlwYXNzPWZhbHNlCj4gICAgdGhlbiB0aGVyZSB3aWxsIGJl IGEgbW9tZW50IHdoZXJlIHRoZSBTVEUgcG9pbnRzIGF0IEJZUEFTUy4gU2luY2UKPiAgICB0aGlz IGNhbiBiZSBkb25lIGJ5IFZGSU8vSU9NTVVGRCBpdCBpcyBhIHNtYWxsIHNlY3VyaXR5IHJhY2Uu Cj4KPiAyKSBJZiB0aGUgY29yZSBjb2RlIGRvZXMgSURFTlRJVFkgLT4gRE1BIHRoZW4gYW55IElP TU1VX1JFU1ZfRElSRUNUCj4gICAgcmVnaW9ucyB3aWxsIHRlbXBvcmFyaWx5IGJlY29tZSBCTE9D S0VELiBXZSdkIGxpa2UgZHJpdmVycyB0bwo+ICAgIHdvcmsgaW4gYSB3YXkgdGhhdCBhbGxvd3Mg SU9NTVVfUkVTVl9ESVJFQ1QgdG8gYmUgY29udGludW91c2x5Cj4gICAgZnVuY3Rpb25hbCBkdXJp bmcgdGhlc2UgdHJhbnNpdGlvbnMuCj4KPiBNYWtlIGFybV9zbW11X3JlbGVhc2VfZGV2aWNlKCkg cHV0IHRoZSBTVEUgYmFjayB0byB0aGUgY29ycmVjdAo+IEFCT1JUL0JZUEFTUyBzZXR0aW5nLiBG aXggYSBidWcgd2hlcmUgYSBJT01NVV9SRVNWX0RJUkVDVCB3YXMgaWdub3JlZCBvbgo+IHRoaXMg cGF0aC4KPgo+IE5vdGljZSB0aGlzIHN1YnRseSBkZXBlbmRzIG9uIHRoZSBwcmlvciBhcm1fc21t dV9hc2lkX2xvY2sgY2hhbmdlIGFzIHRoZQo+IFNURSBtdXN0IGJlIHB1dCB0byBub24tcGFnaW5n IGJlZm9yZSByZW1vdmluZyB0aGUgZGV2aWNlIGZvciB0aGUgbGlua2VkCj4gbGlzdCB0byBhdm9p ZCByYWNlcyB3aXRoIGFybV9zbW11X3NoYXJlX2FzaWQoKS4KCkknbSBhIGxpdHRsZSBjb25mdXNl ZCBieSB0aGlzIGNvbW1lbnQuIElzIHRoaXMgc3VnZ2VzdGluZyB0aGF0CmFybV9zbW11X2RldGFj aF9kZXYgaGFkIGEgcmFjZSBjb25kaXRpb24gYmVmb3JlIHRoZSBhcm1fc21tdV9hc2lkX2xvY2sK Y2hhbmdlcywgc2luY2UgaXQgZGVsZXRlcyB0aGUgbGlzdCBlbnRyeSBiZWZvcmUgZGVhY3RpdmF0 aW5nIHRoZSBTVEUKdGhhdCB1c2VzIHRoZSBkb21haW4gYW5kIHdpdGhvdXQgZ3JhYmJpbmcgdGhl IGFzaWRfbG9jaywgdGh1cyBhbGxvd2luZwphIGdhcCB3aGVyZSB0aGUgQVNJRCBtaWdodCBiZSBy ZS1hY3F1aXJlZCBieSBhbiBTVkEgZG9tYWluIHdoaWxlIGFuClNURSB3aXRoIHRoYXQgQVNJRCBp cyBzdGlsbCBsaXZlIG9uIHRoaXMgZGV2aWNlPyBXb3VsZG4ndCB0aGF0IGJlbG9uZwpvbiB0aGUg YXNpZF9sb2NrIHBhdGNoIGluc3RlYWQgaWYgc28/Cgo+Cj4gU2lnbmVkLW9mZi1ieTogSmFzb24g R3VudGhvcnBlIDxqZ2dAbnZpZGlhLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9pb21tdS9hcm0vYXJt LXNtbXUtdjMvYXJtLXNtbXUtdjMuYyB8IDE1ICsrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgOSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMgYi9kcml2ZXJzL2lvbW11 L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4gaW5kZXggNGIxNTdjMmRkZjlhODAuLmY3 MDg2MjgwNjIxMWRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYz L2FybS1zbW11LXYzLmMKPiArKysgYi9kcml2ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9hcm0t c21tdS12My5jCj4gQEAgLTI0ODIsNyArMjQ4Miw2IEBAIHN0YXRpYyB2b2lkIGFybV9zbW11X2Rp c2FibGVfcGFzaWQoc3RydWN0IGFybV9zbW11X21hc3RlciAqbWFzdGVyKQo+ICBzdGF0aWMgdm9p ZCBhcm1fc21tdV9kZXRhY2hfZGV2KHN0cnVjdCBhcm1fc21tdV9tYXN0ZXIgKm1hc3RlcikKPiAg ewo+ICAgICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPiAtICAgICAgIHN0cnVjdCBhcm1fc21t dV9zdGUgdGFyZ2V0Owo+ICAgICAgICAgc3RydWN0IGFybV9zbW11X2RvbWFpbiAqc21tdV9kb21h aW4gPSBtYXN0ZXItPmRvbWFpbjsKPgo+ICAgICAgICAgaWYgKCFzbW11X2RvbWFpbikKPiBAQCAt MjQ5NiwxMSArMjQ5NSw2IEBAIHN0YXRpYyB2b2lkIGFybV9zbW11X2RldGFjaF9kZXYoc3RydWN0 IGFybV9zbW11X21hc3RlciAqbWFzdGVyKQo+Cj4gICAgICAgICBtYXN0ZXItPmRvbWFpbiA9IE5V TEw7Cj4gICAgICAgICBtYXN0ZXItPmF0c19lbmFibGVkID0gZmFsc2U7Cj4gLSAgICAgICBpZiAo ZGlzYWJsZV9ieXBhc3MpCj4gLSAgICAgICAgICAgICAgIGFybV9zbW11X21ha2VfYWJvcnRfc3Rl KCZ0YXJnZXQpOwo+IC0gICAgICAgZWxzZQo+IC0gICAgICAgICAgICAgICBhcm1fc21tdV9tYWtl X2J5cGFzc19zdGUoJnRhcmdldCk7Cj4gLSAgICAgICBhcm1fc21tdV9pbnN0YWxsX3N0ZV9mb3Jf ZGV2KG1hc3RlciwgJnRhcmdldCk7Cj4gICAgICAgICAvKgo+ICAgICAgICAgICogQ2xlYXJpbmcg dGhlIENEIGVudHJ5IGlzbid0IHN0cmljdGx5IHJlcXVpcmVkIHRvIGRldGFjaCB0aGUgZG9tYWlu Cj4gICAgICAgICAgKiBzaW5jZSB0aGUgdGFibGUgaXMgdW5pbnN0YWxsZWQgYW55d2F5LCBidXQg aXQgaGVscHMgYXZvaWQgY29uZnVzaW9uCj4gQEAgLTI4NTIsOSArMjg0NiwxOCBAQCBzdGF0aWMg c3RydWN0IGlvbW11X2RldmljZSAqYXJtX3NtbXVfcHJvYmVfZGV2aWNlKHN0cnVjdCBkZXZpY2Ug KmRldikKPiAgc3RhdGljIHZvaWQgYXJtX3NtbXVfcmVsZWFzZV9kZXZpY2Uoc3RydWN0IGRldmlj ZSAqZGV2KQo+ICB7Cj4gICAgICAgICBzdHJ1Y3QgYXJtX3NtbXVfbWFzdGVyICptYXN0ZXIgPSBk ZXZfaW9tbXVfcHJpdl9nZXQoZGV2KTsKPiArICAgICAgIHN0cnVjdCBhcm1fc21tdV9zdGUgdGFy Z2V0Owo+Cj4gICAgICAgICBpZiAoV0FSTl9PTihhcm1fc21tdV9tYXN0ZXJfc3ZhX2VuYWJsZWQo bWFzdGVyKSkpCj4gICAgICAgICAgICAgICAgIGlvcGZfcXVldWVfcmVtb3ZlX2RldmljZShtYXN0 ZXItPnNtbXUtPmV2dHEuaW9wZiwgZGV2KTsKPiArCj4gKyAgICAgICAvKiBQdXQgdGhlIFNURSBi YWNrIHRvIHdoYXQgYXJtX3NtbXVfaW5pdF9zdHJ0YWIoKSBzZXRzICovCgpIbW1tbSwgaXQgc2Vl bXMgbGlrZSBjaGVja2luZyBpb21tdS0+cmVxdWlyZV9kaXJlY3QgbWF5IHB1dCBTVEVzIGluCmJ5 cGFzcyBpbiBzY2VuYXJpb3Mgd2hlcmUgYXJtX3NtbXVfaW5pdF9zdHJ0YWIoKSB3b3VsZG4ndCBo YXZlLgphcm1fc21tdV9pbml0X3N0cnRhYiBpcyBjYWxsaW5nIGlvcnRfZ2V0X3Jtcl9zaWRzIHRv IHBpY2sgc3RyZWFtcyB0bwpwdXQgaW50byBieXBhc3MsIGJ1dCBJSVVDIGlvbW11LT5yZXF1aXJl X2RpcmVjdCBhbHNvIGFwcGxpZXMgdG8KZHRzLWJhc2VkIHJlc2VydmVkLW1lbW9yeSByZWdpb25z LCBub3QganVzdCBpb3J0LgoKSSdtIG5vdCB2ZXJ5IGZhbWlsaWFyIHdpdGggdGhlIGhpc3Rvcnkg YmVoaW5kIGRpc2FibGVfYnlwYXNzOyB3aHkgaXMKcHV0dGluZyBhbiBlbnRpcmUgc3RyZWFtIGlu dG8gYnlwYXNzIHRoZSBjb3JyZWN0IGJlaGF2aW9yIGlmIGEKcmVzZXJ2ZWQtbWVtb3J5ICh3aGlj aCBtYXkgYmUgZm9yIGEgc21hbGwgZmluaXRlIHJlZ2lvbikgZXhpc3RzPwoKPiArICAgICAgIGlm IChkaXNhYmxlX2J5cGFzcyAmJiAhZGV2LT5pb21tdS0+cmVxdWlyZV9kaXJlY3QpCj4gKyAgICAg ICAgICAgICAgIGFybV9zbW11X21ha2VfYWJvcnRfc3RlKCZ0YXJnZXQpOwo+ICsgICAgICAgZWxz ZQo+ICsgICAgICAgICAgICAgICBhcm1fc21tdV9tYWtlX2J5cGFzc19zdGUoJnRhcmdldCk7Cj4g KyAgICAgICBhcm1fc21tdV9pbnN0YWxsX3N0ZV9mb3JfZGV2KG1hc3RlciwgJnRhcmdldCk7Cj4g Kwo+ICAgICAgICAgYXJtX3NtbXVfZGV0YWNoX2RldihtYXN0ZXIpOwo+ICAgICAgICAgYXJtX3Nt bXVfZGlzYWJsZV9wYXNpZChtYXN0ZXIpOwo+ICAgICAgICAgYXJtX3NtbXVfcmVtb3ZlX21hc3Rl cihtYXN0ZXIpOwo+IC0tCj4gMi40Mi4wCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK