From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AA91C4708D for ; Fri, 6 Jan 2023 12:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4EaYUYyexRFj+i01Ca38vKiNFVg/kDJvy6rwo5bFZVw=; b=G/KAffaq7RAW3C zFmUqQCVjHWUjhunUHPxB+megjFuocudGPeKQnbOAjdADh+OPNVV98F+GMDqw60B07Q0zpi5bvm2R 1JU1hfPNYi23hSMlezmDF3sPzy7uioLRPK7gypfxrkuTGD2KRaZXfbsaM5WhFFOqpBrUqQpQMnOk8 uzqzQZAxAbnKNEHlf4SIec/0EcThcVQnCOx5bAwaJPrzIeAMCdy+oBCtpckIIEpnC31o0/UXO2+sm 4B992pG9i1kzSWq+wy3j6E/bzQ3DavRCkeBPPH3kcCkd9q3vTDcn5qHXkk8jHhyPLGftp4nYGCZ4e RF8dDMWdKR/EQBrzPIdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDm6C-0089tD-GH; Fri, 06 Jan 2023 12:45:28 +0000 Received: from mail-vs1-xe2a.google.com ([2607:f8b0:4864:20::e2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDm69-0089oy-KC for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 12:45:27 +0000 Received: by mail-vs1-xe2a.google.com with SMTP id p30so1352238vsr.1 for ; Fri, 06 Jan 2023 04:45:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jL6yKbuIG5bg58/evB7hjRBzcxcNlKUiVEr9ODI7ufw=; b=TkItBn/CS4JazJCi5yzrFkv4FFdOD+vEwo92+R3UjHUPhT79HVut13Xw6h2RdP/ktJ HDEyslFM9HktYRF/ZTJqaJE3OtTmB/H5I/L2FRbZEWQ/87WoULShnlX7Xt9IIBFH9XBk TuWfM7Zum6RmJOQLUTqEDpiheoFzB1V7tpRPysMlJk/PDii1+ByLczX7zBljYjs8tiPQ vf0yapYm2fivghkpWaJLXvgDiImzKzz6bPWOD/yIfuFa/hyhpzTiG5dbK0DZsF+LJJQB /Dj9xpH4ruQNObqHHKVd5lD8+yTt/afcy3jJ7vc7mnkJxy3JG5XkCqzYMvW0A6TltuPp 3Bng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jL6yKbuIG5bg58/evB7hjRBzcxcNlKUiVEr9ODI7ufw=; b=Fz+XuNYh3EuunQE09LGTifuUax56pdQWJ+YTGfQ1H2LUOILC9Idrkn2CM6YyXqmz1j 7+fM6cSW26WhimDm+fbWGy+E8lus+MYIZD4dpFzExMBGWGO9HJOw6ZpaebZ7XjrYXw0X NC1ZT/qrIagMCIOY+QHJSAHJtaSSRV7gQs55Mg0te/PXUpmUaWGp7FwmdeSEsNHif96j OQpPa3HvaGYgKjGkjy4HVOABv5NkaK8FbSggjDNiICQb0TPmDkp/6pvCx6uERkQ8CZw1 GvI4213SF0SMP/qrQTLZrsJkjJvGYxnfnb2HAz4s/4vYtZ0m3mYHMqVTBWQ1fQ/ygCvO HKUQ== X-Gm-Message-State: AFqh2koKrOqc/l/IisCTl8EF/A+MMZ1mTqvMZ/UDrDMwRAh64I7ibmwz kBxahzZ4Qirx1KvoS/yXb54d9q//+zobwDqhXTI= X-Google-Smtp-Source: AMrXdXvYT2C0w2+sD74BfOfSicY9vAuLMtmsc92pY36FpG7KMWfK0oehgZvbwnJzvhULP62lifut0FGhYqxS7x3FbK4= X-Received: by 2002:a05:6102:510e:b0:3b1:2b83:1861 with SMTP id bm14-20020a056102510e00b003b12b831861mr6419257vsb.10.1673009117334; Fri, 06 Jan 2023 04:45:17 -0800 (PST) MIME-Version: 1.0 References: <20221220112927.440506-1-alistair@alistair23.me> <20221220112927.440506-2-alistair@alistair23.me> <20221220132033.s5idqrol5kqxjasy@pengutronix.de> <7a2dfaab-5340-236a-064d-15db3e00f409@pengutronix.de> In-Reply-To: <7a2dfaab-5340-236a-064d-15db3e00f409@pengutronix.de> From: Alistair Francis Date: Fri, 6 Jan 2023 22:44:50 +1000 Message-ID: Subject: Re: [PATCH v2 1/3] ARM: dts: imx7d-remarkable2: Enable the cyttsp5 To: Ahmad Fatoum Cc: Marco Felsch , Alistair Francis , devicetree@vger.kernel.org, kernel@pengutronix.de, arnd@arndb.de, festevam@gmail.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, jernej.skrabec@gmail.com, linux@armlinux.org.uk, robh+dt@kernel.org, linux-imx@nxp.com, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_044525_687000_BDA746E0 X-CRM114-Status: GOOD ( 27.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 21, 2022 at 2:51 AM Ahmad Fatoum wrote: > > Hello Alistair, > Hello Marco, > > On 20.12.22 14:20, Marco Felsch wrote: > > Hi Alistair, > > > > thanks for your patch, please see below. > > > > On 22-12-20, Alistair Francis wrote: > >> Add support for the cyttsp5 touchscreen controller for the reMarkable 2. > >> > >> Signed-off-by: Alistair Francis > >> --- > >> arch/arm/boot/dts/imx7d-remarkable2.dts | 98 +++++++++++++++++++++++++ > >> 1 file changed, 98 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > >> index 8b2f11e85e05..a138b292ec6a 100644 > >> --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > >> +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > >> @@ -8,6 +8,7 @@ > >> /dts-v1/; > >> > >> #include "imx7d.dtsi" > >> +#include > >> > >> / { > >> model = "reMarkable 2.0"; > >> @@ -69,6 +70,18 @@ reg_digitizer: regulator-digitizer { > >> startup-delay-us = <100000>; /* 100 ms */ > >> }; > >> > >> + reg_touch: regulator-touch { > >> + compatible = "regulator-fixed"; > >> + regulator-name = "VDD_3V3_TOUCH"; > >> + regulator-min-microvolt = <3300000>; > >> + regulator-max-microvolt = <3300000>; > >> + pinctrl-names = "default", "sleep"; > >> + pinctrl-0 = <&pinctrl_touch_reg>; > >> + pinctrl-1 = <&pinctrl_touch_reg>; > > > > Why do we need a "sleep" state here? Removed > > > >> + gpio = <&gpio1 11 GPIO_ACTIVE_HIGH>; > >> + enable-active-high; > >> + }; > >> + > >> wifi_pwrseq: wifi_pwrseq { > >> compatible = "mmc-pwrseq-simple"; > >> pinctrl-names = "default"; > >> @@ -106,6 +119,68 @@ wacom_digitizer: digitizer@9 { > >> }; > >> }; > >> > >> +&i2c3 { > >> + clock-frequency = <100000>; > > > > This can be set to 400kHz, the driver handle the quirks internal. > > I would either leave this at 100kHz or increase to the maximum of > 384 kHz. DT is supposed to describe the hardware and if 400 kHz > isn't a safe frequency, it should be avoided, even if the Linux > driver handles it gracefully. I'm going to leave this at 100kHz then. Let me know if you want me to bump it to 384kHz instead. Alistair > > Cheers, > Ahmad > > > > > Regards, > > Marco > > > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_i2c3>; > >> + status = "okay"; > >> + > >> + touchscreen@24 { > >> + compatible = "cypress,tt21000"; > >> + reg = <0x24>; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_touch>; > >> + interrupt-parent = <&gpio1>; > >> + interrupts = <14 IRQ_TYPE_EDGE_FALLING>; > >> + reset-gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > >> + vdd-supply = <®_touch>; > >> + touchscreen-size-x = <880>; > >> + touchscreen-size-y = <1280>; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + button@0 { > >> + reg = <0>; > >> + linux,keycodes = ; > >> + }; > >> + > >> + button@1 { > >> + reg = <1>; > >> + linux,keycodes = ; > >> + }; > >> + > >> + button@2 { > >> + reg = <2>; > >> + linux,keycodes = ; > >> + }; > >> + > >> + button@3 { > >> + reg = <3>; > >> + linux,keycodes = ; > >> + }; > >> + > >> + button@4 { > >> + reg = <4>; > >> + linux,keycodes = ; > >> + }; > >> + > >> + button@5 { > >> + reg = <5>; > >> + linux,keycodes = ; > >> + }; > >> + > >> + button@6 { > >> + reg = <6>; > >> + linux,keycodes = ; > >> + }; > >> + > >> + button@7 { > >> + reg = <7>; > >> + linux,keycodes = ; > >> + }; > >> + }; > >> +}; > >> + > >> &i2c4 { > >> clock-frequency = <100000>; > >> pinctrl-names = "default", "sleep"; > >> @@ -232,6 +307,15 @@ MX7D_PAD_ENET1_RGMII_TXC__GPIO7_IO11 0x00000014 > >> >; > >> }; > >> > >> + pinctrl_touch: touchgrp { > >> + fsl,pins = < > >> + /* CYTTSP interrupt */ > >> + MX7D_PAD_GPIO1_IO14__GPIO1_IO14 0x54 > >> + /* CYTTSP reset */ > >> + MX7D_PAD_GPIO1_IO13__GPIO1_IO13 0x04 > >> + >; > >> + }; > >> + > >> pinctrl_i2c1: i2c1grp { > >> fsl,pins = < > >> MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f > >> @@ -239,6 +323,13 @@ MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f > >> >; > >> }; > >> > >> + pinctrl_i2c3: i2c3grp { > >> + fsl,pins = < > >> + MX7D_PAD_I2C3_SDA__I2C3_SDA 0x4000007f > >> + MX7D_PAD_I2C3_SCL__I2C3_SCL 0x4000007f > >> + >; > >> + }; > >> + > >> pinctrl_i2c4: i2c4grp { > >> fsl,pins = < > >> MX7D_PAD_I2C4_SDA__I2C4_SDA 0x4000007f > >> @@ -246,6 +337,13 @@ MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f > >> >; > >> }; > >> > >> + pinctrl_touch_reg: touchreggrp { > >> + fsl,pins = < > >> + /* TOUCH_PWR_EN */ > >> + MX7D_PAD_GPIO1_IO11__GPIO1_IO11 0x14 > >> + >; > >> + }; > >> + > >> pinctrl_uart1: uart1grp { > >> fsl,pins = < > >> MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > >> -- > >> 2.38.1 > >> > >> > >> > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel