From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller
Date: Tue, 3 Apr 2018 20:05:53 +0200 [thread overview]
Message-ID: <CAKv+Gu9cqQqq_etTSvdBp4Jjk5O_0FePe74phDqt5EO6Cm-_vQ@mail.gmail.com> (raw)
In-Reply-To: <20180403150139.l7oec4doafmsidfp@ninjato>
On 3 April 2018 at 17:01, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> - switch to generic recovery using minimal helpers to drive the SDA/SCL lines
>> directly
>
> If you had added this incrementally, reviewing would have been easier (=
> faster). The callbacks look okay...
>
>> - don't recover on every error
>
> ... but you are now never recovering. You don't call i2c_recover_bus().
>
Yeah, good point. So when exactly should this be called? Only on error
conditions that could be caused by a misbehaving slave?
>> - add patch to sanity check i2c_transfer() arguments in core code (#3)
>
> See small comment there.
>
next prev parent reply other threads:[~2018-04-03 18:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 11:07 [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-03-25 11:07 ` [PATCH v6 1/3] dt-bindings: i2c: add binding for Socionext SynQuacer I2C Ard Biesheuvel
2018-04-04 18:33 ` Wolfram Sang
2018-04-04 18:34 ` Wolfram Sang
2018-03-25 11:07 ` [PATCH v6 2/3] i2c: add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-04-04 18:34 ` Wolfram Sang
2018-04-04 18:35 ` Wolfram Sang
2018-03-25 11:07 ` [PATCH v6 3/3] i2c: add param sanity check to i2c_transfer() Ard Biesheuvel
2018-04-03 15:03 ` Wolfram Sang
2018-04-03 16:56 ` Ard Biesheuvel
2018-03-30 14:13 ` [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-04-03 15:01 ` Wolfram Sang
2018-04-03 18:05 ` Ard Biesheuvel [this message]
2018-04-03 18:12 ` Wolfram Sang
2018-04-03 18:14 ` Ard Biesheuvel
2018-04-03 18:32 ` Wolfram Sang
2018-04-03 18:35 ` Ard Biesheuvel
2018-04-03 18:45 ` Wolfram Sang
2018-04-03 18:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9cqQqq_etTSvdBp4Jjk5O_0FePe74phDqt5EO6Cm-_vQ@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).