From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E724AC433E0 for ; Wed, 24 Jun 2020 21:11:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B173020768 for ; Wed, 24 Jun 2020 21:11:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cPAy6rKJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ulgAO6ky" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B173020768 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HXZHuE5Bopt+IrRgssrMqBJJc4dUFeH0zz1QHRhXb8g=; b=cPAy6rKJkfcPUgQwIJez3Xp7v KSOgEI86cjGC/snVuXjSZJhbAYGNvOc9OFMO0MCA7SOvzRURgvtpKMWNCz0UtlgazHuBiD060zmjg X6HpdXODmkPIrVhAs7DaKznojFJ82M5UBOeCx4hw36mTlfDxrgDxS7/O2uCQ4P/dchq0VbVTpCcVb pYxWVJmaz6g5OrNW7wSiBcO319gOoni1/xN3f9oqC7u+TezKkR6+lUNtn1PYVy200YMqvNcgR1bKh 6T0OeBBrrWcG7u1vIhu9UkSiW4QZl4WHNGSz5pYYIesOWz0t0LFaJCImrNEPgKLWwxS6rmpZTnKGU wKKYCWskg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCed-0000Kd-I6; Wed, 24 Jun 2020 21:09:59 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCeY-0000Dv-TB for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 21:09:55 +0000 Received: by mail-pf1-x441.google.com with SMTP id d66so1796785pfd.6 for ; Wed, 24 Jun 2020 14:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i2jIkhYgexjs9KkwlPySDcA/4RhGGwlAKSrpoMnhGmk=; b=ulgAO6kyxk2umRKRWH6nMJnay5+JI9S+MN+66ac15rcJgmGZtAYk+H5+fPCQqHCN4n YwMVU0XBQEhTdVY5OHD749qpd8Pozz/SM+1Buf2jPE/xGsC+B8G3MYh7c8rCA848s7mL 3wpkBMp2MTJmyiCiTEBPNG6vBbmHu+xghA1mKpCcjOJyJnqEFuFwGJ/pFH0IcAb5JQC+ A2lLOE//kF+ciANNdx3Etcs1w4HXCok/pytM4pC9m2UbLu8T+ZNQiWPiX0fGAsI8+xBJ v8AHa7fV3npUoZ0xdjzOFVVo0SV0pKjAQOJojHM+9coxAbL/MqHPcTuHuRnLuuT3AK8g iPTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i2jIkhYgexjs9KkwlPySDcA/4RhGGwlAKSrpoMnhGmk=; b=hW9iUBPHOhkK/w19todCTV9z2eOImnQh2MQwk9U04omoe2+3dGhUQHy5e8SZZgTOD1 C0T3LyfxjcZslC5u1Y7MTZAwtjRIowKNI0fZKvTza5JpE2R6xbSrm8Qyj3GEo7WMgZAU 8P+A9FL91thJwS6gp9sGWra5Ik/2EUrh3Sw+sD97/4guOxRGLw6wgl4GlkZ66/ECraDJ 7WlhNnGhpt/crdhjLT0rIRMKTK/AsxOXOtRwFlGM8/pQxVwpgs9HfkTu4w22wwo4QHQ1 Bhp/6gbPaxRIVfA+dLBQ5Yv8EAKZNckudDPy03jxDF0zadtawU51NszxwFZzn5hTSrzb TAJw== X-Gm-Message-State: AOAM532wOdNV2njj6TbR5nPkp8Zkx0FtHKGYKmENF6HYIfwhWlEJJmhh ekqWdbw83icIyHXVpn38h8dCK9wDDF95nDQxSCK/5Q== X-Google-Smtp-Source: ABdhPJyx7J+Crf2HbQKcuBNOiCwJq3seEefhf6EE+jeFP724rCfUEgtaO9Vi1jID9/eG3LhJZ3IQ+YfzgYs3IE2HM8s= X-Received: by 2002:a63:5644:: with SMTP id g4mr22699481pgm.381.1593032992558; Wed, 24 Jun 2020 14:09:52 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-18-samitolvanen@google.com> In-Reply-To: From: Nick Desaulniers Date: Wed, 24 Jun 2020 14:09:40 -0700 Message-ID: Subject: Re: [PATCH 17/22] arm64: vdso: disable LTO To: Sami Tolvanen X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Kees Cook , "Paul E. McKenney" , Kernel Hardening , Greg Kroah-Hartman , Masahiro Yamada , Linux Kbuild mailing list , LKML , clang-built-linux , Andi Kleen , linux-pci@vger.kernel.org, Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 1:58 PM Nick Desaulniers wrote: > > On Wed, Jun 24, 2020 at 1:33 PM Sami Tolvanen wrote: > > > > Filter out CC_FLAGS_LTO for the vDSO. > > Just curious about this patch (and the following one for x86's vdso), > do you happen to recall specifically what the issues with the vdso's > are? + Andi (tangential, I actually have a bunch of tabs open with slides from http://halobates.de/ right now) 58edae3aac9f2 67424d5a22124 $ git log -S DISABLE_LTO > > > > > Signed-off-by: Sami Tolvanen > > --- > > arch/arm64/kernel/vdso/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile > > index 556d424c6f52..cfad4c296ca1 100644 > > --- a/arch/arm64/kernel/vdso/Makefile > > +++ b/arch/arm64/kernel/vdso/Makefile > > @@ -29,8 +29,8 @@ ldflags-y := -shared -nostdlib -soname=linux-vdso.so.1 --hash-style=sysv \ > > ccflags-y := -fno-common -fno-builtin -fno-stack-protector -ffixed-x18 > > ccflags-y += -DDISABLE_BRANCH_PROFILING > > > > -CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) > > -KBUILD_CFLAGS += $(DISABLE_LTO) > > +CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) \ > > + $(CC_FLAGS_LTO) > > KASAN_SANITIZE := n > > UBSAN_SANITIZE := n > > OBJECT_FILES_NON_STANDARD := y > > -- -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel