From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie
Date: Thu, 18 Aug 2011 15:46:42 +0400 [thread overview]
Message-ID: <CALT56yPWBNgPONQfTCtN9rZLTWrXx53m3Dk-xx8XshPNwsrnqQ@mail.gmail.com> (raw)
In-Reply-To: <1312715131-3956-1-git-send-email-dbaryshkov@gmail.com>
On Sun, Aug 7, 2011 at 3:05 PM, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
> The pxa2xx_sharpsl driver part is also used on collie, which (as
> a StrongARM board) has different expectations for PCMCIA drivers.
> So, on collie place sharpsl_pcmcia_ops in .data section rather than
> in __initdata.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: stable at kernel.org
Any comments on this patch?
> diff --git a/drivers/pcmcia/pxa2xx_sharpsl.c b/drivers/pcmcia/pxa2xx_sharpsl.c
> index 69ae2fd..f2405dc 100644
> --- a/drivers/pcmcia/pxa2xx_sharpsl.c
> +++ b/drivers/pcmcia/pxa2xx_sharpsl.c
> @@ -219,7 +219,11 @@ static void sharpsl_pcmcia_socket_suspend(struct soc_pcmcia_socket *skt)
> ? ? ? ?sharpsl_pcmcia_init_reset(skt);
> ?}
>
> +#ifdef CONFIG_SA1100_COLLIE
> +static struct pcmcia_low_level sharpsl_pcmcia_ops = {
> +#else
> ?static struct pcmcia_low_level sharpsl_pcmcia_ops __initdata = {
> +#endif
> ? ? ? ?.owner ? ? ? ? ? ? ? ? ?= THIS_MODULE,
> ? ? ? ?.hw_init ? ? ? ? ? ? ? ?= sharpsl_pcmcia_hw_init,
> ? ? ? ?.hw_shutdown ? ? ? ? ? ?= sharpsl_pcmcia_hw_shutdown,
> --
> 1.7.2.5
>
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2011-08-18 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-07 11:05 [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie Dmitry Eremin-Solenikov
2011-08-18 11:46 ` Dmitry Eremin-Solenikov [this message]
2011-08-19 2:19 ` Eric Miao
2011-08-26 20:34 ` Pavel Machek
2011-08-26 20:44 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALT56yPWBNgPONQfTCtN9rZLTWrXx53m3Dk-xx8XshPNwsrnqQ@mail.gmail.com \
--to=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).