From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dt-binding: fix GIC example
Date: Fri, 11 Apr 2014 08:40:00 -0500 [thread overview]
Message-ID: <CAL_JsqKAnqMRM2ipYO4NsgXgZhtdhzEySR6pRVCMoXn3vRff7A@mail.gmail.com> (raw)
In-Reply-To: <1397222629.4577.7.camel@weser.hi.pengutronix.de>
On Fri, Apr 11, 2014 at 8:23 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring:
>> On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
>> > Hi Rob,
>> >
>> > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring:
>> >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
>> >> > From: Tim Harvey <tharvey@gateworks.com>
>> >> >
>> >> > When using interrupt-maps, the size of a map entry is #address-cells +
>> >>
>> >> Plus what? You mean ", and "?
>> >>
>> > Urgh, I obviously messed this up while editing the commit message in the
>> > last minute. It should have been something along the lines of:
>> >
>> > When using interrupt-maps, the size of a map entry is #address-cells +
>> > #interrupt-cells. address-cells should be 0 as this offset is not used
>> > in the GIC.
>> >
>> > As #address-cells = <0> is the same as not specifying the
>> > property, simply remove it.
>> >
>> > Can you edit this while applying, or should I send a new patch?
>>
>> I'll fix it up and apply.
>>
> Thanks.
>
>> >
>> >> > address-cells should be 0 as this is not used.
>> >> >
>> >> > As #address-cells = <0> is the same as not specifying the
>> >> > property, simply remove it.
>> >> >
>> >> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>> >> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>> >>
>> >> Did this get applied? I can't seem to find patch 2.
>> >>
>> > As Shawn pointed out patch 2 got applied through the imx tree as it
>> > fixes a real bug there.
>>
>> It was highlighted that other instances beyond iMX were wrong. Please
>> fix those as well.
>
> Oh, I wasn't aware of that. Will send patches.
It was raised here: http://www.spinics.net/lists/linux-pci/msg29768.html
Here's a somewhat accurate list:
$ git grep -A8 'arm,.*gic' origin/master -- arch/arm/boot/dts | grep
'address.*1'
origin/master:arch/arm/boot/dts/ecx-2000.dts-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/highbank.dts-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/imx6qdl.dtsi- #address-cells = <1>;
origin/master:arch/arm/boot/dts/imx6sl.dtsi- #address-cells = <1>;
origin/master:arch/arm/boot/dts/keystone.dtsi- #address-cells = <1>;
origin/master:arch/arm/boot/dts/r8a7740.dtsi- #address-cells = <1>;
origin/master:arch/arm/boot/dts/sh73a0.dtsi- #address-cells = <1>;
origin/master:arch/arm/boot/dts/socfpga.dtsi- #address-cells = <1>;
origin/master:arch/arm/boot/dts/ste-dbx5x0.dtsi-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/vf610.dtsi-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/zynq-7000.dtsi-
#address-cells = <1>;
Rob
prev parent reply other threads:[~2014-04-11 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 16:25 [PATCH 1/2] ARM: dt-binding: fix GIC example Lucas Stach
2014-03-28 16:25 ` [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties Lucas Stach
2014-04-03 6:47 ` Shawn Guo
2014-04-10 15:21 ` [PATCH 1/2] ARM: dt-binding: fix GIC example Rob Herring
2014-04-11 1:16 ` Shawn Guo
2014-04-11 10:10 ` Lucas Stach
2014-04-11 13:20 ` Rob Herring
2014-04-11 13:23 ` Lucas Stach
2014-04-11 13:40 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKAnqMRM2ipYO4NsgXgZhtdhzEySR6pRVCMoXn3vRff7A@mail.gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).