From: robh+dt@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] 8250: uniphier: allow modular build with 8250 console
Date: Thu, 21 Jan 2016 08:09:13 -0600 [thread overview]
Message-ID: <CAL_JsqKCnxenDN-5OP1yqAyyW1-cuhs47CeosAj12hr89e6CrA@mail.gmail.com> (raw)
In-Reply-To: <4548262.MV5j98YUVi@wuerfel>
On Thu, Jan 21, 2016 at 6:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
>> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>> > The recently added uniphier 8250 port driver supports early console
>> > probing, and it supports being built as a module, but the combination
>> > of the two fails to link:
>> >
>> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>> >
>> > Given that earlycon support in a loadable module makes no sense,
>> > making that code conditional on 'MODULE' is a correct solution.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>> >
>> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
>> > index bab6b3ae2540..1b7bd26555b7 100644
>> > --- a/drivers/tty/serial/8250/8250_uniphier.c
>> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
>> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>> > spinlock_t atomic_write_lock;
>> > };
>> >
>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>> > static int __init uniphier_early_console_setup(struct earlycon_device *device,
>> > const char *options)
>> > {
>> >
>> >
>>
>>
>> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
>> this build error will be fixed as well. But I doubt it is accepted soon...
>>
>> So, I am OK with this workaround to fix "make allmodconfig".
>>
>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>
> Good point. Adding the DT maintainers to Cc. Guys, any chance of you
> picking up Masahiro's patch for 4.5?
I will if you can update the commit log with the details here about it
fixing an actual problem.
Rob
next prev parent reply other threads:[~2016-01-21 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 22:33 [PATCH] 8250: uniphier: allow modular build with 8250 console Arnd Bergmann
2016-01-21 11:39 ` Masahiro Yamada
2016-01-21 12:21 ` Arnd Bergmann
2016-01-21 14:09 ` Rob Herring [this message]
2016-01-21 16:50 ` Masahiro Yamada
2016-01-26 1:48 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKCnxenDN-5OP1yqAyyW1-cuhs47CeosAj12hr89e6CrA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).