* [PATCH] 8250: uniphier: allow modular build with 8250 console
@ 2016-01-13 22:33 Arnd Bergmann
2016-01-21 11:39 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-13 22:33 UTC (permalink / raw)
To: linux-arm-kernel
The recently added uniphier 8250 port driver supports early console
probing, and it supports being built as a module, but the combination
of the two fails to link:
ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
Given that earlycon support in a loadable module makes no sense,
making that code conditional on 'MODULE' is a correct solution.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
index bab6b3ae2540..1b7bd26555b7 100644
--- a/drivers/tty/serial/8250/8250_uniphier.c
+++ b/drivers/tty/serial/8250/8250_uniphier.c
@@ -35,7 +35,7 @@ struct uniphier8250_priv {
spinlock_t atomic_write_lock;
};
-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
static int __init uniphier_early_console_setup(struct earlycon_device *device,
const char *options)
{
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] 8250: uniphier: allow modular build with 8250 console
2016-01-13 22:33 [PATCH] 8250: uniphier: allow modular build with 8250 console Arnd Bergmann
@ 2016-01-21 11:39 ` Masahiro Yamada
2016-01-21 12:21 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2016-01-21 11:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The recently added uniphier 8250 port driver supports early console
> probing, and it supports being built as a module, but the combination
> of the two fails to link:
>
> ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>
> Given that earlycon support in a loadable module makes no sense,
> making that code conditional on 'MODULE' is a correct solution.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>
> diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> index bab6b3ae2540..1b7bd26555b7 100644
> --- a/drivers/tty/serial/8250/8250_uniphier.c
> +++ b/drivers/tty/serial/8250/8250_uniphier.c
> @@ -35,7 +35,7 @@ struct uniphier8250_priv {
> spinlock_t atomic_write_lock;
> };
>
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
> static int __init uniphier_early_console_setup(struct earlycon_device *device,
> const char *options)
> {
>
>
If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
this build error will be fixed as well. But I doubt it is accepted soon...
So, I am OK with this workaround to fix "make allmodconfig".
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] 8250: uniphier: allow modular build with 8250 console
2016-01-21 11:39 ` Masahiro Yamada
@ 2016-01-21 12:21 ` Arnd Bergmann
2016-01-21 14:09 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-21 12:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > The recently added uniphier 8250 port driver supports early console
> > probing, and it supports being built as a module, but the combination
> > of the two fails to link:
> >
> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
> >
> > Given that earlycon support in a loadable module makes no sense,
> > making that code conditional on 'MODULE' is a correct solution.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
> >
> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> > index bab6b3ae2540..1b7bd26555b7 100644
> > --- a/drivers/tty/serial/8250/8250_uniphier.c
> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
> > spinlock_t atomic_write_lock;
> > };
> >
> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
> > static int __init uniphier_early_console_setup(struct earlycon_device *device,
> > const char *options)
> > {
> >
> >
>
>
> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
> this build error will be fixed as well. But I doubt it is accepted soon...
>
> So, I am OK with this workaround to fix "make allmodconfig".
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
Good point. Adding the DT maintainers to Cc. Guys, any chance of you
picking up Masahiro's patch for 4.5?
It can't hurt to have both patches merged, so it would still be good
to have mine in the serial driver fixes, but we can live with either
of the two to fix the build.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] 8250: uniphier: allow modular build with 8250 console
2016-01-21 12:21 ` Arnd Bergmann
@ 2016-01-21 14:09 ` Rob Herring
2016-01-21 16:50 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2016-01-21 14:09 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 21, 2016 at 6:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
>> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>> > The recently added uniphier 8250 port driver supports early console
>> > probing, and it supports being built as a module, but the combination
>> > of the two fails to link:
>> >
>> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>> >
>> > Given that earlycon support in a loadable module makes no sense,
>> > making that code conditional on 'MODULE' is a correct solution.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>> >
>> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
>> > index bab6b3ae2540..1b7bd26555b7 100644
>> > --- a/drivers/tty/serial/8250/8250_uniphier.c
>> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
>> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>> > spinlock_t atomic_write_lock;
>> > };
>> >
>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>> > static int __init uniphier_early_console_setup(struct earlycon_device *device,
>> > const char *options)
>> > {
>> >
>> >
>>
>>
>> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
>> this build error will be fixed as well. But I doubt it is accepted soon...
>>
>> So, I am OK with this workaround to fix "make allmodconfig".
>>
>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>
> Good point. Adding the DT maintainers to Cc. Guys, any chance of you
> picking up Masahiro's patch for 4.5?
I will if you can update the commit log with the details here about it
fixing an actual problem.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] 8250: uniphier: allow modular build with 8250 console
2016-01-21 14:09 ` Rob Herring
@ 2016-01-21 16:50 ` Masahiro Yamada
2016-01-26 1:48 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2016-01-21 16:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rob.
2016-01-21 23:09 GMT+09:00 Rob Herring <robh+dt@kernel.org>:
> On Thu, Jan 21, 2016 at 6:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
>>> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>>> > The recently added uniphier 8250 port driver supports early console
>>> > probing, and it supports being built as a module, but the combination
>>> > of the two fails to link:
>>> >
>>> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>>> >
>>> > Given that earlycon support in a loadable module makes no sense,
>>> > making that code conditional on 'MODULE' is a correct solution.
>>> >
>>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>>> >
>>> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
>>> > index bab6b3ae2540..1b7bd26555b7 100644
>>> > --- a/drivers/tty/serial/8250/8250_uniphier.c
>>> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
>>> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>>> > spinlock_t atomic_write_lock;
>>> > };
>>> >
>>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>>> > static int __init uniphier_early_console_setup(struct earlycon_device *device,
>>> > const char *options)
>>> > {
>>> >
>>> >
>>>
>>>
>>> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
>>> this build error will be fixed as well. But I doubt it is accepted soon...
>>>
>>> So, I am OK with this workaround to fix "make allmodconfig".
>>>
>>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>>
>>
>> Good point. Adding the DT maintainers to Cc. Guys, any chance of you
>> picking up Masahiro's patch for 4.5?
>
> I will if you can update the commit log with the details here about it
> fixing an actual problem.
I did so in v2.
Thanks!
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] 8250: uniphier: allow modular build with 8250 console
2016-01-21 16:50 ` Masahiro Yamada
@ 2016-01-26 1:48 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2016-01-26 1:48 UTC (permalink / raw)
To: linux-arm-kernel
Just for clarification:
The build error was fixed by another patch
(https://patchwork.kernel.org/patch/8082931/)
So, this one is unneeded.
2016-01-22 1:50 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Rob.
>
>
> 2016-01-21 23:09 GMT+09:00 Rob Herring <robh+dt@kernel.org>:
>> On Thu, Jan 21, 2016 at 6:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
>>>> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>>>> > The recently added uniphier 8250 port driver supports early console
>>>> > probing, and it supports being built as a module, but the combination
>>>> > of the two fails to link:
>>>> >
>>>> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>>>> >
>>>> > Given that earlycon support in a loadable module makes no sense,
>>>> > making that code conditional on 'MODULE' is a correct solution.
>>>> >
>>>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>>>> >
>>>> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
>>>> > index bab6b3ae2540..1b7bd26555b7 100644
>>>> > --- a/drivers/tty/serial/8250/8250_uniphier.c
>>>> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
>>>> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>>>> > spinlock_t atomic_write_lock;
>>>> > };
>>>> >
>>>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>>>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>>>> > static int __init uniphier_early_console_setup(struct earlycon_device *device,
>>>> > const char *options)
>>>> > {
>>>> >
>>>> >
>>>>
>>>>
>>>> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
>>>> this build error will be fixed as well. But I doubt it is accepted soon...
>>>>
>>>> So, I am OK with this workaround to fix "make allmodconfig".
>>>>
>>>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>>>
>>>
>>> Good point. Adding the DT maintainers to Cc. Guys, any chance of you
>>> picking up Masahiro's patch for 4.5?
>>
>> I will if you can update the commit log with the details here about it
>> fixing an actual problem.
>
> I did so in v2.
>
> Thanks!
>
>
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-26 1:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-13 22:33 [PATCH] 8250: uniphier: allow modular build with 8250 console Arnd Bergmann
2016-01-21 11:39 ` Masahiro Yamada
2016-01-21 12:21 ` Arnd Bergmann
2016-01-21 14:09 ` Rob Herring
2016-01-21 16:50 ` Masahiro Yamada
2016-01-26 1:48 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).