From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6700DC63777 for ; Mon, 30 Nov 2020 16:14:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C83B220679 for ; Mon, 30 Nov 2020 16:14:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XENro5z3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fdzM643D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C83B220679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6VGe46ZYzJPt1nheo2xWbM7x0QPriPV2OogmIBN3jEM=; b=XENro5z3fiIwWeqFDQB9r6V4r YedIMhrO+njp36lUoDDvlbsyCJYR7zj5NBnN+sauoWQWCHmZ+vpMLDL0ZIhUnQFVxTA6KCaOvTenA dkKEUnlBqe8CBf8J6eI4rPdd2Bx2GlY/iDCTU0UwtAnRnrEOMi9cuDbtN/WlfL8/r1OJzBc1MyQSe 1UYhn5ACVLxe4zK0hUKr9ttW3VMuj4mpSzQ1i21MGeB2LcuWFJtE1X/ySkDJvsoo4CmSccd6Um2Pa cY7aAqGRH9y+akwFXQ++DTxh2jjvYGNrwZIBmW27e8zOpS+HxisIvoJBIzlamzZ5bH3MA2cj7VuBy h0xIwvY5A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjlnX-0000Tt-31; Mon, 30 Nov 2020 16:13:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjlnU-0000TW-0V for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 16:13:05 +0000 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D02E42085B for ; Mon, 30 Nov 2020 16:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606752783; bh=wuan7nT2b3j/ysuAroybQAZQ8NB/ed1lLmOF9ZpUHhQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fdzM643DQwdapNgIL/8Foi9Rmb5HM+BBBgjOdQutwpztsTTQCu5+nxKdiLubyqXEU LW4ZNZFMrTA7AHxizzx8FkkCmdnl7tW+GPI7Obm1Ws6I2qqvd9g/KyoCec44zIarnQ ygy7FGFb53obaRZwHl2I/2tcwjVVFUJnjslrRUwU= Received: by mail-ed1-f44.google.com with SMTP id b2so4734759edy.13 for ; Mon, 30 Nov 2020 08:13:02 -0800 (PST) X-Gm-Message-State: AOAM530VK7zBT77w0rKS0V9GnHRdPM7PQMgE8295l/KRcCJlMFVlhO49 IBWOZVNjznHM9mrqEI0qQ6Pw0QuNYEhXoi0vGQ== X-Google-Smtp-Source: ABdhPJylQOreCp8QimYarFnXM0CzQZutwGrXF+ZC9QHOflV9bqRy//RSzC3ueRaJOgroSqkF2n7fEAmlFy9T4oMcBMk= X-Received: by 2002:aa7:c816:: with SMTP id a22mr5805431edt.373.1606752781185; Mon, 30 Nov 2020 08:13:01 -0800 (PST) MIME-Version: 1.0 References: <20201116173141.31873-1-kishon@ti.com> <20201116173141.31873-2-kishon@ti.com> <20201118211139.GA1815279@bogus> <1e9b0b56-a42d-bea0-704b-6209532b1abe@ti.com> <1ed82ab5-6171-108d-9b92-a18389044174@ti.com> In-Reply-To: <1ed82ab5-6171-108d-9b92-a18389044174@ti.com> From: Rob Herring Date: Mon, 30 Nov 2020 09:12:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: pci: ti, j721e: Fix "ti, syscon-pcie-ctrl" to take argument To: Kishon Vijay Abraham I X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_111304_216853_68D880DF X-CRM114-Status: GOOD ( 26.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , devicetree@vger.kernel.org, Lorenzo Pieralisi , PCI , "linux-kernel@vger.kernel.org" , Tero Kristo , Tom Joseph , Bjorn Helgaas , linux-omap , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 26, 2020 at 5:53 AM Kishon Vijay Abraham I wrote: > > Hi Rob, > > On 20/11/20 10:39 am, Kishon Vijay Abraham I wrote: > > Hi Rob, > > > > On 19/11/20 2:41 am, Rob Herring wrote: > >> On Mon, Nov 16, 2020 at 11:01:39PM +0530, Kishon Vijay Abraham I wrote: > >>> Fix binding documentation of "ti,syscon-pcie-ctrl" to take phandle with > >>> argument. The argument is the register offset within "syscon" used to > >>> configure PCIe controller. > >>> > >>> Link: Link: http://lore.kernel.org/r/CAL_JsqKiUcO76bo1GoepWM1TusJWoty_BRy2hFSgtEVMqtrvvQ@mail.gmail.com > >> > >> Link: Link: ? > >> > >> AIUI, 'Link' is supposed to be a link to this patch. I guess more than 1 > >> Link would be okay though. > > > > Two Links was a typo, will fix it in the next revision. Nishanth as well > > was asking about using "Link:" tag for a mailing list discussion. > > > > I started using it after Lorenzo had asked me to use Link tag for > > mailing list discussion here sometime back. > > > > https://patchwork.kernel.org/project/linux-pci/patch/20171219083627.7904-1-kishon@ti.com/#21350261 > > > >> > >>> Signed-off-by: Kishon Vijay Abraham I > >>> --- > >>> .../devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 12 ++++++++---- > >>> .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 12 ++++++++---- > >>> 2 files changed, 16 insertions(+), 8 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml > >>> index 3ae3e1a2d4b0..e9685c0bdc3e 100644 > >>> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml > >>> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml > >>> @@ -29,9 +29,13 @@ properties: > >>> - const: mem > >>> > >>> ti,syscon-pcie-ctrl: > >>> - description: Phandle to the SYSCON entry required for configuring PCIe mode > >>> - and link speed. > >>> - $ref: /schemas/types.yaml#/definitions/phandle > >>> + allOf: > >> > >> You no longer need allOf here. > > > > hmm, don't we need it for specifying phandle with fixed cells? FWIW, I > > was referring > > > > https://github.com/devicetree-org/dt-schema/blob/master/test/schemas/good-example.yaml#L187 > > Can you clarify this please? We are now using json-schema v2019.09 syntax which doesn't ignore keywords in addition to a $ref as draft7 and earlier did. The old way with 'allOf' still works though. I just haven't updated the above test cases. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel