From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9553C43381 for ; Mon, 4 Mar 2019 17:43:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B00EF2070B for ; Mon, 4 Mar 2019 17:43:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DJevMfFy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GMOnVWgA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B00EF2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wBchIt2VvVGqrc92tqPJoCtDfbfNgk8pOIDHEB98lAA=; b=DJevMfFyHX/zAx bPpRGqZAgnqyjGI0/lH7PfuZnlVBjB2UsugXPVmyRDZF/7a1mp0Dyv3h23YurnuKuqlvTQAtkXTIX OFMDA8Jqzx9U9YjvA8//c0cyyp1pjTjqlg6ksIhbmrdWSeOjjmQNRiWSPbXoRtCyPf3f6GCqxv4im VZUzJzYk+ji50cD2y/IQRIFVxooE/0H9C9yhuR/TXv7jDwXj8CNOxixczwXkInUoh4r1XvdUx7zV8 fQms5wGd2w25xpU3vlJ+1scI19DNJQ/UYJpxbUKWGXQ8dRPyuH6hJjGuZ2ff5jyohAvuZjIoumNAa RdwmfE5e6QYxW7+AzXOg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0rcS-0002Eq-V9; Mon, 04 Mar 2019 17:43:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0rcN-0001zg-KV; Mon, 04 Mar 2019 17:43:15 +0000 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 244512147A; Mon, 4 Mar 2019 17:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551721391; bh=ozRreU3RmIrmPBt2VbxbTZQcQKmj4OKXbuQN0ktJiHg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GMOnVWgAvagoRM2SpqMMHVdtABAlrvIJdPnolQey3SwQZ8y0cJDsgjI5DDWb8eYtB smyS9ckPZxLc78cCJll9EBq9KZEPTiQgxyNDySvY3Eq8uFKXK8hFEBq/+iPq4xnvMW ccr7IYcV7v4p2iuhnViCjw9635ZP5jECPKXUMFtI= Received: by mail-qt1-f180.google.com with SMTP id d2so6009932qti.11; Mon, 04 Mar 2019 09:43:11 -0800 (PST) X-Gm-Message-State: APjAAAUaHCSvFTURbFSmUDxNHAM0jOMp13sPqPd0LQmdyFQngBQNc7Mo ylg/Drc6eWZMCa2jVpCm9P/Ao288wnkkGSizxA== X-Google-Smtp-Source: APXvYqyEPlo0AQygH5BSbkv/lOmajyJh/zF7vfHmYltzEGg5k86upZNLjDJVK8+51GzTwm/8d3lNQBk1ZpDVZxltIkY= X-Received: by 2002:a0c:91bb:: with SMTP id n56mr15662943qvn.77.1551721390309; Mon, 04 Mar 2019 09:43:10 -0800 (PST) MIME-Version: 1.0 References: <1550561795-31132-1-git-send-email-min.guo@mediatek.com> <1550561795-31132-2-git-send-email-min.guo@mediatek.com> <20190222164923.GA26413@bogus> <1551058604.12020.34.camel@mhfsdcap03> In-Reply-To: <1551058604.12020.34.camel@mhfsdcap03> From: Rob Herring Date: Mon, 4 Mar 2019 11:42:58 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller To: Min Guo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_094311_705153_8906CA9E X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Tony Lindgren , Greg Kroah-Hartman , Linux USB List , "linux-kernel@vger.kernel.org" , Matthias Brugger , Alan Stern , Chunfeng Yun , "moderated list:ARM/Mediatek SoC support" , Bin Liu , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 24, 2019 at 7:36 PM Min Guo wrote: > > Hi Rob, > On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote: > > > From: Min Guo > > > > > > This adds support for MediaTek musb controller in > > > host, peripheral and otg mode. > > > > > > Signed-off-by: Min Guo > > > --- > > > changes in v5: > > > suggested by Rob: > > > 1. Modify compatible as > > > - compatible : should be one of: > > > "mediatek,mt-2701" > > > ... > > > followed by "mediatek,mtk-musb" > > > 2. Add usb connector child node > > > > > > changes in v4: > > > suggested by Sergei: > > > 1. String alignment > > > > > > changes in v3: > > > 1. no changes > > > > > > changes in v2: > > > suggested by Bin: > > > 1. Modify DRC to DRD > > > suggested by Rob: > > > 2. Drop the "-musb" in compatible > > > 3. Remove phy-names > > > 4. Add space after comma in clock-names > > > --- > > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++ > > > 1 file changed, 54 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > new file mode 100644 > > > index 0000000..0632e6e > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > @@ -0,0 +1,54 @@ > > > +MediaTek musb DRD/OTG controller > > > +------------------------------------------- > > > + > > > +Required properties: > > > + - compatible : should be one of: > > > + "mediatek,mt-2701" > > > > That looks like a top-level SoC compatible and doesn't match the > > example. > "mediatek,mt-2701" is an example, just to describe a specific SOC. > May I modify compatibel like: > compatible : should be "mediatek,mtk-musb" No, you should fix the example adding "mediatek,mtk-musb". Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel