From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EED6C35242 for ; Tue, 11 Feb 2020 18:24:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C918206D6 for ; Tue, 11 Feb 2020 18:24:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CE6bzsTT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="A8Zqm6fJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C918206D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pSQeamvwNAepNfxFzMRTtehnNcJhCzo1Utf4Sj3fzL8=; b=CE6bzsTTKM8LVt mwnGxIRHKBBgcT94puZUP6t37P9xeuRcqyU+rPv+JH3GxI1NFOMxbRC3MgVJOxAkn7lmqxAOL2XYX PovxyqPbhIg46rPAvDFxrZynlJ+RPGILR2We/Vzcfm/gr/Ri/xk1GMzfTT2V4YPIG7Bu+hNwHDf3u sGFOjKgIpCZW4qEJqVe9e+01kVpar2xGMa9vyKel+El13Yj6YDn3htl+DmGbSQ8vK3flGNHuOfdkv 3RxLYKR+6+q1W0rVcqu65cAgHOiWooCHgtS1042srmPqZeaf0An7mKrCipZYiNQR2UR01eZa76gNI cMkBn4yqM+DkxpvyfPJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1aDK-0002dN-Ea; Tue, 11 Feb 2020 18:24:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1aDH-0002cw-13 for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 18:24:48 +0000 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 820D5206D6 for ; Tue, 11 Feb 2020 18:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581445486; bh=15RkB8/lsxkdGVyrfUT3PmibNwKSs3pakIPq9O2QKGA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=A8Zqm6fJP2FLzduLIBDokEhN/2d/UrH1tTPxjD5ihd4BFsmr4U+TmlhZKIyLl5OeE y8tyZK1Z+LwxdaT3JO7a63fwdEV45iurNjgynCzt3Az2dG8qrc/SS5bt9W9L6m3vm8 E4RlmQ+12GEi7n7znDshSniOcw1AMCbrmborQU5w= Received: by mail-qv1-f44.google.com with SMTP id db9so5456272qvb.3 for ; Tue, 11 Feb 2020 10:24:46 -0800 (PST) X-Gm-Message-State: APjAAAU3KyloD0gcH/00nkJ5nLDpVB3uazuxXaRhRtf184Aw05UPlfNg fuRXoCqN/RWofw8/Vo2zk6jdeojEjFgnUrSp+w== X-Google-Smtp-Source: APXvYqxfEK6hEL7IX2KvoJP4sjzXqu7vc6OB5e1z94Q1gXnPXU2WIumcI1fS/UN5s1vfda4olh8aSlNY95DTbeSQkqo= X-Received: by 2002:a05:6214:11ac:: with SMTP id u12mr4114530qvv.85.1581445485691; Tue, 11 Feb 2020 10:24:45 -0800 (PST) MIME-Version: 1.0 References: <20200206183808.GA5019@bogus> In-Reply-To: From: Rob Herring Date: Tue, 11 Feb 2020 12:24:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 To: Sai Prakash Ranjan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_102447_113420_42E8C731 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, devicetree-owner@vger.kernel.org, "linux-kernel@vger.kernel.org" , Douglas Anderson , Stephen Boyd , Andy Gross , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-arm-msm , Bjorn Andersson , Matthias Kaehlcke , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 7, 2020 at 12:10 AM Sai Prakash Ranjan wrote: > > Hi Rob, > > On 2020-02-07 00:08, Rob Herring wrote: > > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote: > >> Add missing compatible for watchdog timer on QCS404, > >> SC7180, SDM845 and SM8150 SoCs. > > > > That's not what the commit does. You are changing what's valid. > > > > One string was valid, now 2 are required. > > > > Does this look good? No. First of all, what's the base for the diff? It's not what you originally had nor incremental on top of this patch. Second, a value of 'qcom,kpss-timer' or 'qcom,kpss-wdt' or 'qcom,scss-timer' will fail validation because 2 clauses of 'oneOf' will be true. > > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > index 46d6aad5786a..3378244b67cd 100644 > --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > @@ -14,19 +14,22 @@ allOf: > > properties: > compatible: > - items: > + oneOf: > - enum: > - qcom,apss-wdt-qcs404 > - qcom,apss-wdt-sc7180 > - qcom,apss-wdt-sdm845 > - qcom,apss-wdt-sm8150 > - - qcom,kpss-timer > - - qcom,kpss-wdt > - qcom,kpss-wdt-apq8064 > - qcom,kpss-wdt-ipq4019 > - qcom,kpss-wdt-ipq8064 > - qcom,kpss-wdt-msm8960 > + - qcom,kpss-timer > + - qcom,kpss-wdt > - qcom,scss-timer > + - const: qcom,kpss-timer > + - const: qcom,kpss-wdt > + - const: qcom,scss-timer > > reg: > maxItems: 1 > > Thanks, > Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a > member > of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel