From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE60C433B4 for ; Fri, 7 May 2021 17:23:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C31A613ED for ; Fri, 7 May 2021 17:23:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C31A613ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8L8jbEt7fr1aCTQU7Nn6DchUMbTf0BC6fN5ikJnu/1Y=; b=bSAYT4d+XT2tuL20Kghu1zgk/ H8IGsvu3V9ERGJKc5Nrz857XOWPojlXI4FwGnFbmGRZSB4/BNi+84vof5JBXbQZRaMwr3Yvfr3vpf LWofMzWcFQF030FmlMKj3DKFS09ZzqBAEIOrsznOsl1IZfq+yQlf4F2RRya1FNMgC1gwlS0TGjB1Z IOyuFghphsV+8Nb7QyUlH8TQmAQieR9ryEejsXJpKS6jvenkpujOAaUbdXO7RzvYdWC/P4kFeTjxn biB+e1HR5DM3JLZzGQH01TV/X2fSAEKpJm8xyCls79UtYYm/t+l3NGyxHjWWC8xqfNxiyBbFvGoZQ 6eVeaOvKQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lf4Aw-007fEw-8T; Fri, 07 May 2021 17:22:06 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf4At-007fEf-2g for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 17:22:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3hHfFRXVR05JAoq2Q7/AeatbuJrf5jqg6H8ay+H7sy8=; b=HXKofQU4WYvh2C+BaW+jU5BDVd tTICP9qzUkunswO8ZYHqijkLA267kaH+TBnHRESoYgkgSKSbv5AtheR8uEIJehnh4mGAMMu8cYcrU e3ljM7a83jXmPLlKytNLwG7gaZGuQY4wM6dD7aQjpAiq9xAv7CLcZdiTNCiyHkeTWFJWPbvXSDROg g+dUJoPLAijIIeODTHmS0xgl0oaXsRhRTfV5I7lGVic83/23DYtEZbEHl1qOkAZSYkSzDlh5+U3uz Hp9vUZMoRBQMhS35tf379Dk32XIXWHQxCkG3iarc9sW2rMnyeFfiJe+ueNDraxiCk/olFIEXPHH/x bTIIQJwQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf4Aq-0072K6-CO for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 17:22:01 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F78461463 for ; Fri, 7 May 2021 17:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620408119; bh=tAp8HMPCWwh+NHuRDeCEmS0cp+aQxiTRacpv+7HZQaA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jMWuPbnOx6U5JZ6lRhEBYIFqNUnKAwzdc5WQfVuFRGqAC2rekeI9FxYRtfcVBjKuM 97WoLmGZ1f1xezdG2Mm7GDXQkdgtPie37cHlyxL9E/d3wzas81leEO2jGQJfrcrRhb KMnBTLrq4TULos6RHk2OFJ8hDdyR7n71XyrFno4m3EGZkyLY2UtBu6XtEZYVn/YFIs qSdkZX5JN5kVDZCJS+nczGgDSWspBE1R0IFRCuHst3zdUpb/WuylLIZmfWww8BVmvf gZmhsm6y0H/21HbZdM+/lpZu4oq+aFbW0Neda4grx0UZ4qNgcsshKrMsuDKlwCUkqe 3dlNkERzA9Iww== Received: by mail-ej1-f47.google.com with SMTP id a4so14747101ejk.1 for ; Fri, 07 May 2021 10:21:58 -0700 (PDT) X-Gm-Message-State: AOAM5339sRhJHDmIlEiY4r2Cwzc/wz+qvWmFXlVovwtVkAGSYW+KUCGO +T7ECegBNgJruqRibJfejCWe6QoU7TvPiQYLhw== X-Google-Smtp-Source: ABdhPJxlHzBX1kiOwdryT4JxLp1ZW5TdkQ+pgCxGNOoI/UqgbP1iECA3RgBAMWk0XjgD5TeZd/KBEkXxO5L1SMOtnxE= X-Received: by 2002:a17:906:a0c6:: with SMTP id bh6mr11119997ejb.359.1620408117401; Fri, 07 May 2021 10:21:57 -0700 (PDT) MIME-Version: 1.0 References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-2-steven_lee@aspeedtech.com> <20210507011324.GA1119409@robh.at.kernel.org> <20210507031348.GA23749@aspeedtech.com> In-Reply-To: <20210507031348.GA23749@aspeedtech.com> From: Rob Herring Date: Fri, 7 May 2021 12:21:45 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/5] dt-bindings: mmc: sdhci-of-aspeed: Add an example for AST2600-A2 EVB To: Steven Lee Cc: Andrew Jeffery , Ulf Hansson , Joel Stanley , Adrian Hunter , Philipp Zabel , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , "open list:ASPEED SD/MMC DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "Hongweiz@ami.com" , Ryan Chen , Chin-Ting Kuo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_102200_507916_82E55500 X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 6, 2021 at 10:14 PM Steven Lee wrote: > > The 05/07/2021 09:13, Rob Herring wrote: > > On Thu, May 06, 2021 at 06:03:08PM +0800, Steven Lee wrote: > > > AST2600-A2 EVB has the reference design for enabling SD bus > > > power and toggling SD bus signal voltage by GPIO pins. > > > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to > > > power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is > > > connected to a 1.8v and a 3.3v power load switch that providing > > > signal voltage to > > > SD1 bus. > > > > > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > > disabled. > > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 > > > signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > > enabled, SD1 signal voltage becomes 1.8v. > > > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > > GPIOV3 as power-switch-gpio. > > > > > > Signed-off-by: Steven Lee > > > --- > > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 101 +++++++++++++++++- > > > 1 file changed, 97 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > index 987b287f3bff..de7e61b3d37a 100644 > > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > @@ -45,10 +45,16 @@ patternProperties: > > > > > > properties: > > > compatible: > > > - enum: > > > - - aspeed,ast2400-sdhci > > > - - aspeed,ast2500-sdhci > > > - - aspeed,ast2600-sdhci > > > + oneOf: > > > + - items: > > > + - enum: > > > + - aspeed,ast2400-sdhci > > > + - aspeed,ast2500-sdhci > > > + - aspeed,ast2600-sdhci > > > + - items: > > > + - enum: > > > + - aspeed,ast2600-sdhci > > > + - const: sdhci > > > > Why are you adding 'sdhci'. That's not useful as a compatible given how > > many quirks different implementations have. > > > > > > It is for passing the dtbs_check of the second example. > Without this definition, many device trees have the following > error: > > ['aspeed,ast2600-sdhci', 'sdhci'] is too long > Additional items are not allowed ('sdhci' was unexpected) I would probably fix the dts files then. Does anything depend on 'sdhci'? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel