linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinebook Pro
@ 2025-08-27 14:26 Peter Robinson
  2025-08-27 14:48 ` Peter Robinson
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Robinson @ 2025-08-27 14:26 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	Diederik de Haas, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel
  Cc: Peter Robinson

As described in the pinebookpro_v2.1_mainboard_schematic.pdf page 10,
he SPI Flash's VCC connector is connected to VCC_3V0 power source.

This fixes the following warning:

  spi-nor spi1.0: supply vcc not found, using dummy regulator

Fixes: 5a65505a69884 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 5a8551d9ffe47..b33a1509a8e93 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -959,6 +959,7 @@ spiflash: flash@0 {
 		reg = <0>;
 		m25p,fast-read;
 		spi-max-frequency = <10000000>;
+		vcc-supply = <&vcc_3v0>;
 	};
 };
 
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinebook Pro
  2025-08-27 14:26 [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinebook Pro Peter Robinson
@ 2025-08-27 14:48 ` Peter Robinson
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Robinson @ 2025-08-27 14:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	Diederik de Haas, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel

Apologies, I believe I've already sent this and it's been applied.

On Wed, 27 Aug 2025 at 15:27, Peter Robinson <pbrobinson@gmail.com> wrote:
>
> As described in the pinebookpro_v2.1_mainboard_schematic.pdf page 10,
> he SPI Flash's VCC connector is connected to VCC_3V0 power source.
>
> This fixes the following warning:
>
>   spi-nor spi1.0: supply vcc not found, using dummy regulator
>
> Fixes: 5a65505a69884 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> index 5a8551d9ffe47..b33a1509a8e93 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> @@ -959,6 +959,7 @@ spiflash: flash@0 {
>                 reg = <0>;
>                 m25p,fast-read;
>                 spi-max-frequency = <10000000>;
> +               vcc-supply = <&vcc_3v0>;
>         };
>  };
>
> --
> 2.51.0
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-27 16:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 14:26 [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinebook Pro Peter Robinson
2025-08-27 14:48 ` Peter Robinson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).