From: davidm@egauge.net (David Mosberger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: power: reset: at91-reset: Provide reset reason via sysfs (amended with Signed-off-by tag)
Date: Mon, 25 Jan 2016 09:17:55 -0700 [thread overview]
Message-ID: <CALnQHM2vwhKPkrOABV9idrMrWync-Hi7MdZ_dEyEOEp3_k77yQ@mail.gmail.com> (raw)
In-Reply-To: <20160125085539.GB16261@piout.net>
Alexandre,
Thanks for taking a look at the patch.
On Mon, Jan 25, 2016 at 1:55 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> All sysfs files have to be documented. Can you add some documentation in
> Documentation/ABI ?
I'm not familiar with out this is organized and what file this would
have to be added to. Other than that, sure I'd be happy to write
something up.
> Also, I think this should be added as a generic file for the whole subsystem.
A patch that shows what you have in mind would be helpful here.
>> - pr_info("AT91: Starting after %s\n", reason);
You must have missed:
>> + pr_info("AT91: Starting after %s\n", at91_reset_reason(pdev));
Best regards,
--david
--
eGauge Systems LLC, http://egauge.net/, 1.877-EGAUGE1, fax 720.545.9768
next prev parent reply other threads:[~2016-01-25 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 16:48 [PATCH] drivers: power: reset: at91-reset: Provide reset reason via sysfs (amended with Signed-off-by tag) David Mosberger-Tang
2016-01-25 8:55 ` Alexandre Belloni
2016-01-25 16:17 ` David Mosberger [this message]
2016-01-27 7:14 ` Sebastian Reichel
2016-02-15 19:47 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALnQHM2vwhKPkrOABV9idrMrWync-Hi7MdZ_dEyEOEp3_k77yQ@mail.gmail.com \
--to=davidm@egauge.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).