linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mcoquelin.stm32@gmail.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH soc] ARM: use ARM_SINGLE_ARMV7M for ARMv7-M platforms
Date: Fri, 22 May 2015 17:29:20 +0200	[thread overview]
Message-ID: <CALszF6D-3pXHtyVMwhO0JkT-dCSSB98UNDHNN7-LD04Wdgd2cA@mail.gmail.com> (raw)
In-Reply-To: <15864413.ed8EFg1NLl@wuerfel>

2015-05-22 16:50 GMT+02:00 Arnd Bergmann <arnd@arndb.de>:
> [one small request as I have four armv7-m folks on Cc already:
>  could one of you try to fix the warning that I get with every
>  single build: "/git/arm-soc/arch/arm/kernel/head-nommu.S: Assembler
> messages: /git/arm-soc/arch/arm/kernel/head-nommu.S:167: Warning:
> Use of r13 as a source register is deprecated when r15 is the
> destination register."]

Moving r13 to r12 and returning r12 seems to do the job (see below).
But I don't know if there is a more elegant way, and if it is also
valid for other architectures than armv7-m.
I can propose a patch if someone can confirm it is valid.

Regards,
Maxime

-------------------------------------------------------------------------------------------------------------

diff --git a/arch/arm/kernel/head-nommu.S b/arch/arm/kernel/head-nommu.S
index aebfbf7..e84bdad 100644
--- a/arch/arm/kernel/head-nommu.S
+++ b/arch/arm/kernel/head-nommu.S
@@ -164,7 +164,8 @@ __after_proc_init:
 #endif
        mcr     p15, 0, r0, c1, c0, 0           @ write control reg
 #endif /* CONFIG_CPU_CP15 */
-       ret     r13
+       mov     r12, r13
+       ret     r12
 ENDPROC(__after_proc_init)
        .ltorg

  reply	other threads:[~2015-05-22 15:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 22:35 [PATCH soc] ARM: use ARM_SINGLE_ARMV7M for ARMv7-M platforms Stefan Agner
2015-05-21  6:43 ` Uwe Kleine-König
2015-05-21 17:00 ` Joachim Eastwood
2015-05-21 19:04   ` Uwe Kleine-König
2015-05-22  7:27     ` Stefan Agner
2015-05-22  9:37       ` Arnd Bergmann
2015-05-22  7:53 ` Arnd Bergmann
2015-05-22  8:54   ` Stefan Agner
2015-05-22  9:39     ` Arnd Bergmann
2015-05-22 13:06 ` Maxime Coquelin
2015-05-22 14:50 ` Arnd Bergmann
2015-05-22 15:29   ` Maxime Coquelin [this message]
2015-05-22 15:36     ` Stefan Agner
2015-05-22 15:56     ` Daniel Thompson
2015-05-22 16:28       ` Stefan Agner
2015-05-22 18:06         ` Russell King - ARM Linux
2015-05-22 19:34           ` Stefan Agner
2015-05-22 17:56     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALszF6D-3pXHtyVMwhO0JkT-dCSSB98UNDHNN7-LD04Wdgd2cA@mail.gmail.com \
    --to=mcoquelin.stm32@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).