From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5378FCA90AF for ; Wed, 13 May 2020 12:06:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AB4420740 for ; Wed, 13 May 2020 12:06:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mH/52NC4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qeD6Nm2m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AB4420740 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date: From:In-Reply-To:References:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7aXqkGZr3yPNXiZL/NGnd2iQvLIN2I/wKnZGMOXP9kY=; b=mH/52NC4Mplhym ypzDZDeiYcjLzCXCI3yw/NkC9kwOwgRV6L+w7uwXJaR4RhmojYjARB1jh0tUTyl6X40VDz2VznUbG QvjimlB/fEGEWSzzrctD5qH4QWmXQojtf48sjVYIJmzrYJEfCP7NplqbUqq3sCp6e06NDp6sxKkgP DMgQegCNSxbTTVsgHv9mWep/K7f81s1RgmtP6OJiDNW6Rm26021uRRmHj1kV93qTFNQGBq4Ig9rk4 JRlV3/FBIzmvqlBuioISaFjD8XViy7cL5zi387uipTgVyom/llRM05cLVpoCBS69zpStLNA/Co70/ ZF5g2zFg0zicjxkD0WwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYq9b-0001oG-3q; Wed, 13 May 2020 12:06:27 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYq9V-0001mP-Vn; Wed, 13 May 2020 12:06:23 +0000 Received: by mail-lj1-x242.google.com with SMTP id a21so17448013ljj.11; Wed, 13 May 2020 05:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=rqWzzkOtBCpmgaVCKpj7+jaGD37zCFqeMtexNP5QRuE=; b=qeD6Nm2mKPVu1exoYnpXJhhjBKHZdaUMDm2AWDFhZys9RnaspB+P9VkYujGl31nKqn WagkYgVtSZCMVipmZjuysPlRWLkGigdsNodZaDhc8L2KEn/n+Aw5NlowCNryZdhwjJuZ I9a/eMvfwWEwNfBAin+KyqE8TYwXYIKwsKK5kx0W4srvRYKEU6cic5if37CexbOe7xS0 bzXvtii3T3raofA0lLhK649Whj5GXdeYkJEF+6/JSFgiGI9sB03QalwmwGx5+Beo6eyE B8IRfi1FpydyMtcRG9+Cz8cFmpY5Io9Gk1UvzF3XnQ59sCTh9fi8i9S9h6NmsJmNxg4i Tgkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=rqWzzkOtBCpmgaVCKpj7+jaGD37zCFqeMtexNP5QRuE=; b=fG1LWTm4dpIQ9ygn2WuG1OwE9s6bsSCpEfnEgX1HHy9h77yP7oeHSR4i2I4vnZ94pW EP0pbjlwMxiRKZiD+j5HPtm2POztK5bNyNecjeZUwVnfEi/0pivZQgeEx+S9h0+dw0mD yEmQfUqQpTDXmIEsWbsHRUW81PGMuoAKy8MfvNB87dNKnj96MulHnxOBdJeJwMmBuzNf Co4BMs0RyfNCMvTdLxYKRU+Nz6t1HEuVDapzB7F76hw8vHpDRCkJHpvhCB0YqcKMyDeP pFJfageHFBZu3TlKE8x99ZdT9Hpz7OSJdXgCIrBnFzbicdo0EQClQpIYy0fB2WRZ201M Pm1A== X-Gm-Message-State: AOAM530Kfm6dWyWcwuliljF5dX1B8oMSn1O0Xsv0lZWcyFhUNcrZtp0J wxmsoFhyJ6INy9465qy2t3Zgp0pgaYO8s1FX9CU= X-Google-Smtp-Source: ABdhPJySqd5aKEee2N8mNCkrbF8REchFhQ7yF5jLHkOX7270Pxv7mqJsGVq7Ix9WFSznPLx8EacrYqvbMQJ7yygKp68= X-Received: by 2002:a2e:8590:: with SMTP id b16mr17846575lji.45.1589371579390; Wed, 13 May 2020 05:06:19 -0700 (PDT) MIME-Version: 1.0 References: <20200510101308.10451-1-john.oldman@polehill.co.uk> <20200513115823.GC953616@kroah.com> In-Reply-To: <20200513115823.GC953616@kroah.com> From: John Oldman Date: Wed, 13 May 2020 13:06:08 +0100 Message-ID: Subject: Re: [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment To: Greg KH X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_050622_018688_0CE01975 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: john.oldman@polehill.co.uk Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, nsaenzjulienne@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org yea I agree, will re-submit... Cheers john On Wed, 13 May 2020 at 12:58, Greg KH wrote: > > On Sun, May 10, 2020 at 11:13:08AM +0100, John Oldman wrote: > > Coding style issue > > This patch clears the checkpatch.pl "Block comments should align the * on each line" warning. > > > > Signed-off-by: John Oldman > > --- > > v1: Initial attempt. > > v2: Resubmitted with shorter comment line, as suggested by Greg KH. > > v3: Resubmitted with descriptiuon text moved into the comment area. > > > > .../interface/vchiq_arm/vchiq_connected.c | 32 +++++++++---------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > index 1640906e3929..993535bbc479 100644 > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > @@ -15,10 +15,10 @@ static int g_once_init; > > static struct mutex g_connected_mutex; > > > > /**************************************************************************** > > -* > > -* Function to initialize our lock. > > -* > > -***************************************************************************/ > > + * > > + * Function to initialize our lock. > > + * > > + ***************************************************************************/ > > > > static void connected_init(void) > > Shouldn't that really be written as: > > /* Function to initialize our lock */ > static void connect_init(void); > > > No need for the /****** mess, and no need for the blank line. > > Simple and clean is best. > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel