From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: pxa: fix building error by palm27x_lcd_init() when FB_PXA not defined
Date: Mon, 26 Sep 2011 17:02:03 +0800 [thread overview]
Message-ID: <CAMPhdO-gZOnMjHog0t7cp74rs+Z+D76v2dPLBgp+jUGNG9J39A@mail.gmail.com> (raw)
In-Reply-To: <201109261100.07265.marek.vasut@gmail.com>
2011/9/26 Marek Vasut <marek.vasut@gmail.com>:
> On Monday, September 26, 2011 05:53:16 AM Eric Miao wrote:
>> Cc: Marek Vasut <marek.vasut@gmail.com>
>> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>> ---
>> ?arch/arm/mach-pxa/include/mach/palm27x.h | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h
>> b/arch/arm/mach-pxa/include/mach/palm27x.h index 0a5e5ea..f80bbe2 100644
>> --- a/arch/arm/mach-pxa/include/mach/palm27x.h
>> +++ b/arch/arm/mach-pxa/include/mach/palm27x.h
>> @@ -34,7 +34,7 @@ extern struct pxafb_mode_info palm_320x320_new_lcd_mode;
>> ?extern void __init palm27x_lcd_init(int power,
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct pxafb_mode_info *mode);
>> ?#else
>> -static inline void palm27x_lcd_init(int power, struct pxafb_mode_info
>> *mode) {} +#define palm27x_lcd_init(power, mode) ? ? ?do {} while (0)
>> ?#endif
>>
>> ?#if ?defined(CONFIG_USB_GADGET_PXA27X) || \
>
> Hi Eric,
>
> NAK. Why do you do such a change ? Especially as this will likely interfere with
> gcc4.6's unused-but-set variable checking.
OK, I'll hold this one. Feel free to give me a solution.
next prev parent reply other threads:[~2011-09-26 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 3:53 [PATCH 1/2] ARM: pxa: fix building error by palm27x_lcd_init() when FB_PXA not defined Eric Miao
2011-09-26 3:53 ` [PATCH 2/2] ARM: pxa/z2: fix building error of pxa27x_cpu_suspend() no longer available Eric Miao
2011-09-26 9:00 ` [PATCH 1/2] ARM: pxa: fix building error by palm27x_lcd_init() when FB_PXA not defined Marek Vasut
2011-09-26 9:02 ` Eric Miao [this message]
2011-09-26 9:06 ` Marek Vasut
2011-09-26 9:46 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMPhdO-gZOnMjHog0t7cp74rs+Z+D76v2dPLBgp+jUGNG9J39A@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).