From: santosh.shilimkar@ti.com (Shilimkar, Santosh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: smp_twd: get the rate from a clock
Date: Tue, 13 Dec 2011 14:16:13 +0530 [thread overview]
Message-ID: <CAMQu2gyauDsYE+MK56iKhrVBgvOU8Z3Hbtfxd-G_ZmQUBAW4LQ@mail.gmail.com> (raw)
In-Reply-To: <20111213081723.GB14542@n2100.arm.linux.org.uk>
On Tue, Dec 13, 2011 at 1:47 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Dec 13, 2011 at 10:54:14AM +0530, Santosh Shilimkar wrote:
>> > +static struct clk *twd_get_clock(void)
>> > +{
>> > + ? struct clk *clk;
>> > + ? int err;
>> > +
>> > + ? clk = clk_get_sys("smp_twd", NULL);
>>
>> As noticed by Mike, would be better to use con_id instead
>> of dev_id here. I mean,
>> clk = clk_get_sys(NULL, "smp_twd");
>
> Why? ?It makes more sense for a device ID to be passed for this.
Sorry. I assumed clk_get_sys() signature same as clk_get(). And then
thought dev pointer and con_id is the right way to go about it.
Since clk_get_sys() directly takes dev_id, it should be fine.
Will update OMAP clock-node patch accordingly.
Regards
Santosh
prev parent reply other threads:[~2011-12-13 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 9:57 [PATCH 3/4] ARM: smp_twd: get the rate from a clock Linus Walleij
2011-12-12 13:46 ` Russell King - ARM Linux
2011-12-13 5:24 ` Santosh Shilimkar
2011-12-13 8:17 ` Russell King - ARM Linux
2011-12-13 8:46 ` Shilimkar, Santosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMQu2gyauDsYE+MK56iKhrVBgvOU8Z3Hbtfxd-G_ZmQUBAW4LQ@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).