From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 275ECC433F5 for ; Wed, 16 Feb 2022 14:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FN3CsPWKmVgLgfilEs199fyiHEdJUo6QX2fPn+F0pTU=; b=qHBfdol8Oc9upw KN7j4A4WmZXu5fr5aPVkN/L76xPbFS4zS7lK+WgksEyZ8+LZfroeOQ7InzVCJ+NyfVRQxRgl7oyUu uW24FNRSH7IvaWQ2vwLxgG71SgnSGl0tr6PiKe7ZZo/wQGcyCIeepfOuM4kWRSej5A46fYHO0PzWo 98J7nWgy2eCKa5h96dClpEW+4uWO5HnzdvT+eYae3e7OHCRhjQfE4MSc/7alyTRpni22rRAh3rjSx qDdmMVT9I8ZZcjKQPZwm1JkIu3azD64dTaVIC1QkHXJR12hpeEjklVIEYsV++kiHiKVMUaKZwnbPe CxZ+pcOowBfzPMmVL9DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKLid-007Ozp-3h; Wed, 16 Feb 2022 14:55:47 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKLiY-007Owo-Vg for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 14:55:44 +0000 Received: by mail-ed1-x52a.google.com with SMTP id h18so4341660edb.7 for ; Wed, 16 Feb 2022 06:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iuYrqVGn1TXdwN+P98XHhqL2+XquzgdKMr559j4kzX0=; b=m7KLBnpGSaAT+kElQbyWCpRqg8l5Xarj7SE9j9Q+Gl2zvdSTaYahgURCT8X5H2Ni2L vKgECZZX8XD2Y+QnZUn27ISb3qicevOkHpXjolTw4zvDUEZ72k1XrDUvmMrxR54sLgeY n13R9STJnkboF2nq0JYVV0CkTfuV7LwJVNvxNS5xWP5B6cH2rixzqtQf2Cdo2K3XlnwY Y3/XG4x8s2oNS9/DZTMyIJntOp4KAtdJtIzNeA4e5c8HhqkwQdzAK+3eH3jMcrW9BiHV j3lDpWbx9LLmAtuLKrS+VdGFzIfr2OJ8Hil2kSdMkWrSio4XnljeNfior5cdXBv/M9nm 55Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iuYrqVGn1TXdwN+P98XHhqL2+XquzgdKMr559j4kzX0=; b=pL7o/VGddTFHH65vw4nPcDZ/OerFKPoYF+iRo5zDbU1rj0eTy71Cjf0rXt8GIYy47K n+t5a6RYL+YIAsqKFDIy1e2KuQpd1S5eIf7aJFKNiE2NdzRI2gXQ4m5w1BA4c6JZXKcz aCZDaKT9hGF9IPBIhxHQiB175rMtb/0eDLirD4R0J+pysEx6CXjm9RHJ8Pd4VNPWXjJG +HnrWrW+3k2HNt7SrUsvQj+zWmyTPmif3FPxds5G4OG/4Ukt/SMg9Y41wzJZliCbnmBO PCJZLG3t7UaZzG7u4qrDc3j0lZHzmxcYrxhFmO7/eGgkA+KYjxfaQhCOJXuq6joeUETd 6X0Q== X-Gm-Message-State: AOAM532tl6d7EQPNbVIgfaUVSmXnYRPzsFFNe5CHq/uTsxQuQhz5WG/u NKVmO9a2S5YELxM1S/Ehj1VpgfGhzvCK8DxBx+dAQA== X-Google-Smtp-Source: ABdhPJzRulNtz/zoAWp3FH3AaM0DWDfR2fpgNtKv4EW2Sx9/HjO3bwTxfgHobgEyuXG7kSkT/MQf3yK3aZjoHeh44u4= X-Received: by 2002:a05:6402:5194:b0:409:97ec:3bdc with SMTP id q20-20020a056402519400b0040997ec3bdcmr3466054edd.314.1645023340859; Wed, 16 Feb 2022 06:55:40 -0800 (PST) MIME-Version: 1.0 References: <20220212205048.43862-1-samuel@sholland.org> In-Reply-To: <20220212205048.43862-1-samuel@sholland.org> From: Bartosz Golaszewski Date: Wed, 16 Feb 2022 15:55:30 +0100 Message-ID: Subject: Re: [PATCH] gpio: rockchip: Reset int_bothedge when changing trigger To: Samuel Holland Cc: Linus Walleij , Heiko Stuebner , Jianqun Xu , "open list:GPIO SUBSYSTEM" , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Guillaume Savaton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_065543_030032_E09F8734 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 12, 2022 at 9:50 PM Samuel Holland wrote: > > With v2 hardware, an IRQ can be configured to trigger on both edges via > a bit in the int_bothedge register. Currently, the driver sets this bit > when changing the trigger type to IRQ_TYPE_EDGE_BOTH, but fails to reset > this bit if the trigger type is later changed to something else. This > causes spurious IRQs, and when using gpio-keys with wakeup-event-action > set to EV_ACT_(DE)ASSERTED, those IRQs translate into spurious wakeups. > > Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller") > Reported-by: Guillaume Savaton > Tested-by: Guillaume Savaton > Signed-off-by: Samuel Holland > --- Queued for fixes, thanks! Bart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel