From: rob.lee@linaro.org (Rob Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 1/2] cpuidle: Add common init interface and idle functionality
Date: Wed, 4 Jan 2012 17:21:47 -0600 [thread overview]
Message-ID: <CAMXH7KEgPg2F-Trioo+9w9nRuX081jKF8y_Re7mFLxn2-dWutg@mail.gmail.com> (raw)
In-Reply-To: <20111222180923.GH29622@opensource.wolfsonmicro.com>
Mark, thanks again for your review. Will fix the indention in v3.
On 22 December 2011 12:09, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Dec 14, 2011 at 01:02:05AM -0600, Robert Lee wrote:
>> The patch adds some cpuidle initialization functionality commonly
>> duplicated by many platforms. ?The duplicate cpuidle init code of
>> various platfroms has been consolidated to use this common code
>> and successfully rebuilt.
>>
>> Signed-off-by: Robert Lee <rob.lee@linaro.org>
>
> Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> This looks good to me with one small comment:
>
>> +int cpuidle_def_idle(struct cpuidle_device *dev,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct cpuidle_driver *drv, int index) {
>> + ? ? cpu_do_idle();
>> + ? ? return index;
>> +}
>
> Odd indentation here.
>
> I'll move my s3c64xx cpuidle code over to this, though I think it'll end
> up being an incremental patch as Kukjin just said he'd apply it and it'd
> be nice to get the support into 3.3 if we can.
next prev parent reply other threads:[~2012-01-04 23:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 7:02 [RFC PATCH v2 0/2] Add common cpuidle code for consolidation Robert Lee
2011-12-14 7:02 ` [RFC PATCH v2 1/2] cpuidle: Add common init interface and idle functionality Robert Lee
2011-12-22 18:09 ` Mark Brown
2012-01-04 23:21 ` Rob Lee [this message]
2011-12-22 22:57 ` Rob Herring
2012-01-04 23:15 ` Rob Lee
2012-01-04 23:35 ` Turquette, Mike
2012-01-04 23:51 ` Rob Herring
2012-01-05 20:11 ` Turquette, Mike
2012-01-05 9:32 ` Russell King - ARM Linux
2012-01-05 16:42 ` Rob Lee
2011-12-14 7:02 ` [RFC PATCH v2 2/2] ARM: imx: Add mx5 cpuidle implmentation Robert Lee
2011-12-22 17:50 ` Mark Brown
2012-01-04 23:35 ` Rob Lee
2012-01-05 3:21 ` Shawn Guo
2012-01-05 5:55 ` Mark Brown
2012-01-06 21:10 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMXH7KEgPg2F-Trioo+9w9nRuX081jKF8y_Re7mFLxn2-dWutg@mail.gmail.com \
--to=rob.lee@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).