From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80768C63777 for ; Tue, 17 Nov 2020 08:23:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DD0524655 for ; Tue, 17 Nov 2020 08:22:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cNSABrbO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aMICjLQG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DD0524655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BlPycl+VPCzdPA36cynaSJeU1PRzI75vvWRHrdUXhb4=; b=cNSABrbOLeXQbsFniySeXDKaH 8qm8xHuALON9VRkpw64q9+fE3GlXl6Rb6zRIE1QeawFlimy5oALgdH3dcMPvY2ReSMRLBZsMY0cZE OafxFjhVit3Sh+JMBzeTAe+JmVd2sxGQGXBHVPtSd0z5sfqOQbYdA6FlIMpBUQiR70uxONsi10Fgl kxucMelpnUO4aTAS5FMC4RQFPbiBzXEkM9irH+OwJClftjThsaQkZFoNVFIAJxOeCJgJmJB/I1vsW J3MFBzKDG9OgEBBbhUh0ig9tduCMBcpugZOagPkjp4wvJdChQf42CpWwzXn5ikkjGD/XlajNdelXn sSK1X2wNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kewFM-0007cq-IA; Tue, 17 Nov 2020 08:21:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kewFK-0007cB-8l for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 08:21:50 +0000 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50A6D20825 for ; Tue, 17 Nov 2020 08:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605601309; bh=/lU39LcTh4tWsgd87zsuhV4DP9LuuD1LuOX8fLHQ8O0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aMICjLQG2y6l0To58egkMQBGm08EvxFmdaEG5cRdFWWyIL+b+kh4W5/QylB+Cqqix aoKVfcZPHGeCHfzTeB5vbfYHQ5hkov00okC5DxWOoXwHli25DqEmuH6itBgLi1UQbG IGIr2M5XMsiG9ct00XRAG7fusBEY8biuCVv0ikOc= Received: by mail-ot1-f52.google.com with SMTP id 79so18592028otc.7 for ; Tue, 17 Nov 2020 00:21:49 -0800 (PST) X-Gm-Message-State: AOAM531hw8d+FWHbdWM5TkoxOezBXJSA9S7mQ70OpdulzJj/NVycsAza /guiDGfIY4a7LvwL+C/7T9MqyCVCuOKPLUZTQ7k= X-Google-Smtp-Source: ABdhPJw+yvVn+Z/uvJl5kpH9Kw+duLzXW3fbvAoHfQTozF8yV3r/AT4zE8iFTgqwgGpYYg7Szdto5ES6+Jv5WbEJD1c= X-Received: by 2002:a05:6830:115a:: with SMTP id x26mr2388087otq.77.1605601308583; Tue, 17 Nov 2020 00:21:48 -0800 (PST) MIME-Version: 1.0 References: <20201116145650.25513-1-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Tue, 17 Nov 2020 09:21:35 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: head.S: explicitly map DT even if it lives in the first physical section To: Linus Walleij X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_032150_397885_0D6E4667 X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guillaume Tucker , Russell King , Linux ARM , Nicolas Pitre Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Nov 2020 at 00:33, Linus Walleij wrote: > > On Mon, Nov 16, 2020 at 3:57 PM Ard Biesheuvel wrote: > > > The early ATAGS/DT mapping code uses SECTION_SHIFT to mask low order > > bits of R2, and decides that no ATAGS/DTB were provided if the resulting > > value is 0x0. > > > > This means that on systems where DRAM starts at 0x0 (such as Raspberry > > Pi), no explicit mapping of the DT will be created if R2 points into the > > first 1 MB section of memory. This was not a problem before, because the > > decompressed kernel is loaded at the base of DRAM and mapped using > > sections as well, and so as long as the DT is referenced via a virtual > > address that uses the same translation (the linear map, in this case), > > things work fine. > > > > However, commit 149a3ffe62b9dbc3 ("9012/1: move device tree mapping out of > > linear region") changes this, and now the DT is referenced via a virtual > > address that is disjoint from the linear mapping of DRAM, and so we need > > the early code to create the DT mapping unconditionally. > > > > So let's create the early DT mapping for any value of R2 != 0x0. > > > > Fixes: 149a3ffe62b9dbc3 ("9012/1: move device tree mapping out of linear region") > > Reported-by: Guillaume Tucker > > Signed-off-by: Ard Biesheuvel > > That's a good catch! > Reviewed-by: Linus Walleij > I have dropped this into rmk's patch system as 9027/1. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel