From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F79FC43334 for ; Tue, 7 Jun 2022 12:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bxd3UtGHOe+gxG5PtoBZMKBIKVdIF7UEmUhUHbmZxZI=; b=1SXfIzHNgqQLD0 sudppRPmmbTvLPVdIlOclMG3iUy2HczEsstlTBg2niwkVh0NQUQwc4hLQmjo4kSssMlmcsHqZZSeT /bVO8KuavQUs/DKm3AtY1ZtoGGR4D0nDx3vltxx1XtwxXhiqOLMDCRYwbImrTimERMOwUkD6ngI+Q 3fDmvjBoBF6TBmQFcJtBPsl+34gDVcf32HQ2JkhUTOIevChVzYwZ3O5a2vdEZFK2rm6Rq0Ytt8qmQ HjKCuW6CUBAC4nINmDS6yRX8cC691XCPw3ra+HGPeSeBFCx5klHTSrHcmCfo/oS2JADIEeRTAvDQ2 9ywNVg5Z06U7o91aNnuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyXw3-007CpW-0X; Tue, 07 Jun 2022 12:03:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyXvz-007Cob-RU for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 12:03:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB3C061716 for ; Tue, 7 Jun 2022 12:03:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B352C3411F for ; Tue, 7 Jun 2022 12:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654603422; bh=+ViRAfXAe9W+pLFYqjFQr2b/AEjKHxY3Y1+jWdYOufg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pqOU2pPhklQwJz0Z/EoBa0lQrrDHdoki9xPpyrdpmzoXyynoAlHNBw1w4SxSYHh02 Fqq3wdHGuZzg681gww7k/isQs1kIuREIAB5FcQNlhMpBzn/W6MM4u5v06ArFTB1KFT 6SXJqu+xgdVr9TlDF6TKOz/mJ7dufoho43HUoSKD7Mdf70bJX90x9namivlvhq21on bZNEMJaxfjzvhKysdY75eV1utwAFwCsBDIIe1wR+AZFTmHocdvmPmdnHXkKkXaUA2W LVjqL06Y6gOam7w7yl2F1ZdGgQUCGPrZj81+C7m71YbhDS/w1/gwTWgjDLlSXRLgnE XXzVraXkrTjGg== Received: by mail-oi1-f170.google.com with SMTP id h188so23615604oia.2 for ; Tue, 07 Jun 2022 05:03:42 -0700 (PDT) X-Gm-Message-State: AOAM532OXX4tjN9109MIIzd1CDiWueRyG491ycfjOqU69dK9jtbNfpoq vERBihvCbMFyaIRXrpOSJfETXmJ4SSH9AurP39M= X-Google-Smtp-Source: ABdhPJx3SWtWiz0d+VOvxLV/8oPe56jPNbjtsEb8F5xQ5NUQpVY5G9RWit6TW/YCxZgdePdTkKx5Tz5VkjxHHVym7q0= X-Received: by 2002:a05:6808:f88:b0:32b:d10f:cc6b with SMTP id o8-20020a0568080f8800b0032bd10fcc6bmr31929999oiw.228.1654603421508; Tue, 07 Jun 2022 05:03:41 -0700 (PDT) MIME-Version: 1.0 References: <20220607100210.683136-1-Jason@zx2c4.com> In-Reply-To: From: Ard Biesheuvel Date: Tue, 7 Jun 2022 14:03:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] random: do not use jump labels before they are initialized To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , Catalin Marinas , Russell King , Arnd Bergmann , Phil Elwell X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_050343_962711_4BF54359 X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 7 Jun 2022 at 13:35, Jason A. Donenfeld wrote: > > Hi Ard, > > On Tue, Jun 07, 2022 at 01:10:52PM +0200, Ard Biesheuvel wrote: > > Fair enough. What I would like is to remove the need to play around > > with the placement of jump_label_init() across architectures. Jump > > labels are fundamentally a performance optimization, so unless you can > > explain how setting it as early as possible makes a material > > difference, performance or otherwise, I really think we should pursue > > a solution that does the static key manipulation at some later time. > > Alright. It sounds like Catalin also prefers the same. This seems simple > enough with minimal downsides: https://lore.kernel.org/lkml/20220607113238.769088-1-Jason@zx2c4.com/ > That looks simple enough. Do we risk causing any boot stalls due to the crediting being deferred? Or new warnings about randomness being used before CRNG is ready? > So maybe we should just go that route. > It is not my preferred approach, but I can live with it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel