From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EB9C2D0A3 for ; Wed, 4 Nov 2020 19:14:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35C36206E3 for ; Wed, 4 Nov 2020 19:14:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JGf2S3e8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="amq1iOZQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35C36206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JG/5M1P6JRngr+3WyTfoC0UX0BrWxcI8i3MV/kjONUg=; b=JGf2S3e88+hVJYbcLp1t/s/6s eEW26ApNDUjCPqLi3pQxrkmDiyx09C/fY+ZBKGm0Ro02EeHQBda/XNyv53OoP6Yd4A4Ni8/2tT+Nx dFrm5xbNJcCITznlq6vYGBpa9qruWSOse1pM+56zRctbbzNNjrDZMKUOqOctTyiHYbG2EK4sQ1WQ1 VJLXy7pG3wonO3GYc7HzV4ehAcE5zLxzR26jJvyjhvlAxfjpaKh6bVfm48yQ6sERvMbWdTRx+GtJs RGVSjNJevv0s9r50qRnExus3P7Vv7u2ZT0fuvoDMqVaCrNxVyRDCIgNny75Q03ex68kolB3i4f+B7 meYczHKiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaODC-00063f-Js; Wed, 04 Nov 2020 19:12:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaOD8-00061x-IJ for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 19:12:47 +0000 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9AF2F206DB for ; Wed, 4 Nov 2020 19:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604517165; bh=x8Z4vI5xusCxbaiv1HIPRu+C1+7Dtw3P0cGlUFk9NAA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=amq1iOZQ53SdR/nox/ircKzv/Rwc+Pug3b3dVZ/1ItwS0FZ5KuR339betQWhUYSp7 cGoGD8NrDD9Yem9Zdpt6NePnPljY5agQ3JpxPm/SYLlb36MOTtzSDwkQiUt/83k+e3 f08hLXgwDvQ/8gqK51mllN7oKipkRI28QLkrEfgQ= Received: by mail-oo1-f42.google.com with SMTP id z14so5332196oom.10 for ; Wed, 04 Nov 2020 11:12:45 -0800 (PST) X-Gm-Message-State: AOAM533hBCSPE6LQ1LgoSSEGTN+uj6GImyrt8Oa3AP7Y0Ph3/IdSo8A/ AHUgAjYXmmsZ5U+jK0Y55cGzWAR02+iXBmRF/Po= X-Google-Smtp-Source: ABdhPJxIEicSfXra/TnAUXm7t8vezHD9GOpBWLj9M/qAj91RrOwE7DixamCjJPcC3jCGJytqI3LVl+Z5spHnaW6OICk= X-Received: by 2002:a4a:9806:: with SMTP id y6mr19928543ooi.45.1604517164848; Wed, 04 Nov 2020 11:12:44 -0800 (PST) MIME-Version: 1.0 References: <20201102223800.12181-1-ardb@kernel.org> <2fd203414ba8ac3349f0109fea633838b4e04f05.camel@linux.ibm.com> In-Reply-To: From: Ard Biesheuvel Date: Wed, 4 Nov 2020 20:12:33 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/3] wire up IMA secure boot for arm64 To: Mimi Zohar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_141246_793769_456F1B79 X-CRM114-Status: GOOD ( 30.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lee, Chun-Yi" , linux-efi , Dmitry Kasatkin , X86 ML , James Morris , Chester Lin , Catalin Marinas , linux-integrity , Will Deacon , Linux ARM , "Serge E. Hallyn" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 4 Nov 2020 at 20:03, Mimi Zohar wrote: > > On Wed, 2020-11-04 at 19:50 +0100, Ard Biesheuvel wrote: > > On Wed, 4 Nov 2020 at 19:20, Mimi Zohar wrote: > > > > > > Hi Ard, Chester, > > > > > > On Mon, 2020-11-02 at 23:37 +0100, Ard Biesheuvel wrote: > > > > This is a follow-up to Chester's series [0] to enable IMA to the secure > > > > boot state of arm64 platforms, which is EFI based. > > > > > > > > This v4 implements the changes I suggested to Chester, in particular: > > > > - disregard MokSbState when factoring out secure boot mode discovery > > > > - turn the x86 IMA arch code into shared code for all architectures. > > > > > > > > This reduces the final patch to a one liner enabling a Kconfig option > > > > for arm64 when EFI is enabled. > > > > > > > > Build tested only. > > > > > > Thank you! This patch set is now queued in the linux-integrity next- > > > integrity-testing branch. > > > > > > > I don't mind per se, but this touches a number of different trees, > > including x86 and arm64, and nobody has acked it yet. > > > > As far as the EFI tree is concerned, it looks like I should be able to > > avoid any conflicts with other stuff that is in flight, and if not, we > > can always use your branch up until the last patch in this serires as > > a shared tag (assuming you won't rebase it). > > The next-integrity-testing branch is just a place holder waiting for > additional tags. I've reviewed and tested the patch set on x86. Based > on the secure boot status and how the kernel is configured, the > appropriate policy rules are enabled. Similarly the IMA appraise mode > (ima_appraise=) is working properly. I have not tested on arm64. > > I do not have a problem with this patch set being upstream via EFI. > Ah right. That is probably better, as EFI goes via the x86 tree, and I work closely with the arm64 maintainers on other things as well. Please let me know once you are ready to ack this from IMA pov, and I will carry it further. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel