From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B45C388F9 for ; Fri, 13 Nov 2020 06:15:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C63F921D7F for ; Fri, 13 Nov 2020 06:15:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ncn8qd5V"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ChctPHHs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C63F921D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FAkczFNmcHOjuXaRlfC1jBtiD6t/P/x3jCfLhqHEKlw=; b=Ncn8qd5VqHbqwRNXU8/zpjXV5 zNGxa9A37tXNN9KCLMoA31V/P7hnRLwlFaCbu0FFmZFKeRp2SFZ0wJUzd+Wga0Mzairwiv9hduYwS S1kjvC/7kngr+Po5ys1mv50E6Ez9zvMlSQyG0bbWp3Ow/ZXL7REDHoYBt4TyKNnRrVIkIAvBFciU4 KF7Z44D8OLwVfEtWQaRm7pzTS7889ZPGM6tNFa1so2RbxY1/LRGIlLOpgVudY24w0LPrpXFfJYa1n 9rNjW8FN7Z7MjRZCbOGUSWVWOMJMeByRZB2xsgiL0PXWtsZbp8soF11flO6bJNaO7f1DLOzEEJ0ev NhxFhxV8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdSMa-0008Hb-57; Fri, 13 Nov 2020 06:15:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdSMX-0008H6-46 for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 06:15:10 +0000 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CEA24221E9 for ; Fri, 13 Nov 2020 06:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605248107; bh=COucHtcUZQ0vJywCoLOJkGiDhDKyMfAcEFLg8kgnoZg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ChctPHHsmcunGnudF0TCaPfmjV9W+bS5YeD1ujkUI01dK8XTL1/Ib6/eGi7J/cYMA ncesEJQ1xYkTRDdvPVwkJ1/byul4PqQM6B+2MFeVv1K4aw+VUgDes7Pw+Xt2YbiS8O 2V1k+H9qgpy4RFSobkMKSL8RKhSCh7qtbcGr+NNE= Received: by mail-oi1-f171.google.com with SMTP id q206so9258445oif.13 for ; Thu, 12 Nov 2020 22:15:07 -0800 (PST) X-Gm-Message-State: AOAM530/Q//Wmo/G3zvE+6iB8o9kLADUY7En+JOrZh3mhSZ6PMlTsFIT yC36zKbMhYUb6OGYdrA2+6zELPKgxE4Ff7kB+YE= X-Google-Smtp-Source: ABdhPJxsCUdwI/hg+4gvJgkWTuSi9ICNr4zk0HFK3LkMV1aHISoOKpsSLBrB0ai2VizV3pzan1sxxRn/Xcup4YJu9Ws= X-Received: by 2002:aca:c60c:: with SMTP id w12mr489296oif.174.1605248107101; Thu, 12 Nov 2020 22:15:07 -0800 (PST) MIME-Version: 1.0 References: <20201014081857.3288-1-ardb@kernel.org> <160503561804.1015659.16599672230432576934.b4-ty@arm.com> <20201112092558.GC29613@gaia> <2f0d9bc5-6288-7388-ff10-97198dabac6f@arm.com> In-Reply-To: <2f0d9bc5-6288-7388-ff10-97198dabac6f@arm.com> From: Ard Biesheuvel Date: Fri, 13 Nov 2020 07:14:54 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: mm: account for hotplug memory when randomizing the linear region To: Anshuman Khandual X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_011509_335141_9D599062 X-CRM114-Status: GOOD ( 33.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , gshan@redhat.com, Steve Capper , Catalin Marinas , David Hildenbrand , Linux Kernel Mailing List , Steven Price , Mark Brown , Marc Zyngier , Will Deacon , Linux ARM , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 13 Nov 2020 at 04:16, Anshuman Khandual wrote: > > > > On 11/12/20 2:55 PM, Catalin Marinas wrote: > > Hi Anshuman, > > > > On Wed, Nov 11, 2020 at 09:18:56AM +0530, Anshuman Khandual wrote: > >> On 11/11/20 12:44 AM, Catalin Marinas wrote: > >>> On Wed, 14 Oct 2020 10:18:57 +0200, Ard Biesheuvel wrote: > >>>> As a hardening measure, we currently randomize the placement of > >>>> physical memory inside the linear region when KASLR is in effect. > >>>> Since the random offset at which to place the available physical > >>>> memory inside the linear region is chosen early at boot, it is > >>>> based on the memblock description of memory, which does not cover > >>>> hotplug memory. The consequence of this is that the randomization > >>>> offset may be chosen such that any hotplugged memory located above > >>>> memblock_end_of_DRAM() that appears later is pushed off the end of > >>>> the linear region, where it cannot be accessed. > >>>> > >>>> [...] > >>> > >>> Applied to arm64 (for-next/mem-hotplug), thanks! > >>> > >>> [1/1] arm64: mm: account for hotplug memory when randomizing the linear region > >>> https://git.kernel.org/arm64/c/97d6786e0669 > >> > >> Got delayed and never made here in time, sorry about that. Nonetheless, > >> I have got something working with respect to the generic mechanism that > >> David Hildenbrand had asked for earlier. > >> > >> https://patchwork.kernel.org/project/linux-arm-kernel/patch/1600332402-30123-1-git-send-email-anshuman.khandual@arm.com/ > > > > There was a lot of discussion around this patch but I haven't seen any > > new version posted. > > Just posted before some time. > > https://lore.kernel.org/linux-arm-kernel/1605236574-14636-1-git-send-email-anshuman.khandual@arm.com/ > You failed to cc me on that patch. The logic looks correct but please fix up the comment block: - PAGE_END is no longer defined in terms of vabits_actual - bits [51..48] are not ignored by the MMU Actually, I think the entire second paragraph of that comment block can be dropped. Please also fix up the coding style: - put && at the end of the first line - drop the redundant parens - fix the indentation > > > >> I am wondering if we could instead consider merging the above patch with > >> a small change that Ard had pointed out earlier [1], I will send out a > >> revision if required. > > > > If your patch fixes the randomisation issue that Ard addressed, I'm > > happy to replace that with your patch. But please post a new version and > > get some acks in place from the parties involved in the discussion. > > The above patch is not a replacement for Ard's randomization patch here but > rather complements it. Hence both these patches should be considered, which > will make memory hotplug better on the platform. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel