From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E31DDC433F5 for ; Thu, 10 Feb 2022 09:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8RMDDKAz5Ul+u+T3MWbiCPErBMhbjtQO9v1vdyMWtcE=; b=Muo9J5SfuqaUOT eV6/Q13MladShOHoxxICt1aua4a017gBx83VQjpp4pHMGwsVJRy772R4P5x84kkJLRuyEr+5qlPxx G2eXF2FacXs6wxsGwmomr8w7MlUbLY4xIqSnzx8VjNlaskmwjo3E1OZfI2gSSMhu/WzbrAsUpCLJw NHWKtPGvJMb8Y8Ofv0A8obzKBeo6Gxd1qe4uMW8yQ5MCc++aGk/X7SmnrPZqzQfYsCWdWTSK0gLJv qZOOQ33VWfyVLwRGtdFw36qQvUYN3AncOR33+udBzscxhygDMBFSlkNChTdOyJXENmgj1YqgWduzZ lfZlf6CBADZSLQBLwitw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI5Ul-003F8X-IW; Thu, 10 Feb 2022 09:12:07 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI5Ug-003F6r-Ae for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 09:12:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6B7E9B8243F for ; Thu, 10 Feb 2022 09:12:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33ADBC340F2 for ; Thu, 10 Feb 2022 09:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644484319; bh=JedsB1JwXMEe8yGaX/BRWqTZv9TyfpT/Y68puVJHs/o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VF3q86MjV6MKq4r9qsD1rtfzgmwOhffpMjSWJ+EQuSRNZKZn96yOdYHRi8qOGKVZo WQdV5jkduwNFX+iPKGunGKIuHmw2vT/JAvwJBzTepl5t311clPn0vv4tBnQ44Qakeo OqW+tJ+kWuUBzZsKwJp2no1l/ZeKL5z2Fyn8ifO8fkPH7YlHUWc95sTSgkGo8lGIRn 3UhrvlgBLj2+HE948UWlskfcH8EQk7bFuljZZp+20NsMvY5WtxA5lRht+Agkc7onWR D+/W/+uaIuKRv2k2Hh6eBMaGIO2c+3qi+AlZHTWGKu+PmJXMjLTtuKORRzjp+ozAJV WDwYpQ/SZZV1w== Received: by mail-wr1-f51.google.com with SMTP id k18so8273972wrg.11 for ; Thu, 10 Feb 2022 01:11:59 -0800 (PST) X-Gm-Message-State: AOAM5301Dco2h85FhBWCRzpEbnMYDgSP+YA0UILHIa6/wWZcvknL2gwF J1cdfKcja+bbOiRSvN021iLSQsgGucfvvQiccKc= X-Google-Smtp-Source: ABdhPJyCE9WauEk8svEa5nQ4zRYMLQZlXKjxclYSXVI9ENtdYdFhWHJ6K5eHC4aW0EOR7LXwJnDCKn9OyF3EktyQeN4= X-Received: by 2002:a05:6000:1b88:: with SMTP id r8mr5675117wru.447.1644484317472; Thu, 10 Feb 2022 01:11:57 -0800 (PST) MIME-Version: 1.0 References: <1644453141-1181-1-git-send-email-victor.erminpour@oracle.com> In-Reply-To: <1644453141-1181-1-git-send-email-victor.erminpour@oracle.com> From: Ard Biesheuvel Date: Thu, 10 Feb 2022 10:11:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ACPI/IORT: Fix GCC 12 warning To: Victor Erminpour Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux ARM , Linux Kernel Mailing List , trivial@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_011202_686642_DF422605 X-CRM114-Status: GOOD ( 22.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Feb 2022 at 01:34, Victor Erminpour wrote: > > When building with automatic stack variable initialization, GCC 12 > complains about variables defined outside of switch case statements. > Move the variable into the case that uses it, which silences the warning: > > ./drivers/acpi/arm64/iort.c:1670:59: error: statement will never be executed [-Werror=switch-unreachable] > 1670 | struct acpi_iort_named_component *ncomp; > | ^~~~~ > > Signed-off-by: Victor Erminpour GCC 12 is not released yet, and this is clearly a compiler bug (a declaration is not a statement, and the hidden offending statement [the zero-init] is emitted by the compiler itself), so please report this to the GCC folks instead. > --- > drivers/acpi/arm64/iort.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 3b23fb775ac4..5c5d2e56d756 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -1645,7 +1645,7 @@ void __init acpi_iort_init(void) > */ > phys_addr_t __init acpi_iort_dma_get_max_cpu_address(void) > { > - phys_addr_t limit = PHYS_ADDR_MAX; > + phys_addr_t local_limit, limit = PHYS_ADDR_MAX; > struct acpi_iort_node *node, *end; > struct acpi_table_iort *iort; > acpi_status status; > @@ -1667,17 +1667,15 @@ phys_addr_t __init acpi_iort_dma_get_max_cpu_address(void) > break; > > switch (node->type) { > - struct acpi_iort_named_component *ncomp; > - struct acpi_iort_root_complex *rc; > - phys_addr_t local_limit; > - > case ACPI_IORT_NODE_NAMED_COMPONENT: > + struct acpi_iort_named_component *ncomp; > ncomp = (struct acpi_iort_named_component *)node->node_data; > local_limit = DMA_BIT_MASK(ncomp->memory_address_limit); > limit = min_not_zero(limit, local_limit); > break; > > case ACPI_IORT_NODE_PCI_ROOT_COMPLEX: > + struct acpi_iort_root_complex *rc; > if (node->revision < 1) > break; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel