From: zhangfei.gao@gmail.com (zhangfei gao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] dmaengine: add interface of dma_get_slave_channel
Date: Tue, 20 Aug 2013 15:58:41 +0800 [thread overview]
Message-ID: <CAMj5Bkhq=kvfpYiMX0de3PBaAzOUfgPVELamaeMAWhHaoDgc8g@mail.gmail.com> (raw)
In-Reply-To: <20130819052516.GT32147@intel.com>
> No, this is not the right approach.
>
> When patch is applied and you find an issue you fix the issue. I have already
> pushed and merged this. So removing is a bad idea.
> you provide a fix for this miss.
>
> Also for this you need to give due credit to Dan (reporter). That is how the
> process works.
>
> Anyway I have applied the below fix and will push it out.
>
> ---
> dmaengine: fix - error: potential NULL dereference 'chan'
>
> commit 7bb587f4 "dmaengine: add interface of dma_get_slave_channel" introduced
> the above error so fix it
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Suggested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Thanks Vinod for the kind education.
Understand, will take care next time.
BTW, it is strange I do not see such compile warning here :(
next prev parent reply other threads:[~2013-08-20 7:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 7:02 [PATCH v3 0/2] dmaengine: add k3dma Zhangfei Gao
2013-08-15 7:02 ` [PATCH v3 1/2] dmaengine: add interface of dma_get_slave_channel Zhangfei Gao
2013-08-19 5:25 ` Vinod Koul
2013-08-20 7:58 ` zhangfei gao [this message]
2013-08-20 8:13 ` Dan Carpenter
2013-08-20 8:22 ` Vinod Koul
2013-08-27 2:04 ` zhangfei
2013-09-03 20:39 ` Dan Carpenter
2013-08-20 8:22 ` Vinod Koul
2013-08-15 7:02 ` [PATCH v3 2/2] dmaengine: Add hisilicon k3 DMA engine driver Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj5Bkhq=kvfpYiMX0de3PBaAzOUfgPVELamaeMAWhHaoDgc8g@mail.gmail.com' \
--to=zhangfei.gao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).