From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CE7C433E2 for ; Fri, 28 Aug 2020 18:18:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD8CA2098B for ; Fri, 28 Aug 2020 18:18:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vFXxh/6V"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="dqqps0/H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD8CA2098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hN/soDxDa9eVd7A6STm9jGOb+PNRcbYUk+2nR/PKH9c=; b=vFXxh/6VNI5g92QBJNVoPkYau wF3zJOCnevH40V3bA5lfHpjCDYasiMbMJuYG/QhfndtC+aSbd7NloCuCKQY2ZSZodghZDahEZ90DR kxsaRr9nxfw3ssWrQz7+F6HqK6qHpDbgf7afuxkalVO0z/1qEZE36lG6JXuIzpvFZpxSd7oO5719o D8MD0YJvOdjFPUkWXCf8ELJFsjECYqobmfLegVsMu4OweYJj4SXsoJVAmdWdXyNs/gz7cEz2RDURa Wxs1hBBBZvKRkhOtuJY/fPAd0/GQgNxd8RhjBwVFAldMOeyFlOZV6ywl1NZ26DIanYRLVQbK/MFH9 COhqNxWJA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBiwO-00063E-Bj; Fri, 28 Aug 2020 18:17:32 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBiwK-00060f-9z for linux-arm-kernel@lists.infradead.org; Fri, 28 Aug 2020 18:17:29 +0000 Received: by mail-ej1-x641.google.com with SMTP id m22so320895eje.10 for ; Fri, 28 Aug 2020 11:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x4Tkx5cvTIZX2IKIPG2Xun4vWEN6aBBz7OiP1w4AdpE=; b=dqqps0/Ht78gHt72hdwH44ctuWKIh0vfLimwd8lmZDLDhybUKNTwcHIrsVXX4g6NpM hmeTQJWVVkcdLJzNNryqU6eQIqBorKRjXReEoEqjH0cUbZfs27clSs0vPprnDmwCTKCG NJfoyggS/2btQJbU3OWTRQqP86VZwwpBUoWmyaF681lObsE9LJhPtcxc/VVhg2oTBK2G VELw6QmLXvaA7ApYO15N/5jhFZYTJdaKh/dRChfEvhYtnVrbaoxAdTLB8MH0SQQWnYXr CvV7MDtfeNfu9Ee1N/v5VZ+sMUiC5/tOjijtDtj76/mmEnRDsbOkMaMcm19mVEPkJ7Dd DGFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x4Tkx5cvTIZX2IKIPG2Xun4vWEN6aBBz7OiP1w4AdpE=; b=RfxStE3rdQ/FNjHNfgy6TXNVb/UrKWuQZWYU5yUdwfok1qssidH1VTgTl87sQyECcl Hd5Xb8VZRv77geK+JYxh3KMgcMq2z1JYjVbtb3SwwRFbEbsKb+Mjb4cXOk5ah07uE9SP UdjDRww87fNr7vhqMreaLHghIBXayt/ze5ITiZSHHBtYm/q8i0uohewDPLxo3NPdyEDK sYHEkxV/BwiEtOg3tDR4wK7TYgzbyu5sgUY53BRQzkb+6fIp3Bt9Az0UZF1s2hrgA8s7 AG/uwNWkkzrojJQ8BmpunZ3oA5MqY/EArsgm8iwJ3vF+D8Bu/2NXKwATmRG0A6Egr863 /rLw== X-Gm-Message-State: AOAM533c7yXylfHhWoSqSmjgUU00P51lpTvEunvilYfWN4hSLQaX9h9B qXugP3GrddjBntXnPlE1oCxC95Am6dK2bggIfU1u5w== X-Google-Smtp-Source: ABdhPJwimNyQ/vmnIbLQ7RMLnx5UNXL4atJarDdIdwe+1NmMbYKqcl3QjEyT4WW1CDJUei4LJtKw9jcLLDu5k7e5dSw= X-Received: by 2002:a17:906:d8ca:: with SMTP id re10mr3133999ejb.382.1598638645348; Fri, 28 Aug 2020 11:17:25 -0700 (PDT) MIME-Version: 1.0 References: <20200827200827.26462-1-krzk@kernel.org> In-Reply-To: <20200827200827.26462-1-krzk@kernel.org> From: Bartosz Golaszewski Date: Fri, 28 Aug 2020 20:17:14 +0200 Message-ID: Subject: Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200828_141728_490615_664BFCD3 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Scott Branden , Kevin Hilman , Ray Jui , Linus Walleij , Santosh Shilimkar , Michal Simek , LKML , linux-gpio , Grygorii Strashko , bcm-kernel-feedback-list@broadcom.com, Keerthy , Linux-OMAP , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 27, 2020 at 10:08 PM Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpio/gpio-bcm-kona.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c > index cf3687a7925f..1e6b427f2c4a 100644 > --- a/drivers/gpio/gpio-bcm-kona.c > +++ b/drivers/gpio/gpio-bcm-kona.c > @@ -590,10 +590,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) > dev_err(dev, "Couldn't determine # GPIO banks\n"); > return -ENOENT; > } else if (ret < 0) { > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n", > - ERR_PTR(ret)); > - return ret; > + return dev_err_probe(dev, ret, "Couldn't determine GPIO banks\n"); > } > kona_gpio->num_bank = ret; > > -- > 2.17.1 > Queued the entire series with all the tags, thanks! Bartosz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel