From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18027C2B9F7 for ; Wed, 26 May 2021 08:20:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA089613E1 for ; Wed, 26 May 2021 08:20:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA089613E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vp7IwAo2N27jMgBzlYO6BINLwQE0tq4sYG6ySPCHef0=; b=Dqct/imjOL1vqs Phvq0ocDslPDevFilTIfjix224opNx8dV9bThyfKs2rz004ia39hTx/MHdzjeoM2Ja3DZ33NROJON i0fhXiiz5koXHdA3w3QwMeoWColtvhtfh9DHOCI+6IJzLOIICfK9VP/tmVcDHq/6k97KH6+cEri1n VfCLjHEuUYk4A0GrY+PFT3emApiXl56A5q5+gUXothOvBpmzNMahSAp2LIL9y4tJGW5jhrX62KATO sdxHP5cw66/Kg70Ft+wTS6xlDoADVtSDhEQKxsai6JxGpP7RvlHQ49+P95gnBPrWh1Rh/HeLgIdjA oyDkPFJv2mkKoRVBj+vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llokX-00CNqP-BS; Wed, 26 May 2021 08:18:45 +0000 Received: from mail-vs1-f47.google.com ([209.85.217.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llokT-00CNof-CV for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 08:18:42 +0000 Received: by mail-vs1-f47.google.com with SMTP id f9so276684vsp.6 for ; Wed, 26 May 2021 01:18:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cwJrjJPn4XdJtdaNHc/uwJ41Erytueup9SA7gWbLwLc=; b=tGHmwXlVJ9HV7Yv6U80pAyXsmXsPbaztMe6ky+dML+HOuL/xXUnb4tF/oxymHQRRP4 +gcTAgej294eMM0WBvR3UXobk3wc0rXXYkrAzrWUmNOOcUQCrSicYw/BRnMQANHyFxj7 1DdrL2KOtM0CXSE6UU+N1wd5l18QiwPt9I9nuGRkv0XGuKY5mVE0pJTly6eVv9/vqcRX 2F82jZcUit2Y11ZbKIfNHtpr7db+dYll5J26u3KHwHgobrmcUaFeSE1RXQnRbgk7CrGk PvLhpB6xkIsg0U9nWlncS3GBJnbVEtXnsqXa/fYvW5Kgq1noD37yN8ar/vRQ9diOPKsn Jt/g== X-Gm-Message-State: AOAM532ALY0ljiEahgcytFsWelsjF8MwTTwtQSqhoPi0SKLgop6ucy1d 1Y5rniTQsi73kphYo8KrwL8bRIUvOyui1I+09I0= X-Google-Smtp-Source: ABdhPJyBP43fy0z/xLr24CBnaFxqMibw4+PtPqA/CPHen7oIzefuWsMGVqm5mGd8u6JPJ0dQP9MmoI2MjgM94cpGp3U= X-Received: by 2002:a67:3c2:: with SMTP id 185mr30138437vsd.42.1622017119229; Wed, 26 May 2021 01:18:39 -0700 (PDT) MIME-Version: 1.0 References: <20210330145430.996981-1-maz@kernel.org> <20210330145430.996981-8-maz@kernel.org> <6c522f8116f54fa6f23a2d217d966c5a@kernel.org> <8735u9x6sb.wl-maz@kernel.org> In-Reply-To: <8735u9x6sb.wl-maz@kernel.org> From: Geert Uytterhoeven Date: Wed, 26 May 2021 10:18:27 +0200 Message-ID: Subject: Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 To: Marc Zyngier Cc: jianyong.wu@arm.com, netdev , Yangbo Lu , John Stultz , Thomas Gleixner , Paolo Bonzini , seanjc@google.com, Richard Cochran , Mark Rutland , Will Deacon , Suzuki K Poulose , Andre Przywara , Steven Price , Lorenzo Pieralisi , Sudeep Holla , Linux Kernel Mailing List , Linux ARM , kvmarm@lists.cs.columbia.edu, KVM list , Steve Capper , justin.he@arm.com, Android Kernel Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_011841_453152_B12EE049 X-CRM114-Status: GOOD ( 34.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On Wed, May 26, 2021 at 10:01 AM Marc Zyngier wrote: > On Wed, 26 May 2021 08:52:42 +0100, > Geert Uytterhoeven wrote: > > On Tue, May 11, 2021 at 11:13 AM Marc Zyngier wrote: > > > On 2021-05-11 10:07, Geert Uytterhoeven wrote: > > > > On Tue, Mar 30, 2021 at 4:56 PM Marc Zyngier wrote: > > > >> From: Jianyong Wu > > > > > > > >> --- a/drivers/ptp/Kconfig > > > >> +++ b/drivers/ptp/Kconfig > > > >> @@ -108,7 +108,7 @@ config PTP_1588_CLOCK_PCH > > > >> config PTP_1588_CLOCK_KVM > > > >> tristate "KVM virtual PTP clock" > > > >> depends on PTP_1588_CLOCK > > > >> - depends on KVM_GUEST && X86 > > > >> + depends on (KVM_GUEST && X86) || (HAVE_ARM_SMCCC_DISCOVERY && > > > >> ARM_ARCH_TIMER) > > > > > > > > Why does this not depend on KVM_GUEST on ARM? > > > > I.e. shouldn't the dependency be: > > > > > > > > KVM_GUEST && (X86 || (HAVE_ARM_SMCCC_DISCOVERY && ARM_ARCH_TIMER)) > > > > > > > > ? > > > > > > arm/arm64 do not select KVM_GUEST. Any kernel can be used for a guest, > > > and KVM/arm64 doesn't know about this configuration symbol. > > > > OK. > > > > Does PTP_1588_CLOCK_KVM need to default to yes? > > Perhaps only on X86, to maintain the status quo? > > I think I don't really understand the problem you are trying to > solve. Is it that 'make oldconfig' now asks you about this new driver? > Why is that an issue? My first "problem" was that it asked about this new driver on arm/arm64, while I assumed there were some missing dependencies (configuring a kernel should not ask useless questions). That turned out to be a wrong assumption, so there is no such problem here. The second problem is "default y": code that is not critical should not be enabled by default. Hence my last question. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel