From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53FE1C54EED for ; Mon, 30 Jan 2023 08:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G/Sp912ZGiSs8SqZyJ8A3MAevEp93iBU5Jg6rc/26No=; b=oyvLBPZCIZDQ2j KiIqXYdhvm9MHb2ajiNw0on3aGHkPl/gL1lioDjBrEIRF4PCCrJWgiciH/9jApWjCNlha1Y4UYNTv OJdX1Z/p3JwmDRkCoLAO+hSxxXwUq4vAwQgl1U3zDrpxarNE/Iwj7woAlTmsWGrMewWQPXyBsqJTK WpgCAQw/g0Zb3lhCI3bCvlJEwypFUMxxCywVX+3MMhJMg92bkKuaRvsQO5vQ8OuvT1Hs0nB0yq/Wu dDXN3dWGDSXuj3t6SKNWjV3XuqDMaBvxUiHht5CWhwTUylhD/OFzs+sFo78HLGomlZRiIW8YqnOr3 b4mgUQ4l2HV+Dv2JEVzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMPlq-002gNX-8F; Mon, 30 Jan 2023 08:44:10 +0000 Received: from mail-qt1-f171.google.com ([209.85.160.171]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMPkl-002gJj-KX for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 08:43:05 +0000 Received: by mail-qt1-f171.google.com with SMTP id w11so3631889qtc.3 for ; Mon, 30 Jan 2023 00:43:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P6jHULr0UQaDIQzU8hyuuqTklxOoQZdGiuLMsSkhuWs=; b=bIRjryJlVoVf1tJJfAfSgGT4qK4Me4qGIqOCUq4I4GBkdnqr/mxJJDTLZ/vvkWjOmF Z0rPjQb7dXcbvGBHZ1WBxgNozaJf4vtNHkTqnpk/n5JJdb5J/yNvVCNTzP4lmwRbvnLL fdH5TzwTjDyFDYjAXRmnd9OrdtBnTCfgnD5Q1fKVOgWHQD55EEVLFclkze/wJZbEPcQ5 BLE4dtFz8m+DM7KGrFUpZdhphuH3kKThITcGH8VsjiPscI7ji5SLnwjbofTT172lbqbV Dk6n/PeZw+2cLkAs2SutdT0+jucnVoIw0YwCZYnIfZH5tCubfSmyxt5d5kzfkgNi+m+L Uh4w== X-Gm-Message-State: AO0yUKXeCUX+TlarZD3m+eDiyA+sKIboV+xtfuURar4w7sORHWz1130Z lYZ9Zs4zG/PEw6/eilt2UZDVjGRK5AGwsA== X-Google-Smtp-Source: AK7set8DXaSqwnrdI7vVhdonTVoVljSq0LhuxBE20Sil7D1zPR8lDynnL/wQOWNkSkfjIcCBwiaMKA== X-Received: by 2002:a05:622a:352:b0:3b8:5057:376a with SMTP id r18-20020a05622a035200b003b85057376amr11542263qtw.66.1675068179819; Mon, 30 Jan 2023 00:42:59 -0800 (PST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com. [209.85.128.174]) by smtp.gmail.com with ESMTPSA id z20-20020ac84314000000b003b960aad697sm153707qtm.9.2023.01.30.00.42.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 00:42:59 -0800 (PST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-510476ee20aso42774927b3.3 for ; Mon, 30 Jan 2023 00:42:59 -0800 (PST) X-Received: by 2002:a25:37d4:0:b0:80b:8602:f3fe with SMTP id e203-20020a2537d4000000b0080b8602f3femr2897020yba.36.1675068168732; Mon, 30 Jan 2023 00:42:48 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 30 Jan 2023 09:42:37 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_004303_697157_69064B13 X-CRM114-Status: GOOD ( 38.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Saravana, On Sat, Jan 28, 2023 at 8:19 AM Saravana Kannan wrote: > On Fri, Jan 27, 2023 at 12:11 AM Geert Uytterhoeven > wrote: > > On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan wrote: > > > The OF_POPULATED flag was set to let fw_devlink know that the device > > > tree node will not have a struct device created for it. This information > > > is used by fw_devlink to avoid deferring the probe of consumers of this > > > device tree node. > > > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > > effect without using OF specific flags. This allows more generic code to > > > be written in driver core. > > > > > > Signed-off-by: Saravana Kannan > > > > Thanks for your patch! > > > > > --- a/drivers/soc/renesas/rcar-sysc.c > > > +++ b/drivers/soc/renesas/rcar-sysc.c > > > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > > > > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > > > if (!error) > > > - of_node_set_flag(np, OF_POPULATED); > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > As drivers/soc/renesas/rmobile-sysc.c is already using this method, > > it should work fine. > > > > Reviewed-by: Geert Uytterhoeven > > i.e. will queue in renesas-devel for v6.4. > > Thanks! Does that mean I should drop this from this series? If two > maintainers pick the same patch up, will it cause problems? I'm > eventually expecting this series to be picked up by Greg into > driver-core-next. Indeed. Patches for drivers/soc/renesas/ are supposed to go upstream through the renesas-devel and soc trees. This patch has no dependencies on anything else in the series (or vice versa), so there is no reason to deviate from that, and possibly cause conflicts later. BTW, I will convert to of_node_to_fwnode() while applying. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel