* [PATCH/RFT] arm64: dts: renesas: r8a77995-draak: Add MSIOF ch2 pins support
@ 2018-09-04 20:22 Yoshihiro Kaneko
2018-09-05 15:45 ` Geert Uytterhoeven
2018-09-06 9:18 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Yoshihiro Kaneko @ 2018-09-04 20:22 UTC (permalink / raw)
To: linux-arm-kernel
From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
This patch adds support for MSIOF ch2 pinctrl to use the LVDS Control
Connector (CN41) for the Draak board on the R8A77995 SoC.
Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[ykaneko0929 at gmail.com: deleted the unused reference to 'msiof_ref_clk']
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the devel branch of Simon Horman's renesas tree.
arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index a8e8f26..e60b1e4 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -135,6 +135,12 @@
function = "i2c1";
};
+ msiof2_pins: spi2 {
+ groups = "msiof2_clk", "msiof2_sync_b",
+ "msiof2_rxd", "msiof2_txd";
+ function = "msiof2";
+ };
+
pwm0_pins: pwm0 {
groups = "pwm0_c";
function = "pwm0";
@@ -371,3 +377,10 @@
};
};
};
+
+&msiof2 {
+ pinctrl-0 = <&msiof2_pins>;
+ pinctrl-names = "default";
+ /* In case of using this node, please enable this property */
+ /* status = "okay"; */
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH/RFT] arm64: dts: renesas: r8a77995-draak: Add MSIOF ch2 pins support
2018-09-04 20:22 [PATCH/RFT] arm64: dts: renesas: r8a77995-draak: Add MSIOF ch2 pins support Yoshihiro Kaneko
@ 2018-09-05 15:45 ` Geert Uytterhoeven
2018-09-06 9:18 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-09-05 15:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kaneko-san,
On Tue, Sep 4, 2018 at 10:22 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
>
> This patch adds support for MSIOF ch2 pinctrl to use the LVDS Control
> Connector (CN41) for the Draak board on the R8A77995 SoC.
>
> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [ykaneko0929 at gmail.com: deleted the unused reference to 'msiof_ref_clk']
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Minor nit below.
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -371,3 +377,10 @@
> };
> };
> };
> +
> +&msiof2 {
Please insert following alphabetical order.
> + pinctrl-0 = <&msiof2_pins>;
> + pinctrl-names = "default";
> + /* In case of using this node, please enable this property */
I think this deserves some explanation about CN41.
> + /* status = "okay"; */
> +};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH/RFT] arm64: dts: renesas: r8a77995-draak: Add MSIOF ch2 pins support
2018-09-04 20:22 [PATCH/RFT] arm64: dts: renesas: r8a77995-draak: Add MSIOF ch2 pins support Yoshihiro Kaneko
2018-09-05 15:45 ` Geert Uytterhoeven
@ 2018-09-06 9:18 ` Simon Horman
2018-09-06 9:26 ` Geert Uytterhoeven
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2018-09-06 9:18 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 05, 2018 at 05:22:07AM +0900, Yoshihiro Kaneko wrote:
> From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
>
> This patch adds support for MSIOF ch2 pinctrl to use the LVDS Control
> Connector (CN41) for the Draak board on the R8A77995 SoC.
>
> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [ykaneko0929 at gmail.com: deleted the unused reference to 'msiof_ref_clk']
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Hi Kaneko-san,
sorry about this but I think we should drop this patch as
it is my understanding that msiof2 is not used on the Draak board.
> ---
>
> This patch is based on the devel branch of Simon Horman's renesas tree.
>
> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> index a8e8f26..e60b1e4 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -135,6 +135,12 @@
> function = "i2c1";
> };
>
> + msiof2_pins: spi2 {
> + groups = "msiof2_clk", "msiof2_sync_b",
> + "msiof2_rxd", "msiof2_txd";
> + function = "msiof2";
> + };
> +
> pwm0_pins: pwm0 {
> groups = "pwm0_c";
> function = "pwm0";
> @@ -371,3 +377,10 @@
> };
> };
> };
> +
> +&msiof2 {
> + pinctrl-0 = <&msiof2_pins>;
> + pinctrl-names = "default";
> + /* In case of using this node, please enable this property */
> + /* status = "okay"; */
> +};
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH/RFT] arm64: dts: renesas: r8a77995-draak: Add MSIOF ch2 pins support
2018-09-06 9:18 ` Simon Horman
@ 2018-09-06 9:26 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-09-06 9:26 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Thu, Sep 6, 2018 at 11:18 AM Simon Horman <horms@verge.net.au> wrote:
> On Wed, Sep 05, 2018 at 05:22:07AM +0900, Yoshihiro Kaneko wrote:
> > From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
> >
> > This patch adds support for MSIOF ch2 pinctrl to use the LVDS Control
> > Connector (CN41) for the Draak board on the R8A77995 SoC.
> >
> > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > [ykaneko0929 at gmail.com: deleted the unused reference to 'msiof_ref_clk']
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>
> Hi Kaneko-san,
>
> sorry about this but I think we should drop this patch as
> it is my understanding that msiof2 is not used on the Draak board.
The connector is described in the Hardware Manual as "LVDS CONT connector"
in the LVDS chaper, but it is not clear to me what exactly is supposed to
be connected to it, and how standard it is.
Laurent: do you know more?
Note that Ebisu has the same connector, but the signals are shared with
SW4, making them mutually exclusive.
The Ebisu Hardware Manual does mention the connector, but not in the
Display Output (LVDS) chapter.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-06 9:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-04 20:22 [PATCH/RFT] arm64: dts: renesas: r8a77995-draak: Add MSIOF ch2 pins support Yoshihiro Kaneko
2018-09-05 15:45 ` Geert Uytterhoeven
2018-09-06 9:18 ` Simon Horman
2018-09-06 9:26 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).