From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E970FC43334 for ; Tue, 14 Jun 2022 07:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xumR/dIjZ3syPHNUFH4dIe9QgQRq1CMbC9WjOTtsta0=; b=YdysFiwCWIIwJD U4AqSPZLeW6qeYt6iGaxjHaWgqOFCpyT2iFXTKte2owqPjHeITUIPQw7oDHBRWPSSy/dVgFR8FP95 vFPI+7sqn3MyG/dDGfSvJUQBlUbpf+mCocFz83rfftaF78cR6qXWkgcC3yEKfv0w3kb5pVrHjogW8 CvAB8XL/X5nDnvz8mTBeMoRb6jtDj5ckWXaSquxJ+J4QHe/NqPwyj8laX8jixCfM9I9ibrqUYdiOI Q+Xgw5uYlolT4r40shfeX+CtYiNKKgjtqshcMDeWPcIKqusUY3a/4tezzoDc/5z1kUpNs+rggU7pR H/9AKwBvJEhq9MDf+/KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o10zo-007uXn-B4; Tue, 14 Jun 2022 07:29:52 +0000 Received: from mail-qv1-f53.google.com ([209.85.219.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o10zl-007uVx-7D for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 07:29:50 +0000 Received: by mail-qv1-f53.google.com with SMTP id 89so5971914qvc.0 for ; Tue, 14 Jun 2022 00:29:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MvW5zYgeysNwbbiYui7u/VFeyen3fLSMqOoOSFvD7qE=; b=8JkSqQLadXDaXb7pJ30IXX22e1c4/lwBuHx71SpyY/baC2XutuOl5s/JQXTwkfHgNJ lzpDeRg0EdtlGEcDLiJQPyja9dSV6uG8bv8G2VmXIYotZvHzoD2QdtlECSjZhhH5bP60 WPrHIt0P9a7WrHRU1+dBmYaQgzO03+yittLQoGtR5gJwhvCg4+sWgMTrmfznFaBVcqEe mxEe57SYJ/1PCqn09Nx7hHWWFq1qkOoZJZSV1gwpglNw6ToNS56wfZgHjzmyIfmY2Kle I3iO5ivyD2e0klDtk5UteP/9DJi6Pg1t6Q8kxv7UJdCiYHD2ocmf30e/iUpxYMAeLSJ/ lmhw== X-Gm-Message-State: AJIora+TUcXzc4AqkP3L8GSzjtJxON5GH83E5gdqHLDRozkAcSUD6NUs KLpw0CyKzNUFbimGedhKlkkI0BoV3Ak8PA== X-Google-Smtp-Source: AGRyM1tFQimjmHuAWDnzGjsHZS6oJnSDfIndFIJMWD0n7iFIDmcxAewJ2wx3txrpGso7e/VIvuCnXw== X-Received: by 2002:a05:6214:21a8:b0:46b:910a:a2f2 with SMTP id t8-20020a05621421a800b0046b910aa2f2mr2450085qvc.123.1655191785439; Tue, 14 Jun 2022 00:29:45 -0700 (PDT) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com. [209.85.219.172]) by smtp.gmail.com with ESMTPSA id w16-20020a05620a445000b006a768c699adsm8330145qkp.125.2022.06.14.00.29.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 00:29:45 -0700 (PDT) Received: by mail-yb1-f172.google.com with SMTP id v81so13836659ybe.0 for ; Tue, 14 Jun 2022 00:29:45 -0700 (PDT) X-Received: by 2002:a25:cc53:0:b0:65c:b19c:fac1 with SMTP id l80-20020a25cc53000000b0065cb19cfac1mr3399500ybf.89.1655191784829; Tue, 14 Jun 2022 00:29:44 -0700 (PDT) MIME-Version: 1.0 References: <20220609150851.23084-1-max.oss.09@gmail.com> <20220609150851.23084-6-max.oss.09@gmail.com> In-Reply-To: <20220609150851.23084-6-max.oss.09@gmail.com> From: Geert Uytterhoeven Date: Tue, 14 Jun 2022 09:29:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v1 5/5] ARM64: verdin-imx8mm: use regulator power domain to model sleep-moci To: Max Krummenacher Cc: Max Krummenacher , Ulf Hansson , Linux PM list , Francesco Dolcini , Mark Brown , "Rafael J . Wysocki" , Kevin Hilman , Andrejs Cainikovs , Fabio Estevam , Krzysztof Kozlowski , Marcel Ziswiler , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_002949_278889_52B9EE19 X-CRM114-Status: GOOD ( 26.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Max, On Thu, Jun 9, 2022 at 5:16 PM Max Krummenacher wrote: > From: Max Krummenacher > > The Verdin CTRL_SLEEP_MOCI# pin signals the carrier board that the module > is in sleep and it may switch off unneeded power. > > Control this pin with a regulator power domain controller which uses a > fixed regulator with a gpio enable. > > Signed-off-by: Max Krummenacher Thanks for your patch! > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi > @@ -92,6 +92,7 @@ > > /* Verdin PCIE_1 */ > &pcie0 { > + power-domains = <&pd_sleep_moci>; This overrides "power-domains = <&pgc_pcie>;" from imx8mm.dtsi... > status = "okay"; > }; > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > @@ -53,6 +53,14 @@ > }; > }; > > + pd_sleep_moci: power-domain-sleep-moci { > + compatible = "regulator-pm-pd"; > + label = "pd_sleep_moci"; > + power-domains = <&pgc_pcie>; ... and here you work around that by re-binding <&pgc_pcie>. I think you: 1. must not override the power-domains property for pcie0, as conceptually, the PCIe bus is still in the on-SoC power domain. What if some lanes are connected to devices in pd_sleep_moci, but other lanes are not? 2. should only use pd_sleep_moci for the off-chip devices that are actually controlled by the corresponding regulator. > + power-supply = <®_sleep_moci>; > + #power-domain-cells = <0>; > + }; > + > /* Carrier Board Supplies */ > reg_1p8v: regulator-1p8v { > compatible = "regulator-fixed"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel