From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5796DC433FE for ; Tue, 11 Oct 2022 14:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uQ/5zFbsp+hNZW31D0c2pXggDWwuzgsXpk04/avDh/c=; b=DrZOeO9OZX99LL b2+qJIHHDWfYxQP9fjuoHhbWrZpTcbcq13OaeEjkp1AgIwUKxtPh2bFZUtoPvwLCYlpXFeHO61zZ2 Mc/7eNE20MeZgMBvNpxQCxv5p3D7KaEbyQv6BwZNHqXPI5snvU09Up6G1l1A0DHIZUUMiDrb24TQ3 Z/9v6/eubjo0nwHDxH3RhJQv8hGGLKe2RgvzZ/ZxsOqf0VDOnQTBvBe69+pYKYzcAgl6W6/DIPPjP 3eaAKKiRnuVLgGG9YyVrT/R1DJIURRCKTk5sePrjB8OZf3tS05G7R6clkDDiz8PTXcfKZ/frcNd15 wNoHLmopYZGRW2LQdBpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiGQQ-004Vip-Qs; Tue, 11 Oct 2022 14:40:06 +0000 Received: from mail-qk1-f174.google.com ([209.85.222.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiGQN-004Vhb-VC; Tue, 11 Oct 2022 14:40:05 +0000 Received: by mail-qk1-f174.google.com with SMTP id x13so6052239qkg.11; Tue, 11 Oct 2022 07:40:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7sKcP+GTT+SWbU28Mvg7qTSCnoQqhpg8QoNv8i57vas=; b=zvpDHfa2VSwdulpprvn8rel96FCUHv2zXvUFhHRpuvJkxEhYwWHGLdHUA8vDhNzJQH WZU5nSsWd5t6CYwpExf1kdwUivRt8/DimUJurL680em80tB3Uw2EmtbBNOgShxZaNwL/ K+SstyGoGYkFs4AxxIh6UG257hYlsxLoJ7F9OH0YlGLOUBXng2gbq8LVPUtWgHASWxdK giQVUH2XCJT/st3tx6DxD9pzaZpW4L8JznqUa4j3Rx5g/OV6IKXbvEu/TfuNlNr8mexx dzzTcgbOjPD4D/R4/+YL6NzJdY66xtJiTe+a4ezRSGIERNpHLsXyyGo36vzrVO1kFiyH SqiA== X-Gm-Message-State: ACrzQf0OzMj1ax8MVAeQvP20Ekmx9W8Qbz4qzVhwb9Mh68czfC1il5pe vGPXzrO0cHp1KdrJ3D1yIHyg9tsdorJf7w== X-Google-Smtp-Source: AMsMyM4Ok3+GUY2y1BUUUF8v9n2blcx2BkuZ9aeevuBeunQsW5VYJic03S1OMTMyntSDuIYCsaHO6g== X-Received: by 2002:a05:620a:304:b0:6ee:77f1:ecf9 with SMTP id s4-20020a05620a030400b006ee77f1ecf9mr3332292qkm.94.1665499200916; Tue, 11 Oct 2022 07:40:00 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id b7-20020ac86787000000b0038b684a1642sm10625545qtp.32.2022.10.11.07.39.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 07:39:58 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id e20so16712982ybh.2; Tue, 11 Oct 2022 07:39:58 -0700 (PDT) X-Received: by 2002:a25:4fc2:0:b0:6be:afb4:d392 with SMTP id d185-20020a254fc2000000b006beafb4d392mr21857240ybb.604.1665499197788; Tue, 11 Oct 2022 07:39:57 -0700 (PDT) MIME-Version: 1.0 References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 11 Oct 2022 16:39:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) To: Andy Shevchenko Cc: Kent Gibson , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221011_074004_028184_33FE1350 X-CRM114-Status: GOOD ( 28.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Tue, Oct 11, 2022 at 4:31 PM Andy Shevchenko wrote: > On Tue, Oct 11, 2022 at 10:13:02PM +0800, Kent Gibson wrote: > > On Tue, Oct 11, 2022 at 04:48:17PM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 11, 2022 at 11:05:42AM +0300, Andy Shevchenko wrote: > > > > On Tue, Oct 11, 2022 at 3:02 AM Kent Gibson wrote: > > > > > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote: > > ... > > > > > > > -#include > > > > > > #include > > > > > > +#include > > > > > > +#include > > > > > > > > > > Ok with the hte re-order. > > > > > > > > > > But moving the gpio subsystem header after the gpio/driver is not > > > > > alphabetical ('.' precedes '/') and it read better and made more sense > > > > > to me the way it was. > > > > > > > > I see, I guess this is vim sort vs shell sort. Strange, they should > > > > follow the locale settings... > > > > > > I have checked, the shell and vim sort gave the same result as in this patch. > > > > > > > The original order (sans hte.h) was done by VSCode Sort Lines Ascending, > > and that still returns the same result. That matches what I would > > expect to see given the content of the text. > > > > And for me vim also gives the original order. > > > > Just to confirm - is '.' 0x2e and '/' 0x2f in your universe? > > $ LC_COLLATE=C sort test1.txt > #include > #include > > $ LC_COLLATE= sort test1.txt > #include > #include > > I guess this explains the difference. Currently I have en_US.UTF-8. Throwing my can of paint into the mix... I think it is more logical to first include the general , followed by whatever and , irrespective of (language-specific or phonebook) sort order. Yeah, it sucks that this requires some manual work after running sort... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel